linux-toradex.git/drivers/devfreq/event/exynos-ppmu.c, branch v6.4-rc3

PM / devfreq: exynos-ppmu: Use devm_platform_get_and_ioremap_resource()

2023-04-03T15:09:32+00:00

According to commit 890cc39a8799 ("drivers: provide
devm_platform_get_and_ioremap_resource()"), convert
platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Signed-off-by: Yang Li 
Reviewed-by: Andi Shyti 
Signed-off-by: Chanwoo Choi

PM / devfreq: exynos-ppmu: Fix refcount leak in of_get_devfreq_events

2022-06-29T20:11:17+00:00

of_get_child_by_name() returns a node pointer with refcount
incremented, we should use of_node_put() on it when done.
This function only calls of_node_put() in normal path,
missing it in error paths.
Add missing of_node_put() to avoid refcount leak.

Fixes: f262f28c1470 ("PM / devfreq: event: Add devfreq_event class")
Signed-off-by: Miaoqian Lin 
Signed-off-by: Chanwoo Choi

devfreq: exynos-ppmu: simplify parsing event-type from DT

2021-10-27T05:22:12+00:00

When parsing devicetree, the function of_get_devfreq_events(), for each
device child node, iterates over array of possible events "ppmu_events"
till it finds one matching by node name.  When match is found the
ppmu_events[i] points to element having both the name of the event and
the counters ID.

Each PPMU device child node might have an "event-name" property with the
name of the event, however due to the design of devfreq it must be the
same as the device node name.  If it is not the same, the devfreq client
won't be able to use it via devfreq_event_get_edev_by_phandle().

Since PPMU device child node name must be equal to the "event-name"
property (event-name == ppmu_events[i].name), there is no need to find
the counters ID by the "event-name".  Instead use ppmu_events[i].id
which must be equal to it.

Signed-off-by: Krzysztof Kozlowski 
Tested-by: Marek Szyprowski 
Signed-off-by: Chanwoo Choi

devfreq: exynos-ppmu: use node names with hyphens

2021-10-27T05:22:11+00:00

Devicetree naming convention requires device node names to use hyphens
instead of underscore, so Exynos5422 devfreq event name
"ppmu-event3-dmc0_0" should be "ppmu-event3-dmc0-0".  Newly introduced
dtschema enforces this, however the driver still expects old name with
an underscore.

Add new events for Exynos5422 while still accepting old name for
backwards compatibility.

Signed-off-by: Krzysztof Kozlowski 
Tested-by: Marek Szyprowski 
Signed-off-by: Chanwoo Choi

PM / devfreq: exynos: Rename Exynos to lowercase

2020-01-06T01:50:09+00:00

Fix up inconsistent usage of upper and lowercase letters in "Exynos"
name.

"EXYNOS" is not an abbreviation but a regular trademarked name.
Therefore it should be written with lowercase letters starting with
capital letter.

The lowercase "Exynos" name is promoted by its manufacturer Samsung
Electronics Co., Ltd., in advertisement materials and on website.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Chanwoo Choi

PM / devfreq: exynos-ppmu: Fix excessive stack usage

2019-12-30T00:59:04+00:00

Putting a 'struct devfreq_event_dev' object on the stack is generally
a bad idea and here it leads to a warnig about potential stack overflow:

drivers/devfreq/event/exynos-ppmu.c:643:12: error: stack frame size of 1040 bytes in function 'exynos_ppmu_probe' [-Werror,-Wframe-larger-than=]

There is no real need for the device structure, only the string inside
it, so add an internal helper function that simply takes the string
as its argument and remove the device structure.

Fixes: 1dd62c66d345 ("PM / devfreq: events: extend events by type of counted data")
Signed-off-by: Arnd Bergmann 
[cw00.choi: Fix the issue from 'desc->name' to 'desc[j].name']
Signed-off-by: Chanwoo Choi

PM / devfreq: exynos-ppmu: remove useless assignment

2019-11-06T03:04:00+00:00

The error code is propagated to the caller, so there is no need to keep
it additionally in the unused variable.

Signed-off-by: Marek Szyprowski 
Acked-by: Chanwoo Choi 
Signed-off-by: Chanwoo Choi

PM / devfreq: events: extend events by type of counted data

2019-08-25T03:44:38+00:00

This patch adds posibility to choose what type of data should be counted
by the PPMU counter. Now the type comes from DT where the event has been
defined. When there is no 'event-data-type' the default value is used,
which is 'read+write data in bytes'.
It is needed when you want to know not only read+write data bytes but
i.e. only write data in byte, or number of read requests, etc.

Signed-off-by: Lukasz Luba 
Acked-by: Chanwoo Choi 
[Updated property by MyungJoo. data_type --> event_type]
Signed-off-by: MyungJoo Ham

PM / devfreq: exynos-events: change matching code during probe

2019-08-25T03:36:47+00:00

The patch changes the way how the 'ops' gets populated for different
device versions. The matching function now uses 'of_device_id' in order
to identify the device type.

Signed-off-by: Lukasz Luba 
Signed-off-by: Chanwoo Choi 
Signed-off-by: MyungJoo Ham

PM / devfreq: events: add Exynos PPMU new events

2019-08-24T11:11:12+00:00

Define new performance events supported by Exynos5422 SoC counters.
The counters are built-in in Dynamic Memory Controller and provide
information regarding memory utilization.

Signed-off-by: Lukasz Luba 
Acked-by: Chanwoo Choi 
Signed-off-by: MyungJoo Ham