linux-toradex.git/drivers/devfreq/rk3399_dmc.c, branch v5.10-rc4

PM / devfreq: event: Change prototype of devfreq_event_get_edev_by_phandle function

2020-09-29T08:50:10+00:00

Previously, devfreq core support 'devfreq-events' property in order to get
the devfreq-event device by phandle. But, 'devfreq-events' property name is
not proper on devicetree binding because this name doesn't mean
the any h/w attribute.

The devfreq-event core hand over the rights to decide the property name
for getting the devfreq-event device on devicetree. Each devfreq-event driver
will decide the property name on devicetree binding and then pass
the their own property name to devfreq_event_get_edev_by_phandle function.

And change the prototype of devfreq_event_get_edev_count function
because of used deprecated 'devfreq-events' property.

Acked-by: Krzysztof Kozlowski 
Signed-off-by: Chanwoo Choi

PM / devfreq: rk3399_dmc: Fix kernel oops when rockchip,pmu is absent

2020-07-30T08:22:57+00:00

Booting a recent kernel on a rk3399-based system (nanopc-t4),
equipped with a recent u-boot and ATF results in an Oops due
to a NULL pointer dereference.

This turns out to be due to the rk3399-dmc driver looking for
an *undocumented* property (rockchip,pmu), and happily using
a NULL pointer when the property isn't there.

Instead, make most of what was brought in with 9173c5ceb035
("PM / devfreq: rk3399_dmc: Pass ODT and auto power down parameters
to TF-A.") conditioned on finding this property in the device-tree,
preventing the driver from exploding.

Cc: stable@vger.kernel.org
Fixes: 9173c5ceb035 ("PM / devfreq: rk3399_dmc: Pass ODT and auto power down parameters to TF-A.")
Signed-off-by: Marc Zyngier 
Signed-off-by: Chanwoo Choi

PM / devfreq: rk3399_dmc: Disable devfreq-event device when fails

2019-12-30T00:59:06+00:00

The probe process may fail, but the devfreq event device remains
enabled. Call devfreq_event_disable_edev on the error return path.

Signed-off-by: Yangtao Li 
Signed-off-by: Chanwoo Choi

PM / devfreq: rk3399_dmc: Add missing of_node_put()

2019-12-30T00:59:06+00:00

of_node_put() needs to be called when the device node which is got
from of_parse_phandle has finished using.

Signed-off-by: Yangtao Li 
Signed-off-by: Chanwoo Choi

PM / devfreq: rk3399_dmc: Fix spelling typo

2019-08-24T11:11:12+00:00

Reorder 'i' and 'v' in "drvier".

Signed-off-by: Gaël PORTAY 
Reviewed-by: Chanwoo Choi 
Signed-off-by: MyungJoo Ham

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 288

2019-06-05T15:36:37+00:00

Based on 1 normalized pattern(s):

  this program is free software you can redistribute it and or modify
  it under the terms and conditions of the gnu general public license
  version 2 as published by the free software foundation this program
  is distributed in the hope it will be useful but without any
  warranty without even the implied warranty of merchantability or
  fitness for a particular purpose see the gnu general public license
  for more details

extracted by the scancode license scanner the SPDX license identifier

  GPL-2.0-only

has been chosen to replace the boilerplate/reference in 263 file(s).

Signed-off-by: Thomas Gleixner 
Reviewed-by: Allison Randal 
Reviewed-by: Alexios Zavras 
Cc: linux-spdx@vger.kernel.org
Link: https://lkml.kernel.org/r/20190529141901.208660670@linutronix.de
Signed-off-by: Greg Kroah-Hartman

PM / devfreq: rk3399_dmc: Pass ODT and auto power down parameters to TF-A.

2019-04-16T00:29:18+00:00

Trusted Firmware-A (TF-A) for rk3399 implements a SiP call to get the
on-die termination (ODT) and auto power down parameters from kernel,
this patch adds the functionality to do this. Also, if DDR clock
frequency is lower than the on-die termination (ODT) disable frequency
this driver should disable the DDR ODT.

Signed-off-by: Enric Balletbo i Serra 
Reviewed-by: Chanwoo Choi 
Signed-off-by: Gaël PORTAY 
Signed-off-by: MyungJoo Ham

PM / devfreq: rk3399_dmc: remove unneeded semicolon

2019-04-16T00:29:18+00:00

The semicolon is unneeded, so remove it.

Signed-off-by: Yangtao Li 
Reviewed-by: Chanwoo Choi 
Signed-off-by: MyungJoo Ham

PM / devfreq: rk3399_dmc: Fix duplicated opp table on reload.

2018-07-18T04:58:39+00:00

The opp table is not removed when the driver is unloaded neither when
there is an error within probe, so if the driver is reloaded the opp
core shows the following warning:

  rk3399-dmc-freq dmc: _opp_add: duplicate OPPs detected. Existing: freq:
               200000000, volt: 900000, enabled: 1. New: freq: 200000000,
               volt: 900000, enabled: 1
  rk3399-dmc-freq dmc: _opp_add: duplicate OPPs detected. Existing: freq:
               400000000, volt: 900000, enabled: 1. New: freq: 400000000,
               volt: 900000, enabled: 1
  rk3399-dmc-freq dmc: _opp_add: duplicate OPPs detected. Existing: freq:
               666000000, volt: 900000, enabled: 1. New: freq: 666000000,
               volt: 900000, enabled: 1
  rk3399-dmc-freq dmc: _opp_add: duplicate OPPs detected. Existing: freq:
               800000000, volt: 900000, enabled: 1. New: freq: 800000000,
               volt: 900000, enabled: 1
  rk3399-dmc-freq dmc: _opp_add: duplicate OPPs detected. Existing: freq:
               928000000, volt: 900000, enabled: 1. New: freq: 928000000,
               volt: 900000, enabled: 1

This patch fixes the error path in the probe function and adds a .remove
function to properly cleanup the opp table on unloading.

Fixes: 5a893e31a636c (PM / devfreq: rockchip: add devfreq driver for rk3399 dmc)
Signed-off-by: Enric Balletbo i Serra 
Reviewed-by: Chanwoo Choi 
Signed-off-by: MyungJoo Ham

PM / devfreq: rk3399_dmc: fix spelling mistakes.

2018-07-18T04:58:38+00:00

Fix some spelling mistakes in error and debug messages.

Signed-off-by: Enric Balletbo i Serra 
Signed-off-by: MyungJoo Ham