linux-toradex.git/drivers/dma/amba-pl08x.c, branch v3.10.33

pl080.h: moved from arm/include/asm/hardware to include/linux/amba/

2013-01-13T13:19:45+00:00

The header is used by drivers/dma/amba-pl08x.c, which can be compiled
under x86, where PL080 exists under a PCI-to-AMBA bridge. This patche
moves it where it can be accessed by other architectures, and fixes
all users.

Signed-off-by: Alessandro Rubini 
Acked-by: Giancarlo Asnaghi 
Acked-by: Linus Walleij 
Signed-off-by: Vinod Koul

dma: amba-pl08x: use vchan_dma_desc_free_list

2013-01-08T06:04:54+00:00

vchan_dma_desc_free_list() iterates through each virt_dma_desc in the
specified list_head and calls vchan->desc_free().

We can use it instead of repeated execution of pl08x_desc_free() for each
virt_dma_desc in the list_head.  Because vchan->desc_free callback is set
as pl08x_desc_free() for amba-pl08x driver.

Signed-off-by: Akinobu Mita 
Cc: Vinod Koul 
Cc: Dan Williams 
Signed-off-by: Vinod Koul

drivers/dma/amba-pl08x.c: fix error return code

2012-08-22T04:21:04+00:00

Convert a 0 error return code to a negative one, as returned elsewhere in the
function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// 
@@
identifier ret;
expression e,e1,e2,e3,e4,x;
@@

(
if (\(ret != 0\|ret < 0\) || ...) { ... return ...; }
|
ret = 0
)
... when != ret = e1
*x = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\|ioremap\|ioremap_nocache\|devm_ioremap\|devm_ioremap_nocache\)(...);
... when != x = e2
    when != ret = e3
*if (x == NULL || ...)
{
  ... when != ret = e4
*  return ret;
}
// 

Signed-off-by: Julia Lawall 
Signed-off-by: Vinod Koul

dmaengine: PL08x: ensure all descriptors are freed when channel is released

2012-07-01T13:16:10+00:00

Ensure all queued descriptors are freed when the channel is released,
ensuring we don't leak memory

Acked-by: Linus Walleij 
Tested-by: Linus Walleij 
Signed-off-by: Russell King

dmaengine: PL08x: get rid of write only pool_ctr and free_txd locking

2012-07-01T13:16:08+00:00

The free function says the pl08x lock should be taken before calling
it.  However, the DMA pool allocation/freeing is already properly
locked.  The only thing that would need this is pool_ctr, which
happens to be a write-only variable.

Let's get rid of this, and eliminate any need for additional locking
here.

Acked-by: Linus Walleij 
Tested-by: Linus Walleij 
Signed-off-by: Russell King

dmaengine: PL08x: get rid of pl08x_prep_channel_resources

2012-07-01T13:16:05+00:00

This function is now unnecessary; we can move its internals inline
instead.

Acked-by: Linus Walleij 
Tested-by: Linus Walleij 
Signed-off-by: Russell King

dmaengine: PL08x: fix tx_status function to return correct residue

2012-07-01T13:16:02+00:00

Now that we're converted to use the generic vchan support, we can fix
the residue return from tx_status to be compliant with dmaengine.  This
returns the number of bytes remaining for the _specified_ cookie, not
the number of bytes in all pending transfers on the channel.

Acked-by: Linus Walleij 
Tested-by: Linus Walleij 
Signed-off-by: Russell King

dmaengine: PL08x: convert to use vchan done list

2012-07-01T13:16:01+00:00

Convert to use the virtual dma channel done list, tasklet, and
descriptor freeing.

Acked-by: Linus Walleij 
Tested-by: Linus Walleij 
Signed-off-by: Russell King

dmaengine: PL08x: convert to use vchan submitted/issued lists

2012-07-01T13:16:00+00:00

Convert to use the virtual dma channel submitted/issued descriptor
lists rather than our own private lists, and use the virtual dma
channel support functions to manage these lists.

Acked-by: Linus Walleij 
Tested-by: Linus Walleij 
Signed-off-by: Russell King

dmaengine: PL08x: use vchan's spinlock

2012-07-01T13:15:59+00:00

Initialize the vchan struct, and use the provided spinlock rather than
our own.

Acked-by: Linus Walleij 
Tested-by: Linus Walleij 
Signed-off-by: Russell King