linux-toradex.git/drivers/dma/cppi41.c, branch v3.14.57

drivers/dma: fix error return code

2014-01-20T09:28:03+00:00

Set the return variable to an error code as done elsewhere in the function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// 
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}

// 

Signed-off-by: Julia Lawall 
Signed-off-by: Vinod Koul

dma: cppi41: return code > 0 of pm_runtime_get_sync() is not an error

2013-11-12T08:58:25+00:00

Return code of pm_runtime_get_sync() > 0 is not an error and may happen.
Noticed during rmmod & modprobe testing.

Signed-off-by: Sebastian Andrzej Siewior 
Signed-off-by: Vinod Koul

dma: cppi41: redo descriptor collection in abort case

2013-11-12T08:58:24+00:00

Most of the logic here is try and error since what actually happens does
not match the trm or I miss read it.
My first assumption was that the queue on which the tear-down descriptor
completes (their own complete queue vs "active descriptor" complete
queue) depends on the transfer direction. This seems not to be true
because I manage to trigger
|  WARN_ON(c->desc_phys != desc_phys);
and the other few were fine means the tear-down descriptor was valid but
on different queue.

This patch changes the logic here to look on both queues for the
descriptor.

Signed-off-by: Sebastian Andrzej Siewior 
Signed-off-by: Vinod Koul

dma: cppi41: use cppi41_pop_desc() where possible

2013-11-12T08:58:24+00:00

Use cppi41_pop_desc() when appropriate instead of open-coding the same
functionality again. That makes the code more readable. The function has
to be moved some lines up for this change.

Signed-off-by: Daniel Mack 
Signed-off-by: Sebastian Andrzej Siewior 
Signed-off-by: Vinod Koul

dma: cppi41: restore more registers

2013-11-12T08:58:24+00:00

With active users over suspend/resume cycles, it turns out that
more registers, in particular DMA_TDFDQ and RXHPCRA0, have to be
restored on resume.

Signed-off-by: Daniel Mack 
Signed-off-by: Sebastian Andrzej Siewior 
Signed-off-by: Vinod Koul

dmaengine: cppi41: use DMA_COMPLETE for dma completion status

2013-10-25T05:45:57+00:00

Acked-by: Dan Williams 
Acked-by: Linus Walleij 
Signed-off-by: Vinod Koul

dma: cppi41: add support for suspend and resume

2013-10-07T02:11:39+00:00

This patch adds support for suspend/resume functionality to the cppi41
DMA driver. The steps necessary to make the system resume properly were
figured out by trial-and-error. The code as it stands now is the
minimum that has to be done to put the musb host system on an AM33xx
system into an operable state after resume.

Signed-off-by: Daniel Mack 
Signed-off-by: Vinod Koul

dma: cppi41: add shortcut to &pdev->dev in cppi41_dma_probe()

2013-10-07T02:11:39+00:00

Makes the code more readable and compact. No functional change.

Signed-off-by: Daniel Mack 
Signed-off-by: Vinod Koul

dma: cppi41: s/deinit_cpii41/deinit_cppi41/

2013-10-07T02:11:39+00:00

Fix a misspelled function name.

Signed-off-by: Daniel Mack 
Signed-off-by: Vinod Koul

dma: cppi41: pass around device instead of platform_device

2013-10-07T02:11:39+00:00

Instead of passing around struct plafform_device, use struct device and
save one level of dereferencing. This affects the following functions:

 * cppi41_add_chans
 * purge_descs
 * deinit_cpii41
 * init_descs
 * init_cppi41
 * cppi_glue_infos

It's just a cosmetic cleanup that makes the code more readable.

Signed-off-by: Daniel Mack 
Signed-off-by: Vinod Koul