linux-toradex.git/drivers/dma/dmatest.c, branch v4.19

dmaengine: dmatest: Remove use of VLAs

2018-04-16T15:35:54+00:00

There's an ongoing effort to remove VLAs from the kernel
(https://lkml.org/lkml/2018/3/7/621) to eventually turn on -Wvla.
The test already pre-allocates some buffers with kmalloc so turn
the two VLAs in to pre-allocated kmalloc buffers.

Signed-off-by: Laura Abbott 
Reviewed-by: Sinan Kaya 
Signed-off-by: Vinod Koul

dmaengine: dmatest: add norandom option

2018-02-12T03:46:01+00:00

Existing option noverify disables both random src/dst address offset
setup and data verification. Sometimes, we need to control random
src/dst address setup and verification separately, such as disabling
random to make sure that test covers addresses in all interleaving
banks, but data verification is still performed.

This patch adds option norandom to disable random offset setup. Option
noverify has been changed to disable data verification only.

Cc: Joey Zheng 
Signed-off-by: Yang Shunyong 
Signed-off-by: Vinod Koul

dmaengine: dmatest: fix container_of member in dmatest_callback

2018-01-30T06:54:43+00:00

The type of arg passed to dmatest_callback is struct dmatest_done.
It refers to test_done in struct dmatest_thread, not done_wait.

Fixes: 6f6a23a213be ("dmaengine: dmatest: move callback wait ...")
Signed-off-by: Yang Shunyong 
Acked-by: Adam Wallis 
Signed-off-by: Vinod Koul

dmaengine: dmatest: move callback wait queue to thread context

2017-12-11T03:16:24+00:00

Commit adfa543e7314 ("dmatest: don't use set_freezable_with_signal()")
introduced a bug (that is in fact documented by the patch commit text)
that leaves behind a dangling pointer. Since the done_wait structure is
allocated on the stack, future invocations to the DMATEST can produce
undesirable results (e.g., corrupted spinlocks).

Commit a9df21e34b42 ("dmaengine: dmatest: warn user when dma test times
out") attempted to WARN the user that the stack was likely corrupted but
did not fix the actual issue.

This patch fixes the issue by pushing the wait queue and callback
structs into the the thread structure. If a failure occurs due to time,
dmaengine_terminate_all will force the callback to safely call
wake_up_all() without possibility of using a freed pointer.

Cc: stable@vger.kernel.org
Bug: https://bugzilla.kernel.org/show_bug.cgi?id=197605
Fixes: adfa543e7314 ("dmatest: don't use set_freezable_with_signal()")
Reviewed-by: Sinan Kaya 
Suggested-by: Shunyong Yang 
Signed-off-by: Adam Wallis 
Signed-off-by: Vinod Koul

dmaengine: dmatest: warn user when dma test times out

2017-11-08T05:54:03+00:00

Commit adfa543e7314 ("dmatest: don't use set_freezable_with_signal()")
introduced a bug (that is in fact documented by the patch commit text)
that leaves behind a dangling pointer. Since the done_wait structure is
allocated on the stack, future invocations to the DMATEST can produce
undesirable results (e.g., corrupted spinlocks). Ideally, this would be
cleaned up in the thread handler, but at the very least, the kernel
is left in a very precarious scenario that can lead to some long debug
sessions when the crash comes later.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=197605
Signed-off-by: Adam Wallis 
Signed-off-by: Vinod Koul

dmaengine: remove DMA_SG as it is dead code in kernel

2017-08-22T03:52:11+00:00

There are no in kernel consumers for DMA_SG op. Removing operation,
dead code, and test code in dmatest.

Signed-off-by: Dave Jiang 
Reviewed-by: Linus Walleij 
Cc: Gary Hook 
Cc: Ludovic Desroches 
Cc: Kedareswara rao Appana 
Cc: Li Yang 
Cc: Michal Simek 
Signed-off-by: Vinod Koul

dmaengine: dmatest: add support for memset test

2017-07-18T16:25:34+00:00

Introducing memset test into dmatest. This change allows us to test
memset capable HW using the dmatest test procedure. The new dmatest
value for memset is 2 and it is not the default value.

Memset support patch shares the same code path as the other dmatest
code to reuse as much as we can.

The first value inside the source buffer is used as a pattern
to fill in the destination buffer space.

Prior to running the test, source/destination buffers are initialized
in the current code.

"The remaining bits are the inverse of a counter which increments by
 one for each byte address."

Memset test will fill in the upper bits of pattern with the inverse of
fixed counter value 1 as opposed to an incrementing value in a loop.

An example run is as follows:

echo dma0chan0 > /sys/module/dmatest/parameters/channel
echo 2 >  /sys/module/dmatest/parameters/dmatest
echo 2000 >  /sys/module/dmatest/parameters/timeout
echo 10 >  /sys/module/dmatest/parameters/iterations
echo 1 >  /sys/module/dmatest/parameters/run

Reviewed-by: Andy Shevchenko 
Signed-off-by: Sinan Kaya 
Signed-off-by: Vinod Koul

dmaengine: dmatest: Add check for supported buffer count (sg_buffers)

2017-05-01T10:21:06+00:00

When using dmatest with sg_buffers=128 I stumbled upon the problem, that
the "map_cnt" variable of "struct dmaengine_unmap_data" was set to 0.
"map_cnt" is an "u8" variable, resulting in an overrun when its
value is set to src_cnt + dst_cnt, to twice the sg_buffer value.

This patch adds a small check to dmatest, so that this confusing error
is detected and the test is aborted.

Signed-off-by: Stefan Roese 
Cc: Kedareswara rao Appana 
Cc: Vinod Koul 
Signed-off-by: Vinod Koul

dmaengine: dmatest: use offset_in_page() macro

2017-04-24T13:10:03+00:00

Use offset_in_page() macro instead of open-coding.

Signed-off-by: Geliang Tang 
Signed-off-by: Vinod Koul

sched/headers: Prepare to move the get_task_struct()/put_task_struct() and related APIs from to

2017-03-02T07:42:40+00:00

But first update usage sites with the new header dependency.

Acked-by: Linus Torvalds 
Cc: Mike Galbraith 
Cc: Peter Zijlstra 
Cc: Thomas Gleixner 
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ingo Molnar