linux-toradex.git/drivers/dma/intel_mid_dma.c, branch v3.11

PM / Runtime: Rework the "runtime idle" helper routine

2013-06-03T19:49:52+00:00

The "runtime idle" helper routine, rpm_idle(), currently ignores
return values from .runtime_idle() callbacks executed by it.
However, it turns out that many subsystems use
pm_generic_runtime_idle() which checks the return value of the
driver's callback and executes pm_runtime_suspend() for the device
unless that value is not 0.  If that logic is moved to rpm_idle()
instead, pm_generic_runtime_idle() can be dropped and its users
will not need any .runtime_idle() callbacks any more.

Moreover, the PCI, SCSI, and SATA subsystems' .runtime_idle()
routines, pci_pm_runtime_idle(), scsi_runtime_idle(), and
ata_port_runtime_idle(), respectively, as well as a few drivers'
ones may be simplified if rpm_idle() calls rpm_suspend() after 0 has
been returned by the .runtime_idle() callback executed by it.

To reduce overall code bloat, make the changes described above.

Tested-by: Mika Westerberg 
Tested-by: Kevin Hilman 
Signed-off-by: Rafael J. Wysocki 
Acked-by: Kevin Hilman 
Reviewed-by: Ulf Hansson 
Acked-by: Alan Stern

Drivers: dma: remove __dev* attributes.

2013-01-03T23:57:15+00:00

CONFIG_HOTPLUG is going away as an option.  As a result, the __dev*
markings need to be removed.

This change removes the use of __devinit, __devexit_p, __devinitconst,
and __devexit from these drivers.

Based on patches originally written by Bill Pemberton, but redone by me
in order to handle some of the coding style issues better, by hand.

Cc: Bill Pemberton 
Cc: Viresh Kumar 
Cc: Dan Williams 
Cc: Vinod Koul 
Cc: Barry Song 
Cc: Jeff Kirsher 
Cc: Alexander Duyck 
Cc: Russell King 
Cc: Linus Walleij 
Cc: Jassi Brar 
Cc: Dave Jiang 
Cc: Bill Pemberton 
Cc: Guennadi Liakhovetski 
Signed-off-by: Greg Kroah-Hartman

dma: remove use of __devinit

2012-11-28T20:42:36+00:00

CONFIG_HOTPLUG is going away as an option so __devinit is no longer
needed.

Signed-off-by: Bill Pemberton 
Cc: Li Yang 
Cc: Zhang Wei 
Cc: Barry Song 
Acked-by: Viresh Kumar 
Signed-off-by: Greg Kroah-Hartman

dma: remove use of __devexit_p

2012-11-28T20:41:36+00:00

CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
needed.

Signed-off-by: Bill Pemberton 
Acked-by: Barry Song 
Acked-by: Viresh Kumar 
Acked-by: Russell King 
Signed-off-by: Greg Kroah-Hartman

treewide: fix comment/printk/variable typos

2012-09-01T17:33:05+00:00

Signed-off-by: Anatol Pomozov 
Signed-off-by: Jiri Kosina

dmaengine: Use dma_sg_len(sg) instead of sg->length

2012-05-11T06:34:38+00:00

sg->length may or may not contain the length of the dma region to transfer,
depending on the architecture - dma_sg_len(sg) always will though. For the
architectures which use the drivers modified by this patch it probably is the
case that sg->length contains the dma transfer length. But to be consistent and
future proof change them to use dma_sg_len.

To quote Russel King:
	sg->length is meaningless to something performing DMA.

	In cases where sg_dma_len(sg) and sg->length are the same storage, then
	there's no problem. But scatterlists _can_ (and one some architectures) do
	split them - especially when you have an IOMMU which can allow you to
	combine a scatterlist into fewer entries.

	So, anything using sg->length for the size of a scatterlist's DMA transfer
	_after_ a call to dma_map_sg() is almost certainly buggy.

The patch has been generated using the following coccinelle patch:

@@
struct scatterlist *sg;
expression X;
@@
-sg[X].length
+sg_dma_len(&sg[X])
@@
struct scatterlist *sg;
@@
-sg->length
+sg_dma_len(sg)


Signed-off-by: Lars-Peter Clausen 
Acked-by: Linus Walleij 
Signed-off-by: Vinod Koul

dmaengine: Use sg_dma_address instead of sg_phys

2012-05-11T06:34:38+00:00

dmaengine drivers should always use sg_dma_address instead of sg_phys to get the
addresses for the transfer from a sg element.

To quote Russel King:
	sg_phys(sg) of course has nothing to do with DMA addresses. It's the
	physical address _to the CPU_ of the memory associated with the scatterlist
	entry. That may, or may not have the same value for the DMA engine,
	particularly if IOMMUs are involved.

	And if these drivers are used on ARM, they must be fixed, sooner rather
	than later.  There's patches in the works which will mean we will end up
	with IOMMU support in the DMA mapping later, which means everything I've
	said above will become reality.

The patch has been generated using the following coccinelle patch:

@@
struct scatterlist *sg;
@@
-sg_phys(sg)
+sg_dma_address(sg)


Signed-off-by: Lars-Peter Clausen 
Acked-by: Linus Walleij 
Signed-off-by: Vinod Koul

dmaengine: add context parameter to prep_slave_sg and prep_dma_cyclic

2012-03-21T13:50:23+00:00

Add context parameter to device_prep_slave_sg() and device_prep_dma_cyclic()
interfaces to allow passing client/target specific information associated
with the data transfer.
Modify all affected DMA engine drivers.

Signed-off-by: Alexandre Bounine 
Acked-by: Linus Walleij 
Acked-by: Felipe Balbi 
Signed-off-by: Vinod Koul

dmaengine: fix for cookie changes and merge

2012-03-13T06:28:12+00:00

Fixed trivial issues in drivers:
	drivers/dma/imx-sdma.c
	drivers/dma/intel_mid_dma.c
	drivers/dma/ioat/dma_v3.c
	drivers/dma/iop-adma.c
	drivers/dma/sirf-dma.c
	drivers/dma/timb_dma.c

Signed-off-by: Vinod Koul

dmaengine: consolidate initialization of cookies

2012-03-13T06:07:22+00:00

Provide a common function to initialize a channels cookie values.

Signed-off-by: Russell King 
Tested-by: Linus Walleij 
Reviewed-by: Linus Walleij 
Acked-by: Jassi Brar 
[imx-sdma.c & mxs-dma.c]
Tested-by: Shawn Guo 
Signed-off-by: Vinod Koul