linux-toradex.git/drivers/dma/mv_xor.h, branch v3.8.13

dma: mv_xor: clear the window override control registers

2012-11-22T17:16:37+00:00

The XOR channels on Marvell SoCs have a Window Override Control
register that allow to do some fancy things with addresses. Those
features are not used by the driver, but some U-Boot versions anyway
modify those registers.

For some reason, the U-Boot on OpenBlocks AX3-4 was setting an invalid
value in those registers when the addition 2 GB DRAM chip was plugged
into the board, causing the XOR driver to fail in using the XOR
engines.

By setting those registers to 0 during the driver initialization, we
ensure that the registers are configured according with the driver
operation model.

Thanks to Lior Amsalem  for his help in debugging
this problem.

Signed-off-by: Thomas Petazzoni

dma: mv_xor: add missing free_irq() call

2012-11-20T14:59:00+00:00

Even though the driver cannot be unloaded at the moment, it is still
good to properly free the IRQ handlers in the channel removal function.

Signed-off-by: Thomas Petazzoni

dma: mv_xor: remove the pool_size from platform_data

2012-11-20T14:59:00+00:00

The pool_size is always PAGE_SIZE, and since it is a software
configuration paramter (and not a hardware description parameter), we
cannot make it part of the Device Tree binding, so we'd better remove
it from the platform_data as well.

Signed-off-by: Thomas Petazzoni

dma: mv_xor: remove useless backpointer from mv_xor_chan to mv_xor_device

2012-11-20T14:58:59+00:00

The backpointer from mv_xor_chan to mv_xor_device is now useless, get
rid of it.

Signed-off-by: Thomas Petazzoni

dma: mv_xor: rename mv_xor_private to mv_xor_device

2012-11-20T14:58:59+00:00

Now that mv_xor_device is no longer used to designate the per-channel
DMA devices, use it know to designate the XOR engine themselves
(currently composed of two XOR channels).

So, now we have the nice organization where:

 - mv_xor_device represents each XOR engine in the system
 - mv_xor_chan   represents each XOR channel of a given XOR engine

Signed-off-by: Thomas Petazzoni

dma: mv_xor: merge mv_xor_device and mv_xor_chan

2012-11-20T14:58:59+00:00

Even though the DMA engine infrastructure has support for multiple
channels per device, the mv_xor driver registers one DMA engine device
for each channel, because the mv_xor channels inside the same XOR
engine have different capabilities, and the DMA engine infrastructure
only allows to express capabilities at the DMA engine device level.

The mv_xor driver has therefore been registering one DMA engine device
and one DMA engine channel for each XOR channel since its introduction
in the kernel. However, it kept two separate internal structures,
mv_xor_device and mv_xor_channel, which didn't make a lot of sense
since there was a 1:1 mapping between those structures.

This patch gets rid of this duplication, and merges everything into
the mv_xor_chan structure.

Signed-off-by: Thomas Petazzoni

dma: mv_xor: in mv_xor_device, rename 'common' to 'dmadev'

2012-11-20T14:58:59+00:00

The mv_xor_device structure embeds a 'struct dma_device', which is
named 'common', a not very meaningful name. Rename it to 'dmadev',
which will help avoid confusions later as we merge the mv_xor_device
and mv_xor_chan structures together.

Signed-off-by: Thomas Petazzoni

dma: mv_xor: in mv_xor_chan, rename 'common' to 'dmachan'

2012-11-20T14:58:58+00:00

The mv_xor_chan structure embeds a 'struct dma_chan', which is named
'common', a not very meaningful name. Rename it to 'dmachan', which
will help avoid confusions later as we merge the mv_xor_device and
mv_xor_chan structures together.

Signed-off-by: Thomas Petazzoni

dma: mv_xor: get rid of the pdev pointer in mv_xor_device

2012-11-20T14:58:58+00:00

It was only used in places where we could get the 'struct device *'
pointer through a different way.

Signed-off-by: Thomas Petazzoni

dma: mv_xor: remove unused id field in mv_xor_device structure

2012-11-20T14:58:58+00:00

Signed-off-by: Thomas Petazzoni