linux-toradex.git/drivers/dma/ste_dma40_ll.c, branch v4.16

dmaengine: ste_dma40_ll: make d40_width_to_bits static

2016-06-08T03:29:55+00:00

Fix warning due to d40_width_to_bits() not being used outside
this file. Fixes:

drivers/dma/ste_dma40_ll.c:13:4: warning: symbol 'd40_width_to_bits' was not declared. Should it be static?

Signed-off-by: Ben Dooks 
Signed-off-by: Vinod Koul

dmaengine: ste_dma40_ll: Replace meaningless register set with comment

2013-06-04T09:12:10+00:00

Unsure of the author's intentions, rather than just removing the nop,
we're replacing it with a comment containing the possible intention
of the statement OR:ing with 0.

Cc: Dan Williams 
Cc: Per Forlin 
Cc: Rabin Vincent 
Acked-by: Vinod Koul 
Signed-off-by: Lee Jones 
Signed-off-by: Linus Walleij

dmaengine: ste_dma40: Convert data_width from register bit format to value

2013-06-04T09:12:09+00:00

When a DMA client requests and configures a DMA channel, it requests
data_width in Bytes. The DMA40 driver then swiftly converts it over to
the necessary register bit value. Unfortunately, for any subsequent
calculations we have to shift '1' by the bit pattern (1 << data_width)
times to make any sense of it.

This patch flips the semantics on its head and only converts the value
to its respective register bit pattern when writing to registers. This
way we can use the true data_width (in Bytes) value.

Cc: Dan Williams 
Cc: Per Forlin 
Cc: Rabin Vincent 
Acked-by: Vinod Koul 
Signed-off-by: Lee Jones 
Signed-off-by: Linus Walleij

dmaengine: ste_dma40_ll: Use the BIT macro to replace ugly '(1 << x)'s

2013-06-04T09:12:09+00:00

The aim is to make the code that little more readable.

Cc: Dan Williams 
Cc: Per Forlin 
Cc: Rabin Vincent 
Acked-by: Vinod Koul 
Signed-off-by: Lee Jones 
Signed-off-by: Linus Walleij

dmaengine: ste_dma40: Replace ST-E's home-brew DMA direction defs with generic ones

2013-06-04T09:12:08+00:00

STEDMA40_*_TO_* direction definitions are identical in all but name to
the pre-defined generic DMA_*_TO_* ones. Let's make things easy by not
duplicating such things.

Cc: Dan Williams 
Cc: Per Forlin 
Cc: Rabin Vincent 
Acked-by: Vinod Koul 
Signed-off-by: Lee Jones 
Signed-off-by: Linus Walleij

dmaengine: ste_dma40: Remove unnecessary call to d40_phy_cfg()

2013-05-23T19:13:19+00:00

The majority of configuration done in d40_phy_config() pertains
to physical channels. Move the call over to runtime config which
has different code paths for physical and logical channels already,
and make it an exclusive physical channel config function as the
name implies, and drop the is_log argument.

Since we moved the call to runtime_config() it only gets called
for device transfers, so encode the small snippet of configuration
pertaining to memcpy channels into the d40_config_memcpy()
function.

Acked-by: Vinod Koul 
Acked-by: Arnd Bergmann 
Signed-off-by: Lee Jones 
[rewrote the commit message]
Signed-off-by: Linus Walleij

dmaengine: ste_dma40: Separate Logical Global Interrupt Mask (GIM) unmasking

2013-05-23T19:13:16+00:00

During the initial setup of a logical channel, it is necessary to unmask
the GIM in order to receive generated terminal count and error interrupts.
We're separating out this required code so it will be possible to move
the remaining code in d40_phy_cfg(), which is mostly runtime configuration
into the runtime_config() routine.

Cc: Dan Williams 
Cc: Per Forlin 
Cc: Rabin Vincent 
Acked-by: Vinod Koul 
Acked-by: Arnd Bergmann 
Signed-off-by: Lee Jones 
Signed-off-by: Linus Walleij

dmaengine: ste_dma40: Amalgamate DMA source and destination channel numbers

2013-05-23T19:11:51+00:00

Devices which utilise DMA use the same device numbers for transmitting
and receiving. In this patch we encode the source and destination
information into one single attribute. We can subsequently exploit the
direction attribute to see which of the transfer directions are being
described. This also lessens the burden on platform data.

Cc: Dan Williams 
Cc: Per Forlin 
Cc: Rabin Vincent 
Acked-by: Vinod Koul 
Acked-by: Arnd Bergmann 
Signed-off-by: Lee Jones 
Signed-off-by: Linus Walleij

dmaengine: ste_dma40: minor cosmetic fixes

2013-01-14T09:51:01+00:00

This patch contains various non functional cosmetic fixes.

Acked-by: Linus Walleij 
Acked-by: Vinod Koul 
Signed-off-by: Fabio Baltieri

dmaengine: ste_dma40: use writel_relaxed for lcxa

2013-01-14T09:50:15+00:00

lcpa and lcla are written often and the cache_sync() overhead in writel
is costly, especially for wlan where every single network packet (in RX
mode) corresponds to a separate DMA transfer.

Signed-off-by: Per Forlin 
Reviewed-by: Narayanan Gopalakrishnan 
Reviewed-by: Rabin Vincent 
Acked-by: Linus Walleij 
Acked-by: Vinod Koul 
Signed-off-by: Fabio Baltieri