linux-toradex.git/drivers/edac/amd64_edac.c, branch v2.6.33.1

amd64_edac: Do not falsely trigger kerneloops

2010-02-11T19:32:14+00:00

An unfortunate "WARNING" in the message amd64_edac dumps when the system
doesn't support DRAM ECC or ECC checking is not enabled in the BIOS
used to trigger kerneloops which qualified the message as an OOPS thus
misleading the users. See, e.g.

https://bugs.launchpad.net/ubuntu/+source/linux/+bug/422536
http://bugzilla.kernel.org/show_bug.cgi?id=15238

Downgrade the message level to KERN_NOTICE and fix the formulation.

Cc: stable@kernel.org # .32.x
Signed-off-by: Borislav Petkov 
Acked-by: Doug Thompson

amd64_edac: Ensure index stays within bounds in amd64_get_scrub_rate

2010-01-15T09:45:58+00:00

Add a missing iterator variable thus fixing the conditional of the
for-loop in amd64_get_scrub_rate().

Signed-off-by: Roel Kluin 
Signed-off-by: Borislav Petkov

amd64_edac: restrict PCI config space access

2009-12-24T10:07:08+00:00

Do not access F2x19[0,4] on K8 since they're undefined there.

Signed-off-by: Borislav Petkov

amd64_edac: fix forcing module load/unload

2009-12-24T10:07:08+00:00

Clear the override flag after force-loading the module.

Signed-off-by: Borislav Petkov

amd64_edac: make driver loading more robust

2009-12-24T10:07:07+00:00

Currently, the module does not initialize fully when the DIMMs aren't
ECC but remains still loaded. Propagate the error when no instance of
the driver is properly initialized and prevent further loading.

Reorganize and polish error handling in amd64_edac_init() while at it.

Signed-off-by: Borislav Petkov

amd64_edac: fix driver instance freeing

2009-12-24T10:07:07+00:00

Fix use-after-free errors by pushing all memory-freeing calls to the end
of amd64_remove_one_instance().

Reported-by: Darren Jenkins 
LKML-Reference: <1261370306.11354.52.camel@ICE-BOX>
Signed-off-by: Borislav Petkov

amd64_edac: fix K8 chip select reporting

2009-12-24T10:07:07+00:00

Fix the case when amd64_debug_display_dimm_sizes() reports only half the
amount of DRAM on it because it doesn't account for when the single DCT
operates in 128-bit mode and merges chip selects from different DIMMs.

Reported-by: Johannes Hirte 
LKML-Reference: <200912112202.48173.johannes.hirte@fem.tu-ilmenau.de>
Signed-off-by: Borislav Petkov

x86, msr: Add support for non-contiguous cpumasks

2009-12-11T18:59:21+00:00

The current rd/wrmsr_on_cpus helpers assume that the supplied
cpumasks are contiguous. However, there are machines out there
like some K8 multinode Opterons which have a non-contiguous core
enumeration on each node (e.g. cores 0,2 on node 0 instead of 0,1), see
http://www.gossamer-threads.com/lists/linux/kernel/1160268.

This patch fixes out-of-bounds writes (see URL above) by adding per-CPU
msr structs which are used on the respective cores.

Additionally, two helpers, msrs_{alloc,free}, are provided for use by
the callers of the MSR accessors.

Cc: H. Peter Anvin 
Cc: Mauro Carvalho Chehab 
Cc: Aristeu Rozanski 
Cc: Randy Dunlap 
Cc: Doug Thompson 
Signed-off-by: Borislav Petkov 
LKML-Reference: <20091211171440.GD31998@aftab>
Signed-off-by: H. Peter Anvin

amd64_edac: fix use-uninitialised bug

2009-12-08T12:38:13+00:00

drivers/edac/amd64_edac.c: In function 'amd64_edac_init':
drivers/edac/amd64_edac.c:2840: warning: 'ret' may be used uninitialized in this function

Cc: Doug Thompson 
Cc: Mauro Carvalho Chehab 
Signed-off-by: Andrew Morton 
Signed-off-by: Borislav Petkov

amd64_edac: correct sys address to chip select mapping

2009-12-08T12:38:12+00:00

The routine does the reverse mapping of the error address of a CECC back
to the node id, DRAM controller and chip select of the DIMM which caused
the error. We should lookup the channel using the syndromes _only_ when
the DCTs are ganged so fix that.

Also, add an early exit when there's an error while scanning for the
csrow thus decreasing indentation levels for better readability.

Finally, fixup comments.

Signed-off-by: Borislav Petkov