linux-toradex.git/drivers/edac/amd64_edac.c, branch v4.10

EDAC, amd64: Fix improper return value

2016-12-04T09:51:42+00:00

When the call to zalloc_cpumask_var() fails, returning "false" seems
improper. The real value of macro "false" is 0, and 0 means no error.
Return -ENOMEM instead.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=189071

Signed-off-by: Pan Bian 
Cc: linux-edac 
Link: http://lkml.kernel.org/r/1480831638-5361-1-git-send-email-bianpan201604@163.com
Signed-off-by: Borislav Petkov

EDAC, amd64: Improve amd64-specific printing macros

2016-12-01T10:35:07+00:00

Prefix the warn and error macros with the respective string so that
callers don't have to say "Error" or "Warning". We save us string length
this way in the actual calls.

While at it, shorten the calls in reserve_mc_sibling_devs().

Signed-off-by: Borislav Petkov 
Cc: Dan Carpenter 
Cc: Yazen Ghannam

EDAC, amd64: Autoload amd64_edac_mod on Fam17h systems

2016-11-29T17:05:49+00:00

Add Fam17h to the list of families to autoload amd64_edac_mod.

Signed-off-by: Yazen Ghannam 
Cc: Aravind Gopalakrishnan 
Cc: linux-edac 
Cc: x86-ml 
Link: http://lkml.kernel.org/r/1479423463-8536-18-git-send-email-Yazen.Ghannam@amd.com
Signed-off-by: Borislav Petkov

EDAC, amd64: Define and register UMC error decode function

2016-11-29T17:05:48+00:00

How we need to decode UMC errors is different from how we decode bus
errors, so let's define a new function for this. We also need a way to
determine the UMC channel since we're not guaranteed that there is a
fixed relation between channel and MCA bank.

Signed-off-by: Yazen Ghannam 
Cc: Aravind Gopalakrishnan 
Cc: linux-edac 
Cc: x86-ml 
Link: http://lkml.kernel.org/r/1480359593-80369-1-git-send-email-Yazen.Ghannam@amd.com
[ Fold in decode_synd_reg(), simplify. ]
Signed-off-by: Borislav Petkov

EDAC, amd64: Determine EDAC capabilities on Fam17h systems

2016-11-29T17:05:47+00:00

We need to determine the EDAC capabilities from all UMCs on the node. We
should only check UMCs that are enabled and make sure they all agree.

Signed-off-by: Yazen Ghannam 
Cc: Aravind Gopalakrishnan 
Cc: linux-edac 
Cc: x86-ml 
Link: http://lkml.kernel.org/r/1479423463-8536-15-git-send-email-Yazen.Ghannam@amd.com
Signed-off-by: Borislav Petkov

EDAC, amd64: Determine EDAC MC capabilities on Fam17h

2016-11-29T17:04:54+00:00

The UMCs on Fam17h are independent memory controllers so we need to
read the capabilities from all UMCs and make sure they agree. Once
we determine what capabilities are available we should save them for
convenience.

Signed-off-by: Yazen Ghannam 
Cc: Aravind Gopalakrishnan 
Cc: linux-edac 
Cc: x86-ml 
Link: http://lkml.kernel.org/r/1480431116-94683-1-git-send-email-Yazen.Ghannam@amd.com
[ Simplify f17h_determine_edac_ctl_cap(), preinit edac_mode in init_csrows(). ]
Signed-off-by: Borislav Petkov

EDAC, amd64: Add Fam17h debug output

2016-11-29T16:16:09+00:00

Read a few more UMC registers and provide debug output in order to be as
similar as possible to older AMD systems.

Signed-off-by: Yazen Ghannam 
Cc: Aravind Gopalakrishnan 
Cc: linux-edac 
Cc: x86-ml 
Link: http://lkml.kernel.org/r/1480344621-14966-1-git-send-email-Yazen.Ghannam@amd.com
[ Remove unneeded K8 check and comments, fixup others. ]
Signed-off-by: Borislav Petkov

EDAC, amd64: Add Fam17h scrubber support

2016-11-28T16:50:12+00:00

Fam17h has new register offsets and fields for setting up the DRAM
scrubber so add support for this.

Signed-off-by: Yazen Ghannam 
Cc: Aravind Gopalakrishnan 
Cc: linux-edac 
Cc: x86-ml 
Link: http://lkml.kernel.org/r/1479423463-8536-17-git-send-email-Yazen.Ghannam@amd.com
Signed-off-by: Borislav Petkov

EDAC, amd64: Read MC registers on AMD Fam17h

2016-11-28T16:50:11+00:00

Fam17h has a different set of registers and bitfields. Most of these
registers are read through SMN (System Management Network) rather
than PCI config space. Also, the derivation of various values is now
different.

Update amd64_edac to read the appropriate registers and extract the
correct values for Fam17h.

Signed-off-by: Yazen Ghannam 
Cc: Aravind Gopalakrishnan 
Cc: linux-edac 
Cc: x86-ml 
Link: http://lkml.kernel.org/r/1479423463-8536-12-git-send-email-Yazen.Ghannam@amd.com
[ Save us the indentation level in read_mc_regs(), add defines ]
Signed-off-by: Borislav Petkov

EDAC, amd64: Reserve correct PCI devices on AMD Fam17h

2016-11-28T16:49:40+00:00

Fam17h needs PCI device functions 0 and 6 instead of 1 and 2 as on older
systems. Update struct amd64_pvt to hold the new functions and reserve
them if on Fam17h.

Also, allocate an array of UMC structs within our newly allocated PVT
struct.

Signed-off-by: Yazen Ghannam 
Cc: Aravind Gopalakrishnan 
Cc: linux-edac 
Cc: x86-ml 
Link: http://lkml.kernel.org/r/1479423463-8536-11-git-send-email-Yazen.Ghannam@amd.com
[ init_one_instance() error handling, shorten lines, unbreak >80 cols lines. ]
Signed-off-by: Borislav Petkov