linux-toradex.git/drivers/edac/e752x_edac.c, branch v4.1.16

e752x_edac: Drop pvt->bridge_ck

2014-02-25T09:01:30+00:00

pvt->bridge_ck always points to the same device as pvt->dev_d0f1, so
get rid of the former and only use the latter.

Signed-off-by: Jean Delvare 
Tested-by: Aristeu Rozanski 
Link: http://lkml.kernel.org/r/20140224151544.16ba28a0@endymion.delvare
Cc: Mark Gross 
Cc: Doug Thompson 
Signed-off-by: Borislav Petkov

e752x_edac: Simplify call to pci_get_device()

2014-02-03T18:03:35+00:00

The last parameter, pvt->bridge_ck, is always NULL as far as I can
see, so just use that.

Signed-off-by: Jean Delvare 
Acked-by: Aristeu Rozanski 
Link: http://lkml.kernel.org/r/20140130091101.22f2b550@endymion.delvare
Cc: Mark Gross 
Cc: Doug Thompson 
Signed-off-by: Borislav Petkov

e752x_edac: Fix pci_dev usage count

2013-12-21T12:26:57+00:00

In case the device 0, function 1 is not found using pci_get_device(),
pci_scan_single_device() will be used but, differently than
pci_get_device(), it allocates a pci_dev but doesn't does bump the usage
count on the pci_dev and after few module removals and loads the pci_dev
will be freed.

Signed-off-by: Aristeu Rozanski 
Reviewed-by: mark gross 
Link: http://lkml.kernel.org/r/20131205153755.GL4545@redhat.com
Signed-off-by: Borislav Petkov

EDAC: Remove DEFINE_PCI_DEVICE_TABLE macro

2013-12-06T09:23:41+00:00

Currently, there is no other bus that has something like this macro for
their device ids. Thus, DEFINE_PCI_DEVICE_TABLE macro should be removed.

Signed-off-by: Jingoo Han 
Link: http://lkml.kernel.org/r/001c01ceefb3$5724d860$056e8920$%han@samsung.com
[ Boris: swap commit message with better one. ]
Signed-off-by: Borislav Petkov

Drivers: edac: remove __dev* attributes.

2013-01-03T23:57:03+00:00

CONFIG_HOTPLUG is going away as an option.  As a result, the __dev*
markings need to be removed.

This change removes the use of __devinit, __devexit_p, and __devexit
from these drivers.

Based on patches originally written by Bill Pemberton, but redone by me
in order to handle some of the coding style issues better, by hand.

Cc: Bill Pemberton 
Cc: Doug Thompson 
Cc: Borislav Petkov 
Cc: Mark Gross 
Cc: Jason Uhlenkott 
Cc: Mauro Carvalho Chehab 
Cc: Tim Small 
Cc: Ranganathan Desikan 
Cc: "Arvind R." 
Cc: Ralf Baechle 
Cc: David Daney 
Cc: Egor Martovetsky 
Cc: Olof Johansson 
Cc: Chris Metcalf 
Signed-off-by: Greg Kroah-Hartman

edac: edac_mc_handle_error(): add an error_count parameter

2012-06-12T15:15:47+00:00

In order to avoid loosing error events, it is desirable to group
error events together and generate a single trace for several identical
errors.

The trace API already allows reporting multiple errors. Change the
handle_error function to also allow that.

The changes at the drivers were made by this small script:

	$file .=$_ while (<>);
	$file =~ s/(edac_mc_handle_error)\s*\(([^\,]+)\,([^\,]+)\,/$1($2,$3, 1,/g;
	print $file;

Signed-off-by: Mauro Carvalho Chehab

edac: remove arch-specific parameter for the error handler

2012-06-11T16:23:52+00:00

Remove the arch-dependent parameter, as it were not used,
as the MCE tracepoint weren't implemented. It probably doesn't
make sense to have an MCE-specific tracepoint, as this will
cost more bytes at the tracepoint, and tracepoint is not free.

The changes at the EDAC drivers were done by this small perl script:

	$file .=$_ while (<>);
	$file =~ s/(edac_mc_handle_error)\s*\(([^\;]+)\,([^\,\)]+)\s*\)/$1($2)/g;
	print $file;

Signed-off-by: Mauro Carvalho Chehab

edac: Convert debugfX to edac_dbg(X,

2012-06-11T16:23:49+00:00

Use a more common debugging style.

Remove __FILE__ uses, add missing newlines,
coalesce formats and align arguments.

Signed-off-by: Joe Perches 
Signed-off-by: Mauro Carvalho Chehab

edac: Don't add func or FILE for debugf[0-9] msgs

2012-06-11T16:23:47+00:00

The debug macro already adds that. Most of the work here was
made by this small script:

$f .=$_ while (<>);

$f =~ s/(debugf[0-9]\s*\(\s*)__FILE__\s*": /\1"/g;
$f =~ s/(debugf[0-9]\s*\(\s*)__FILE__\s*/\1/g;
$f =~ s/(debugf[0-9]\s*\(\s*)__FILE__\s*"MC: /\1"/g;

$f =~ s/(debugf[0-9]\s*\(\")\%s[\:\,\(\)]*\s*([^\"]*\s*[^\)]+)__func__\s*\,\s*/\1\2/g;
$f =~ s/(debugf[0-9]\s*\(\")\%s[\:\,\(\)]*\s*([^\"]*\s*[^\)]+),\s*__func__\s*\)/\1\2)/g;
$f =~ s/(debugf[0-9]\s*\(\"MC\:\s*)\%s[\:\,\(\)]*\s*([^\"]*\s*[^\)]+)__func__\s*\,\s*/\1\2/g;
$f =~ s/(debugf[0-9]\s*\(\"MC\:\s*)\%s[\:\,\(\)]*\s*([^\"]*\s*[^\)]+),\s*__func__\s*\)/\1\2)/g;

$f =~ s/\"MC\: \\n\"/"MC:\\n"/g;

print $f;

After running the script, manual cleanups were done to fix it the remaining
places.

While here, removed the __LINE__ on most places, as it doesn't actually give
useful info on most places.

Signed-off-by: Mauro Carvalho Chehab

edac: change the mem allocation scheme to make Documentation/kobject.txt happy

2012-06-11T16:23:45+00:00

Kernel kobjects have rigid rules: each container object should be
dynamically allocated, and can't be allocated into a single kmalloc.

EDAC never obeyed this rule: it has a single malloc function that
allocates all needed data into a single kzalloc.

As this is not accepted anymore, change the allocation schema of the
EDAC *_info structs to enforce this Kernel standard.

Acked-by: Chris Metcalf 
Cc: Aristeu Rozanski 
Cc: Doug Thompson 
Cc: Greg K H 
Cc: Borislav Petkov 
Cc: Mark Gross 
Cc: Tim Small 
Cc: Ranganathan Desikan 
Cc: "Arvind R." 
Cc: Olof Johansson 
Cc: Egor Martovetsky 
Cc: Michal Marek 
Cc: Jiri Kosina 
Cc: Dmitry Eremin-Solenikov 
Cc: Benjamin Herrenschmidt 
Cc: Hitoshi Mitake 
Cc: Andrew Morton 
Cc: Shaohui Xie 
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Mauro Carvalho Chehab