linux-toradex.git/drivers/edac/i5000_edac.c, branch v5.0-rc6

EDAC, i5000: Remove set but not used local variables

2018-12-11T13:53:49+00:00

Remove unused local variables as reported by gcc's -Wunused-but-set-variable option.

 [ bp: simplify commit message. ]

Signed-off-by: YueHaibing 
Signed-off-by: Borislav Petkov 
Cc: Mauro Carvalho Chehab 
Cc: linux-edac 
Link: https://lkml.kernel.org/r/20181211095207.25936-1-yuehaibing@huawei.com

EDAC: Fix indentation issues in several EDAC drivers

2018-11-10T15:56:16+00:00

Replace spaces with tabs and insert missing indentation.

 [ bp: Rewrite commit message. ]

Signed-off-by: Colin Ian King 
Signed-off-by: Borislav Petkov 
CC: "Arvind R." 
CC: Mark Gross 
CC: Mauro Carvalho Chehab 
CC: Ranganathan Desikan 
CC: kernel-janitors@vger.kernel.org
CC: linux-edac 
Link: http://lkml.kernel.org/r/20181109133757.21471-1-colin.king@canonical.com

EDAC: Get rid of mci->mod_ver

2017-07-17T11:42:48+00:00

It is a write-only variable so get rid of it.

Signed-off-by: Borislav Petkov 
Acked-by: Robert Richter 
Acked-by: Michal Simek 
Acked-by: Thor Thayer 
Acked-by: Tony Luck 
Cc: Mark Gross 
Cc: Tim Small 
Cc: Ranganathan Desikan 
Cc: "Arvind R." 
Cc: Jason Baron 
Cc: "Sören Brinkmann" 
Cc: Ralf Baechle 
Cc: David Daney 
Cc: Loc Ho 
Cc: linux-edac@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-mips@linux-mips.org

EDAC, i5000, i5400: Fix definition of NRECMEMB register

2017-06-29T08:33:13+00:00

In the i5000 and i5400 drivers, the NRECMEMB register is defined as a
16-bit value, which results in wrong shifts in the code, as reported by
sparse.

In the datasheets ([1], section 3.9.22.20 and [2], section 3.9.22.21),
this register is a 32-bit register. A u32 value for the register fixes
the wrong shifts warnings and matches the datasheet.

Also fix the mask to access to the CAS bits [27:16] in the i5000 driver.

[1]: https://www.intel.com/content/dam/doc/datasheet/5000p-5000v-5000z-chipset-memory-controller-hub-datasheet.pdf
[2]: https://www.intel.se/content/dam/doc/datasheet/5400-chipset-memory-controller-hub-datasheet.pdf

Signed-off-by: Jérémy Lefaure 
Cc: linux-edac 
Link: http://lkml.kernel.org/r/20170629005729.8478-1-jeremy.lefaure@lse.epita.fr
Signed-off-by: Borislav Petkov

EDAC, i5000, i5400: Fix use of MTR_DRAM_WIDTH macro

2017-03-09T08:25:29+00:00

The MTR_DRAM_WIDTH macro returns the data width. It is sometimes used
as if it returned a boolean true if the width if 8. Fix the tests where
MTR_DRAM_WIDTH is misused.

Signed-off-by: Jérémy Lefaure 
Cc: linux-edac 
Link: http://lkml.kernel.org/r/20170309011809.8340-1-jeremy.lefaure@lse.epita.fr
Signed-off-by: Borislav Petkov

edac: rename edac_core.h to edac_mc.h

2016-12-15T10:54:51+00:00

Now, all left at edac_core.h are at drivers/edac/edac_mc.c,
so rename it to edac_mc.h.

Signed-off-by: Mauro Carvalho Chehab

EDAC: Remove DEFINE_PCI_DEVICE_TABLE macro

2013-12-06T09:23:41+00:00

Currently, there is no other bus that has something like this macro for
their device ids. Thus, DEFINE_PCI_DEVICE_TABLE macro should be removed.

Signed-off-by: Jingoo Han 
Link: http://lkml.kernel.org/r/001c01ceefb3$5724d860$056e8920$%han@samsung.com
[ Boris: swap commit message with better one. ]
Signed-off-by: Borislav Petkov

Drivers: edac: remove __dev* attributes.

2013-01-03T23:57:03+00:00

CONFIG_HOTPLUG is going away as an option.  As a result, the __dev*
markings need to be removed.

This change removes the use of __devinit, __devexit_p, and __devexit
from these drivers.

Based on patches originally written by Bill Pemberton, but redone by me
in order to handle some of the coding style issues better, by hand.

Cc: Bill Pemberton 
Cc: Doug Thompson 
Cc: Borislav Petkov 
Cc: Mark Gross 
Cc: Jason Uhlenkott 
Cc: Mauro Carvalho Chehab 
Cc: Tim Small 
Cc: Ranganathan Desikan 
Cc: "Arvind R." 
Cc: Ralf Baechle 
Cc: David Daney 
Cc: Egor Martovetsky 
Cc: Olof Johansson 
Cc: Chris Metcalf 
Signed-off-by: Greg Kroah-Hartman

i5000: Fix the memory size calculation with 2R memories

2012-09-25T10:38:19+00:00

When 2R memories are found, the memory size should be multiplied
by two, otherwise, it will report half of the memory size:

       +-----------------------------------------------+
       |                      mc0                      |
       |        branch0        |        branch1        |
       | channel0  | channel1  | channel0  | channel1  |
-------+-----------------------------------------------+
slot3: |     0 MB  |     0 MB  |     0 MB  |     0 MB  |
slot2: |     0 MB  |     0 MB  |     0 MB  |     0 MB  |
-------+-----------------------------------------------+
slot1: |     0 MB  |     0 MB  |     0 MB  |     0 MB  |
slot0: |  1024 MB  |  1024 MB  |  1024 MB  |  1024 MB  |
-------+-----------------------------------------------+

(the above machine have 4 x 2GB 2R memories)

Signed-off-by: Mauro Carvalho Chehab

edac i5000, i5400: fix pointer math in i5000_get_mc_regs()

2012-06-27T12:08:40+00:00

"pvt->ambase" is a u64 datatype.  The intent here is to fill the first
half in the first call to pci_read_config_dword() and the other half in
the second.  Unfortunately the pointer math is wrong so we set the wrong
data.

Signed-off-by: Dan Carpenter 
Signed-off-by: Mauro Carvalho Chehab