linux-toradex.git/drivers/edac/i5000_edac.c, branch v7.0-rc2

EDAC/i5000: Fix snprintf() size calculation in calculate_dimm_size()

2025-12-17T17:59:17+00:00

The snprintf() can't really overflow because we're writing a max of 42
bytes to a PAGE_SIZE buffer.  But the limit calculation doesn't take
the first 11 bytes that we wrote into consideration so the limit is
not correct.  Just fix it for correctness even though it doesn't
affect runtime.

Fixes: 64e1fdaf55d6 ("i5000_edac: Fix the logic that retrieves memory information")
Signed-off-by: Dan Carpenter 
Signed-off-by: Tony Luck 
Reviewed-by: Qiuxu Zhuo 
Link: https://patch.msgid.link/07cd652c51e77aad5a8350e1a7cd9407e5bbe373.1765290801.git.dan.carpenter@linaro.org

EDAC: Fix typos in comments

2024-12-15T21:17:34+00:00

Fix the following typos:

'Alocate' ==> 'Allocate',
'specifed' ==> 'specified',
'Technlogy' ==> 'Technology',
'Brnach' ==> 'Branch',
'branchs' ==> 'branches'.

Signed-off-by: Yan Zhen 
Signed-off-by: Borislav Petkov (AMD) 
Link: https://lore.kernel.org/r/20240930074023.618110-1-yanzhen@vivo.com

EDAC: Sanitize MODULE_AUTHOR strings

2023-03-28T13:43:30+00:00

Fixup the remaining MODULE_AUTHOR strings to not contain newlines.
Shorten and unbreak others.

No functional changes.

Signed-off-by: Borislav Petkov (AMD) 
Link: https://lore.kernel.org/r/20230328134309.23159-1-bp@alien8.de

EDAC: Do not issue useless debug statements in the polling routine

2020-10-26T11:59:56+00:00

They have been spreading around the subsystem by example so remove them
all.

Reported-by: Raymond Bennett 
Suggested-by: Jason Baron 
Signed-off-by: Borislav Petkov

EDAC: Replace EDAC_DIMM_PTR() macro with edac_get_dimm() function

2019-11-09T09:32:32+00:00

The EDAC_DIMM_PTR() macro takes 3 arguments from struct mem_ctl_info.
Clean up this interface to only pass the mci struct and replace this
macro with a new function edac_get_dimm().

Also introduce an edac_get_dimm_by_index() function for later use.
This allows it to get a DIMM pointer only by a given index. This can
be useful if the DIMM's position within the layers of the memory
controller or the exact size of the layers are unknown.

Small style changes made for some hunks after applying the semantic
patch.

Semantic patch used:

@@ expression mci, a, b,c; @@

-EDAC_DIMM_PTR(mci->layers, mci->dimms, mci->n_layers, a, b, c)
+edac_get_dimm(mci, a, b, c)

 [ bp: Touchups. ]

Signed-off-by: Robert Richter 
Signed-off-by: Borislav Petkov 
Reviewed-by: Mauro Carvalho Chehab 
Cc: "linux-edac@vger.kernel.org" 
Cc: James Morse 
Cc: Jason Baron 
Cc: Qiuxu Zhuo 
Cc: Tero Kristo 
Cc: Tony Luck 
Link: https://lkml.kernel.org/r/20191106093239.25517-2-rrichter@marvell.com

EDAC, i5000: Remove set but not used local variables

2018-12-11T13:53:49+00:00

Remove unused local variables as reported by gcc's -Wunused-but-set-variable option.

 [ bp: simplify commit message. ]

Signed-off-by: YueHaibing 
Signed-off-by: Borislav Petkov 
Cc: Mauro Carvalho Chehab 
Cc: linux-edac 
Link: https://lkml.kernel.org/r/20181211095207.25936-1-yuehaibing@huawei.com

EDAC: Fix indentation issues in several EDAC drivers

2018-11-10T15:56:16+00:00

Replace spaces with tabs and insert missing indentation.

 [ bp: Rewrite commit message. ]

Signed-off-by: Colin Ian King 
Signed-off-by: Borislav Petkov 
CC: "Arvind R." 
CC: Mark Gross 
CC: Mauro Carvalho Chehab 
CC: Ranganathan Desikan 
CC: kernel-janitors@vger.kernel.org
CC: linux-edac 
Link: http://lkml.kernel.org/r/20181109133757.21471-1-colin.king@canonical.com

EDAC: Get rid of mci->mod_ver

2017-07-17T11:42:48+00:00

It is a write-only variable so get rid of it.

Signed-off-by: Borislav Petkov 
Acked-by: Robert Richter 
Acked-by: Michal Simek 
Acked-by: Thor Thayer 
Acked-by: Tony Luck 
Cc: Mark Gross 
Cc: Tim Small 
Cc: Ranganathan Desikan 
Cc: "Arvind R." 
Cc: Jason Baron 
Cc: "Sören Brinkmann" 
Cc: Ralf Baechle 
Cc: David Daney 
Cc: Loc Ho 
Cc: linux-edac@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-mips@linux-mips.org

EDAC, i5000, i5400: Fix definition of NRECMEMB register

2017-06-29T08:33:13+00:00

In the i5000 and i5400 drivers, the NRECMEMB register is defined as a
16-bit value, which results in wrong shifts in the code, as reported by
sparse.

In the datasheets ([1], section 3.9.22.20 and [2], section 3.9.22.21),
this register is a 32-bit register. A u32 value for the register fixes
the wrong shifts warnings and matches the datasheet.

Also fix the mask to access to the CAS bits [27:16] in the i5000 driver.

[1]: https://www.intel.com/content/dam/doc/datasheet/5000p-5000v-5000z-chipset-memory-controller-hub-datasheet.pdf
[2]: https://www.intel.se/content/dam/doc/datasheet/5400-chipset-memory-controller-hub-datasheet.pdf

Signed-off-by: Jérémy Lefaure 
Cc: linux-edac 
Link: http://lkml.kernel.org/r/20170629005729.8478-1-jeremy.lefaure@lse.epita.fr
Signed-off-by: Borislav Petkov

EDAC, i5000, i5400: Fix use of MTR_DRAM_WIDTH macro

2017-03-09T08:25:29+00:00

The MTR_DRAM_WIDTH macro returns the data width. It is sometimes used
as if it returned a boolean true if the width if 8. Fix the tests where
MTR_DRAM_WIDTH is misused.

Signed-off-by: Jérémy Lefaure 
Cc: linux-edac 
Link: http://lkml.kernel.org/r/20170309011809.8340-1-jeremy.lefaure@lse.epita.fr
Signed-off-by: Borislav Petkov