linux-toradex.git/drivers/edac/i7core_edac.c, branch v3.2.55

edac: avoid mce decoding crash after edac driver unloaded

2012-07-04T04:44:06+00:00

commit e35fca4791fcdd43dc1fd769797df40c562ab491 upstream.

Some edac drivers register themselves as mce decoders via
notifier_chain. But in current notifier_chain implementation logic,
it doesn't accept same notifier registered twice. If so, it will be
wrong when adding/removing the element from the list. For example,
on one SandyBridge platform, remove module sb_edac and then trigger
one error, it will hit oops because it has no mce decoder registered
but related notifier_chain still points to an invalid callback
function. Here is an example:

Call Trace:
 [] atomic_notifier_call_chain+0x1a/0x20
 [] mce_log+0x46/0x180
 [] apei_mce_report_mem_error+0x4a/0x60
 [] ghes_do_proc+0x192/0x210
 [] ghes_proc+0x46/0x70
 [] ghes_notify_sci+0x48/0x80
 [] notifier_call_chain+0x55/0x80
 [] __blocking_notifier_call_chain+0x5a/0x80
 [] ? acpi_os_wait_events_complete+0x23/0x23
 [] blocking_notifier_call_chain+0x16/0x20
 [] acpi_hed_notify+0x19/0x1b
 [] acpi_device_notify+0x19/0x1b
 [] acpi_ev_notify_dispatch+0x67/0x7f
 [] acpi_os_execute_deferred+0x29/0x36
 [] process_one_work+0x132/0x450
 [] worker_thread+0x17b/0x3c0
 [] ? manage_workers+0x120/0x120
 [] kthread+0x9e/0xb0
 [] kernel_thread_helper+0x4/0x10
 [] ? kthread_freezable_should_stop+0x70/0x70
 [] ? gs_change+0x13/0x13
Code: f3 49 89 d4 45 85 ed 4d 89 c6 48 8b 0f 74 48 48 85 c9 75 17 eb 41
0f 1f 80 00 00 00 00 41 83 ed 01 4c 89 f9 74 22 4d 85 ff 74 1d <4c> 8b
79 08 4c 89 e2 48 89 de 48 89 cf ff 11 4d 85 f6 74 04 41
RIP  [] notifier_call_chain+0x46/0x80
 RSP 
CR2: ffffffffa01af838
---[ end trace 0100930068e73e6f ]---
BUG: unable to handle kernel paging request at fffffffffffffff8
IP: [] kthread_data+0x10/0x20
PGD 1a0d067 PUD 1a0e067 PMD 0
Oops: 0000 [#2] SMP

Only i7core_edac and sb_edac have such issues because they have more
than one memory controller which means they have to register mce
decoder many times.

Signed-off-by: Chen Gong 
Signed-off-by: Mauro Carvalho Chehab 
[bwh: Backported to 3.2: drivers call atomic_notifier_chain_{,un}register()
 directly]
Signed-off-by: Ben Hutchings

i7core_edac: Initialize memory name with cpu, channel, bank

2011-11-01T12:01:52+00:00

Signed-off-by: Mauro Carvalho Chehab

i7core_edac: Fix compilation on 32 bits arch

2011-11-01T12:01:51+00:00

on i386:
	ERROR: "__udivdi3" [drivers/edac/i7core_edac.ko] undefined!\

In both get_sdram_scrub_rate() and set_sdram_scrub_rate()

Reported-by: Randy Dunlap 
Signed-off-by: Mauro Carvalho Chehab

i7core_edac: scrubbing fixups

2011-11-01T12:01:51+00:00

Get a more reliable DCLK value from DMI, name the SCRUBINTERVAL mask
and guard against potential overflow in the scrub rate computations.

Signed-off-by: Nils Carlson

i7core_edac: return -ENODEV if no MC is found

2011-11-01T12:01:49+00:00

Nehalem-EX uses a different memory controller. However, as the
memory controller is not visible on some Nehalem/Nehalem-EP, we
need to indirectly probe via a X58 PCI device. The same devices
are found on (some) Nehalem-EX. So, on those machines, the
probe routine needs to return -ENODEV, as the actual Memory
Controller registers won't be detected.

Signed-off-by: Mauro Carvalho Chehab

i7core_edac: use edac's own way to print errors

2011-11-01T12:01:48+00:00

Signed-off-by: Mauro Carvalho Chehab

i7core_edac: Drop the edac_mce facility

2011-11-01T12:01:24+00:00

Remove edac_mce pieces and use the normal MCE decoder notifier chain by
retaining the same functionality with considerably less code.

Signed-off-by: Borislav Petkov 
Signed-off-by: Mauro Carvalho Chehab

EDAC i7core: Use mce socketid for better compatibility

2011-10-31T17:10:05+00:00

mce->socketid and cpu_data(mce->cpu).phys_proc_id are the same,
compare with mce_setup (in mce.c):
	m->cpu = m->extcpu = smp_processor_id();
        ...
	m->socketid = cpu_data(m->extcpu).phys_proc_id;

This makes it easier for example for XEN patches to hook into
the MCE subsystem.
Compile tested on x86_64.

Signed-off-by: Thomas Renninger 
CC: JBeulich@novell.com
CC: linux-edac@vger.kernel.org
CC: Mauro Carvalho Chehab

i7core_edac: Don't enable memory scrubbing for Xeon 35xx

2011-10-31T17:10:05+00:00

Xeon 35xx doesn't mention memory scrub. It seems that only Xeon 55xx
and above supports it.

Signed-off-by: Mauro Carvalho Chehab

i7core_edac: Add scrubbing support

2011-10-31T17:10:05+00:00

Add scrubbing support to i7core_edac, tested on intel Xeon L5638.

Signed-off-by: Samuel Gabrielsson 
Signed-off-by: Mauro Carvalho Chehab