linux-toradex.git/drivers/edac/i7core_edac.c, branch v6.3-rc5

Merge tag 'edac_updates_for_v5.10' of git://git.kernel.org/pub/scm/linux/kernel/git/ras/ras

2020-10-12T17:12:26+00:00

Pull EDAC updates from Borislav Petkov:

 - Add Amazon's Annapurna Labs memory controller EDAC driver (Talel
   Shenhar)

 - New AMD CPUs support (Yazen Ghannam)

 - The usual misc fixes and cleanups all over the subsystem

* tag 'edac_updates_for_v5.10' of git://git.kernel.org/pub/scm/linux/kernel/git/ras/ras:
  EDAC/amd64: Set proper family type for Family 19h Models 20h-2Fh
  EDAC/mc_sysfs: Add missing newlines when printing {max,dimm}_location
  EDAC/aspeed: Use module_platform_driver() to simplify
  EDAC, sb_edac: Simplify switch statement
  EDAC/ti: Fix handling of platform_get_irq() error
  EDAC/aspeed: Fix handling of platform_get_irq() error
  EDAC/i5100: Fix error handling order in i5100_init_one()
  EDAC/highbank: Handover Calxeda Highbank maintenance to Andre Przywara
  EDAC/socfpga: Transfer SoCFPGA EDAC maintainership
  EDAC/thunderx: Make symbol lmc_dfs_ents static
  EDAC/al-mc-edac: Add Amazon's Annapurna Labs Memory Controller driver
  dt-bindings: EDAC: Add Amazon's Annapurna Labs Memory Controller binding
  EDAC/mce_amd: Add new error descriptions for existing types
  EDAC: Replace HTTP links with HTTPS ones

EDAC/{i7core,sb,pnd2,skx}: Fix error event severity

2020-08-18T13:40:30+00:00

IA32_MCG_STATUS.RIPV indicates whether the return RIP value pushed onto
the stack as part of machine check delivery is valid or not.

Various drivers copied a code fragment that uses the RIPV bit to
determine the severity of the error as either HW_EVENT_ERR_UNCORRECTED
or HW_EVENT_ERR_FATAL, but this check is reversed (marking errors where
RIPV is set as "FATAL").

Reverse the tests so that the error is marked fatal when RIPV is not set.

Reported-by: Gabriele Paoloni 
Signed-off-by: Tony Luck 
Signed-off-by: Borislav Petkov 
Cc: 
Link: https://lkml.kernel.org/r/20200707194324.14884-1-tony.luck@intel.com

EDAC: Replace HTTP links with HTTPS ones

2020-08-17T07:31:19+00:00

Rationale:
Reduces attack surface on kernel devs opening the links for MITM
as HTTPS traffic is much harder to manipulate.

  Deterministic algorithm:
  For each file:
    If not .svg:
      For each line:
        If doesn't contain `\bxmlns\b`:
          For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
  	  If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
              If both the HTTP and HTTPS versions
              return 200 OK and serve the same content:
                Replace HTTP with HTTPS.

 [ bp: Merge all EDAC patches into a single one. ]

Signed-off-by: Alexander A. Klimov 
Signed-off-by: Borislav Petkov 
Acked-by: Tero Kristo  # ti_edac
Link: https://lkml.kernel.org/r/20200708113546.14135-1-grandmaster@al2klimov.de

x86/mce: Fix all mce notifiers to update the mce->kflags bitmask

2020-04-14T13:59:26+00:00

If the handler took any action to log or deal with the error, set a bit
in mce->kflags so that the default handler on the end of the machine
check chain can see what has been done.

Get rid of NOTIFY_STOP returns. Make the EDAC and dev-mcelog handlers
skip over errors already processed by CEC.

Signed-off-by: Tony Luck 
Signed-off-by: Borislav Petkov 
Tested-by: Tony Luck 
Link: https://lkml.kernel.org/r/20200214222720.13168-5-tony.luck@intel.com

EDAC: Replace EDAC_DIMM_PTR() macro with edac_get_dimm() function

2019-11-09T09:32:32+00:00

The EDAC_DIMM_PTR() macro takes 3 arguments from struct mem_ctl_info.
Clean up this interface to only pass the mci struct and replace this
macro with a new function edac_get_dimm().

Also introduce an edac_get_dimm_by_index() function for later use.
This allows it to get a DIMM pointer only by a given index. This can
be useful if the DIMM's position within the layers of the memory
controller or the exact size of the layers are unknown.

Small style changes made for some hunks after applying the semantic
patch.

Semantic patch used:

@@ expression mci, a, b,c; @@

-EDAC_DIMM_PTR(mci->layers, mci->dimms, mci->n_layers, a, b, c)
+edac_get_dimm(mci, a, b, c)

 [ bp: Touchups. ]

Signed-off-by: Robert Richter 
Signed-off-by: Borislav Petkov 
Reviewed-by: Mauro Carvalho Chehab 
Cc: "linux-edac@vger.kernel.org" 
Cc: James Morse 
Cc: Jason Baron 
Cc: Qiuxu Zhuo 
Cc: Tero Kristo 
Cc: Tony Luck 
Link: https://lkml.kernel.org/r/20191106093239.25517-2-rrichter@marvell.com

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 172

2019-05-30T18:26:39+00:00

Based on 1 normalized pattern(s):

  this file may be distributed under the terms of the gnu general
  public license version 2

extracted by the scancode license scanner the SPDX license identifier

  GPL-2.0-only

has been chosen to replace the boilerplate/reference in 9 file(s).

Signed-off-by: Thomas Gleixner 
Reviewed-by: Allison Randal 
Reviewed-by: Kate Stewart 
Reviewed-by: Richard Fontana 
Cc: linux-spdx@vger.kernel.org
Link: https://lkml.kernel.org/r/20190527070034.395589349@linutronix.de
Signed-off-by: Greg Kroah-Hartman

EDAC: Fix indentation issues in several EDAC drivers

2018-11-10T15:56:16+00:00

Replace spaces with tabs and insert missing indentation.

 [ bp: Rewrite commit message. ]

Signed-off-by: Colin Ian King 
Signed-off-by: Borislav Petkov 
CC: "Arvind R." 
CC: Mark Gross 
CC: Mauro Carvalho Chehab 
CC: Ranganathan Desikan 
CC: kernel-janitors@vger.kernel.org
CC: linux-edac 
Link: http://lkml.kernel.org/r/20181109133757.21471-1-colin.king@canonical.com

EDAC, {i7core,sb,skx}_edac: Fix uncorrected error counting

2018-09-29T08:58:16+00:00

The count of errors is picked up from bits 52:38 of the machine check
bank status register. But this is the count of *corrected* errors. If an
uncorrected error is being logged, the h/w sets this field to 0. Which
means that when edac_mc_handle_error() is called, the EDAC core will
carefully add zero to the appropriate uncorrected error counts.

Signed-off-by: Tony Luck 
[ Massage commit message. ]
Signed-off-by: Borislav Petkov 
Cc: stable@vger.kernel.org
Cc: Aristeu Rozanski 
Cc: Mauro Carvalho Chehab 
Cc: Qiuxu Zhuo 
Cc: linux-edac 
Link: http://lkml.kernel.org/r/20180928213934.19890-1-tony.luck@intel.com

EDAC, i7core: Remove set but not used variable pvt

2018-09-25T10:02:28+00:00

Remove the unused local variable pvt:

  drivers/edac/i7core_edac.c: In function 'i7core_mce_check_error':
  drivers/edac/i7core_edac.c:1818:21: warning: variable 'pvt' set but not used \
	  [-Wunused-but-set-variable]

Signed-off-by: YueHaibing 
Signed-off-by: Borislav Petkov 
Cc: Mauro Carvalho Chehab 
Cc: linux-edac 
Link: http://lkml.kernel.org/r/1537841043-108267-1-git-send-email-yuehaibing@huawei.com

EDAC: Correct DIMM capacity unit symbol

2018-09-22T16:18:57+00:00

The {i3200|i7core|sb|skx}_edac drivers show DIMM capacity using the
wrong unit symbol: 'Mb' - megabit. Fix them by replacing 'Mb' with
'MiB' - mebibyte.

[Tony: These are all "edac_dbg()" messages, so this won't break scripts
       that parse console logs.]

Signed-off-by: Qiuxu Zhuo 
Signed-off-by: Tony Luck 
Signed-off-by: Borislav Petkov 
Acked-by: Aristeu Rozanski 
Cc: Mauro Carvalho Chehab 
Cc: linux-edac@vger.kernel.org
Link: https://lkml.kernel.org/r/20180919003433.16475-1-tony.luck@intel.com