linux-toradex.git/drivers/edac, branch tegra-T30.ER5

amd64_edac: Fix interleaving check

2011-01-07T21:58:17+00:00

commit e726f3c368e7c1919a7166ec09c5705759f1a69d upstream.

When matching error address to the range contained by one memory node,
we're in valid range when node interleaving

1. is disabled, or
2. enabled and when the address bits we interleave on match the
interleave selector on this node (see the "Node Interleaving" section in
the BKDG for an enlightening example).

Thus, when we early-exit, we need to reverse the compound logic
statement properly.

Signed-off-by: Borislav Petkov 
Signed-off-by: Greg Kroah-Hartman

EDAC: Fix workqueue-related crashes

2011-01-07T21:58:17+00:00

commit bb31b3122c0dd07d2d958da17a50ad771ce79e2b upstream.

00740c58541b6087d78418cebca1fcb86dc6077d changed edac_core to
un-/register a workqueue item only if a lowlevel driver supplies a
polling routine. Normally, when we remove a polling low-level driver, we
go and cancel all the queued work. However, the workqueue unreg happens
based on the ->op_state setting, and edac_mc_del_mc() sets this to
OP_OFFLINE _before_ we cancel the work item, leading to NULL ptr oops on
the workqueue list.

Fix it by putting the unreg stuff in proper order.

Reported-and-tested-by: Tobias Karnat 
LKML-Reference: <1291201307.3029.21.camel@Tobias-Karnat>
Signed-off-by: Borislav Petkov 
Signed-off-by: Greg Kroah-Hartman

i7core_edac: fix panic in udimm sysfs attributes registration

2010-10-01T17:50:58+00:00

Array of udimm sysfs attributes was not ended with NULL marker, leading to
dereference of random memory.

  EDAC DEBUG: edac_create_mci_instance_attributes: edac_create_mci_instance_attributes() file udimm0
  EDAC DEBUG: edac_create_mci_instance_attributes: edac_create_mci_instance_attributes() file udimm1
  EDAC DEBUG: edac_create_mci_instance_attributes: edac_create_mci_instance_attributes() file udimm2
  BUG: unable to handle kernel NULL pointer dereference at 00000000000001a4
  IP: [] edac_create_mci_instance_attributes+0x148/0x1f1
  Pid: 1, comm: swapper Not tainted 2.6.36-rc3-nv+ #483 P6T SE/System Product Name
  RIP: 0010:[]  [] edac_create_mci_instance_attributes+0x148/0x1f1
  (...)
  Call Trace:
   [] edac_create_mci_instance_attributes+0x198/0x1f1
   [] edac_create_sysfs_mci_device+0xbb/0x2b2
   [] edac_mc_add_mc+0x46b/0x557
   [] i7core_probe+0xccf/0xec0
  RIP  [] edac_create_mci_instance_attributes+0x148/0x1f1
  ---[ end trace 20de320855b81d78 ]---
  Kernel panic - not syncing: Attempted to kill init!

Signed-off-by: Marcin Slusarz 
Cc: Mauro Carvalho Chehab 
Acked-by: Doug Thompson 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

amd64_edac: Fix driver module removal

2010-09-27T10:52:58+00:00

f4347553b30ec66530bfe63c84530afea3803396 removed the edac polling
mechanism in favor of using a notifier chain for conveying MCE
information to edac. However, the module removal path didn't test
whether the driver had setup the polling function workqueue at all and
the rmmod process was hanging in the kernel at try_to_del_timer_sync()
in the cancel_delayed_work() path, trying to cancel an uninitialized
work struct.

Fix that by adding a balancing check to the workqueue removal path.

Signed-off-by: Borislav Petkov

amd64_edac: Do not report error overflow as a separate error

2010-08-26T10:46:03+00:00

When the Overflow MCi_STATUS bit is set, EDAC reports the lost error
with a "no information available" message which often puzzles users
parsing the dmesg. This doesn't make much sense since this error has
been lost anyway so no need for reporting it separately. Thus, report
the overflow bit setting in the MCE dump instead. While at it, remove
reporting of MiscV and ErrorEnable (en) which are superfluous.

Now it looks like this:

[ 1501.650024] MC4_STATUS: Corrected error, other errors lost: yes, CPU context corrupt: no, CECC Error
[ 1501.666887] Northbridge Error, node 2

Signed-off-by: Borislav Petkov

MCE, AMD: Limit MCE decoding to current families for now

2010-08-24T16:06:54+00:00

Limit MCE error decoding to current and older families only (K8-F11h).

Signed-off-by: Borislav Petkov

Merge branch 'next-devicetree' of git://git.secretlab.ca/git/linux-2.6

2010-08-12T16:11:31+00:00

* 'next-devicetree' of git://git.secretlab.ca/git/linux-2.6:
  mmc_spi: Fix unterminated of_match_table
  of/sparc: fix build regression from of_device changes
  of/device: Replace struct of_device with struct platform_device

edac: mpc85xx: add support for new MPCxxx/Pxxxx EDAC controllers

2010-08-11T15:59:21+00:00

Simply add proper IDs into the device table.

Signed-off-by: Anton Vorontsov 
Cc: Scott Wood 
Cc: Peter Tyser 
Cc: Dave Jiang 
Cc: Doug Thompson 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

edac: i5400: improve handling of pci_enable_device() return value

2010-08-11T15:59:21+00:00

-EIO is not the only error code that pci_enable_device() may return, also
the set of errors can be enhanced in future.  We should compare return
code with zero, not with concrete error value.

Signed-off-by: Kulikov Vasiliy 
Acked-by: Mauro Carvalho Chehab 
Cc: Jeff Roberson 
Cc: Doug Thompson 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

edac: i5000: improve handling of pci_enable_device() return value

2010-08-11T15:59:21+00:00

-EIO is not the only error code that pci_enable_device() may return, also
the set of errors can be enhanced in future.  We should compare return
code with zero, not with concrete error value.

Signed-off-by: Kulikov Vasiliy 
Acked-by: Mauro Carvalho Chehab 
Cc: Jeff Roberson 
Cc: Doug Thompson 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds