linux-toradex.git/drivers/edac, branch v4.1.13

EDAC, sb_edac: Fix TAD presence check for sbridge_mci_bind_devs()

2015-11-09T22:33:38+00:00

commit 2900ea609616c2651dec65312beeb2a6e536bc50 upstream.

In commit

  7d375bffa524 ("sb_edac: Fix support for systems with two home agents per socket")

NUM_CHANNELS was changed to 8 and the channel space was renumerated to
handle EN, EP, and EX configurations.

The *_mci_bind_devs() functions - except for sbridge_mci_bind_devs() -
got a new device presence check in the form of saw_chan_mask. However,
sbridge_mci_bind_devs() still uses the NUM_CHANNELS for loop.

With the increase in NUM_CHANNELS, this loop fails at index 4 since
SB only has 4 TADs.  This results in the following error on SB machines:

  EDAC sbridge: Some needed devices are missing
  EDAC sbridge: Couldn't find mci handler
  EDAC sbridge: Couldn't find mci handle

This patch adapts the saw_chan_mask logic for sbridge_mci_bind_devs() as
well.

After this patch:

  EDAC MC0: Giving out device to module sbridge_edac.c controller Sandy Bridge Socket#0: DEV 0000:3f:0e.0 (POLLED)
  EDAC MC1: Giving out device to module sbridge_edac.c controller Sandy Bridge Socket#1: DEV 0000:7f:0e.0 (POLLED)

Signed-off-by: Seth Jennings 
Acked-by: Aristeu Rozanski 
Acked-by: Tony Luck 
Tested-by: Borislav Petkov 
Cc: Mauro Carvalho Chehab 
Cc: linux-edac 
Link: http://lkml.kernel.org/r/1438798561-10180-1-git-send-email-sjenning@redhat.com
Signed-off-by: Borislav Petkov 
Signed-off-by: Greg Kroah-Hartman

EDAC, ppc4xx: Access mci->csrows array elements properly

2015-09-13T16:07:40+00:00

commit 5c16179b550b9fd8114637a56b153c9768ea06a5 upstream.

The commit

  de3910eb79ac ("edac: change the mem allocation scheme to
		 make Documentation/kobject.txt happy")

changed the memory allocation for the csrows member. But ppc4xx_edac was
forgotten in the patch. Fix it.

Signed-off-by: Michael Walle 
Cc: linux-edac 
Cc: Mauro Carvalho Chehab 
Link: http://lkml.kernel.org/r/1437469253-8611-1-git-send-email-michael@walle.cc
Signed-off-by: Borislav Petkov 
Signed-off-by: Greg Kroah-Hartman

EDAC, octeon: Fix broken build due to model helper renames

2015-08-03T16:29:18+00:00

commit 75a15a7864c9e281c74a1670b10b69d1d7ff1c82 upstream.

Commit

  debe6a623d3c ("MIPS: OCTEON: Update octeon-model.h code for new SoCs.")

renamed some SoC model helper functions, but forgot to update the EDAC
drivers resulting in build failures. Fix that.

Signed-off-by: Aaro Koskinen 
Acked-by: David Daney 
Cc: Mauro Carvalho Chehab 
Cc: Ralf Baechle 
Cc: linux-edac 
Cc: linux-mips@linux-mips.org
Link: http://lkml.kernel.org/r/1435747132-10954-1-git-send-email-aaro.koskinen@nokia.com
Signed-off-by: Borislav Petkov 
Signed-off-by: Greg Kroah-Hartman

EDAC: Constify of_device_id array

2015-03-20T16:50:07+00:00

of_device_id is always used as const. See driver.of_match_table and open
firmware functions.

Signed-off-by: Fabian Frederick 
Cc: Greg Kroah-Hartman 
Cc: Doug Thompson 
Cc: Robert Richter 
Cc: Mauro Carvalho Chehab 
Cc: Johannes Thumshirn 
Cc: Michal Simek 
Cc: Sören Brinkmann 
Cc: linux-edac@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Link: http://lkml.kernel.org/r/1426535685-25996-10-git-send-email-fabf@skynet.be
Signed-off-by: Borislav Petkov

EDAC, i82443bxgx: Don't export static symbol

2015-03-11T19:39:15+00:00

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// 
@r@
type T;
identifier f;
@@

static T f (...) { ... }

@@
identifier r.f;
declarer name EXPORT_SYMBOL_GPL;
@@

-EXPORT_SYMBOL_GPL(f);
// 

Signed-off-by: Julia Lawall 
Cc: Doug Thompson 
Cc: Mauro Carvalho Chehab 
Cc: Tim Small 
Link: http://lkml.kernel.org/r/1426092997-30605-13-git-send-email-Julia.Lawall@lip6.fr
Signed-off-by: Borislav Petkov

EDAC, amd64_edac: Get rid of per-node driver instances

2015-02-23T12:16:01+00:00

... and do the proper thing using EDAC core facilities.

Cc: Daniel J Blueman 
Signed-off-by: Borislav Petkov

EDAC: Properly unwind on failure path in edac_init()

2015-02-23T12:13:07+00:00

edac_init() does not deallocate already allocated resources on failure
path.

Found by Linux Driver Verification project (linuxtesting.org).

 [ Boris: The unwind path functions have __exit annotation but are being
   used in an __init function, leading to section mismatches. Drop the
   section annotation and make them normal functions. ]

Signed-off-by: Alexey Khoroshilov 
Link: http://lkml.kernel.org/r/1423203162-26368-1-git-send-email-khoroshilov@ispras.ru
Signed-off-by: Borislav Petkov

EDAC: highbank: Use static attribute groups for sysfs entries

2015-02-23T12:12:22+00:00

... instead of manual device_create_file() and device_remove_file()
calls.

Signed-off-by: Takashi Iwai 
Link: http://lkml.kernel.org/r/1423046938-18111-9-git-send-email-tiwai@suse.de
Signed-off-by: Borislav Petkov

EDAC: octeon: Use static attribute groups for sysfs entries

2015-02-23T12:12:05+00:00

... instead of manual device_create_file() and device_remove_file()
calls.

Signed-off-by: Takashi Iwai 
Link: http://lkml.kernel.org/r/1423046938-18111-8-git-send-email-tiwai@suse.de
Signed-off-by: Borislav Petkov

EDAC: mpc85xx: Use static attribute groups for sysfs entries

2015-02-23T12:11:40+00:00

... instead of manual device_create_file() and device_remove_file()
calls.

Signed-off-by: Takashi Iwai 
Cc: Johannes Thumshirn 
Link: http://lkml.kernel.org/r/1423046938-18111-7-git-send-email-tiwai@suse.de
Signed-off-by: Borislav Petkov