linux-toradex.git/drivers/extcon/extcon-palmas.c, branch v4.9.100

extcon: palmas: Check the parent instance to prevent the NULL

2017-11-21T08:23:21+00:00

[ Upstream commit 9fe172b9be532acc23e35ba693700383ab775e66 ]

extcon-palmas must be child of palmas and expects parent's
drvdata to be valid. Check for non NULL parent drvdata and
fail if it is NULL. Not doing so will result in a NULL
pointer dereference later in the probe() parent drvdata
is NULL (e.g. misplaced extcon-palmas node in device tree).

Signed-off-by: Roger Quadros 
Signed-off-by: Chanwoo Choi 
Signed-off-by: Sasha Levin 
Signed-off-by: Greg Kroah-Hartman

extcon: Use the extcon_set_state_sync() instead of deprecated functions

2016-09-13T02:26:26+00:00

This patch alters the renamed extcon API to set the state of the external
connectors instead of deprecated extcon_set_cable_state_().

Because the patch[1] modifies the function name to maintain the function
naming pattern.
- extcon_set_cable_state_() -> extcon_set_state_sync()
- extcon_get_cable_state_() -> extcon_get_state()

[1] https://lkml.org/lkml/2016/8/4/729
- extcon: Rename the extcon_set/get_state() to maintain the function naming pattern

Signed-off-by: Chanwoo Choi 
Acked-by: Charles Keepax 
Acked-by: Roger Quadros

extcon: palmas: Fix boot up state of VBUS when using GPIO detection

2016-06-15T08:17:22+00:00

If USB cable is connected prior to boot, we don't get any interrupts
so we must manually check the VBUS state and report it during probe.
If we don't do it then USB controller will never know that peripheral
cable was connected till the user unplugs and replugs the cable.

Fixes: b7aad8e2685b ("extcon: palmas: Add the support for VBUS detection by using GPIO")
Cc: stable@vger.kernel.org
Signed-off-by: Roger Quadros 
Signed-off-by: Chanwoo Choi

extcon: palmas: Drop stray IRQF_EARLY_RESUME flag

2016-04-03T23:32:45+00:00

Palmas extcon IRQs are nested threaded and wired to the Palmas
interrupt controller. So, this flag is not required for nested
IRQs anymore, since commit 3c646f2c6aa9 ("genirq: Don't suspend
nested_thread irqs over system suspend") was merged. However, the
fix in commit ae64e42cc2b3 ("extcon: palmas: Drop IRQF_EARLY_RESUME
flag") missed a stray flag causing the following crash on resume on
BeagleBoard-X15 platform:

[   53.670141] Unhandled fault: imprecise external abort (0x1406) at 0x00000000
[..]
[   53.670141] [] (omap_set_gpio_triggering) from [] (omap_gpio_unmask_irq+0xc0/0xc4)
[   53.670141] [] (omap_gpio_unmask_irq) from [] (irq_enable+0x30/0x44)
[   53.670141] [] (irq_enable) from [] (__enable_irq+0x54/0x78)
[   53.670141] [] (__enable_irq) from [] (resume_irqs+0xe8/0x100)
[   53.670141] [] (resume_irqs) from [] (syscore_resume+0x94/0x298)
[   53.670141] [] (syscore_resume) from [] (suspend_devices_and_enter+0x790/0x9e4)
[   53.670141] [] (suspend_devices_and_enter) from [] (pm_suspend+0x640/0x75c)
[   53.670141] [] (pm_suspend) from [] (state_store+0x64/0xb8)
[   53.670141] [] (state_store) from [] (kernfs_fop_write+0xc0/0x1bc)
[   53.670141] [] (kernfs_fop_write) from [] (__vfs_write+0x1c/0xd8)
[   53.670141] [] (__vfs_write) from [] (vfs_write+0x90/0x16c)
[   53.670141] [] (vfs_write) from [] (SyS_write+0x44/0x9c)
[   53.670141] [] (SyS_write) from [] (ret_fast_syscall+0x0/0x1c)
[..]

Fixes: ae64e42cc2b3 ("extcon: palmas: Drop IRQF_EARLY_RESUME flag")
Cc: Grygorii Strashko 
Cc: MyungJoo Ham 
Cc: Chanwoo Choi 
Cc: Tony Lindgren 
Cc: Lee Jones 
Cc: Roger Quadros 

Reviewed-by: Grygorii Strashko 
Signed-off-by: Nishanth Menon 
Acked-by: Roger Quadros 
Signed-off-by: Chanwoo Choi

extcon: palmas: Drop IRQF_EARLY_RESUME flag

2016-02-29T02:07:34+00:00

Palams extcon IRQs are nested threaded and wired to the Palmas
inerrupt controller. So, this flag is not required for nested irqs
anymore, since commit 3c646f2c6aa9 ("genirq: Don't suspend
nested_thread irqs over system suspend") was merged.

Cc: MyungJoo Ham 
Cc: Chanwoo Choi 
Cc: Tony Lindgren 
Cc: Lee Jones 
Cc: Roger Quadros 
Cc: Nishanth Menon 
Signed-off-by: Grygorii Strashko 
Signed-off-by: Chanwoo Choi

extcon: palmas: Add the support for VBUS detection by using GPIO

2016-02-05T05:15:31+00:00

This patch support for VBUS detection by using GPIO pin.

Signed-off-by: Felipe Balbi 
Signed-off-by: Chanwoo Choi 
Acked-by: Lee Jones

extcon: palmas: Fix build break due to devm_gpiod_get_optional API change

2015-08-13T11:56:18+00:00

With commit b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")
it becomes necessary to pass the flags argument. And this patch adds the gpio
header file to fix the build breakage when build testing with random
configuration files.

Reported-by: Stephen Rothwell 
Signed-off-by: Chanwoo Choi 
Acked-by: Uwe Kleine-König

extcon: palmas: Support GPIO based USB ID detection

2015-08-10T12:26:25+00:00

Some palmas based chip variants do not have OTG based ID logic.
For these variants we rely on GPIO based USB ID detection.

These chips do have VBUS comparator for VBUS detection so we
continue to use the old way of detecting VBUS.

Signed-off-by: Roger Quadros 
Acked-by: Chanwoo Choi 
Acked-by: Lee Jones 
Signed-off-by: Chanwoo Choi

extcon: palmas: Remove the mutually_exclusive array

2015-08-10T02:48:55+00:00

This patch removes the mutually_exclusive array of extcon-palmas.c.
After used the unique id of each external connector on 2a9de9c0f08d
("extcon: Use the unique id for external connector instead of string"),
extcon driver can't directly handle the bit value indicating the external
connectors.

Signed-off-by: Chanwoo Choi

extcon: palmas: Fix NULL pointer error

2015-07-29T08:55:53+00:00

This patch fixes NULL pointer error by removing the unneeded kfree() call
of edev->name because extcon-palmas no longer allocate the memory for edev->name.

Fixes: d71aadda19f8 ("extcon: Remove the optional name of extcon device")
Signed-off-by: Chanwoo Choi 
Reviewed-by: Krzysztof Kozlowski