linux-toradex.git/drivers/firewire/core-cdev.c, branch v3.11-rc5

firewire: fix libdc1394/FlyCap2 iso event regression

2013-07-27T18:24:36+00:00

Commit 18d627113b83 (firewire: prevent dropping of completed iso packet
header data) was intended to be an obvious bug fix, but libdc1394 and
FlyCap2 depend on the old behaviour by ignoring all returned information
and thus not noticing that not all packets have been received yet.  The
result was that the video frame buffers would be saved before they
contained the correct data.

Reintroduce the old behaviour for old clients.

Tested-by: Stepan Salenikovich 
Tested-by: Josep Bosch 
Cc:  # 3.4+
Signed-off-by: Clemens Ladisch 
Signed-off-by: Stefan Richter

firewire: remove unnecessary alloc/OOM messages

2013-04-28T21:36:44+00:00

These are redundant to log messages from the mm core.

Signed-off-by: Stefan Richter

firewire: core: remove an always false test

2013-04-28T21:36:43+00:00

struct fw_cdev_allocate_iso_resource.bandwidth is unsigned.

Signed-off-by: Stefan Richter

firewire: convert to idr_alloc()

2013-02-28T03:10:15+00:00

Convert to the much saner new idr interface.

v2: Stefan pointed out that add_client_resource() may be called from
    non-process context.  Preload iff @gfp_mask contains __GFP_WAIT.
    Also updated to include minor upper limit check.

[tim.gardner@canonical.com: fix accidentally orphaned 'minor'[
Signed-off-by: Tejun Heo 
Acked-by: Stefan Richter 
Signed-off-by: Tim Gardner 
Signed-off-by: Stefan Richter 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

firewire: don't use idr_remove_all()

2013-02-28T03:10:13+00:00

idr_destroy() can destroy idr by itself and idr_remove_all() is being
deprecated.  Drop its usage.

Signed-off-by: Tejun Heo 
Cc: Stefan Richter 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

firewire: cdev: fix user memory corruption (i386 userland on amd64 kernel)

2012-10-09T16:26:28+00:00

Fix two bugs of the /dev/fw* character device concerning the
FW_CDEV_IOC_GET_INFO ioctl with nonzero fw_cdev_get_info.bus_reset.
(Practically all /dev/fw* clients issue this ioctl right after opening
the device.)

Both bugs are caused by sizeof(struct fw_cdev_event_bus_reset) being 36
without natural alignment and 40 with natural alignment.

 1) Memory corruption, affecting i386 userland on amd64 kernel:
    Userland reserves a 36 bytes large buffer, kernel writes 40 bytes.
    This has been first found and reported against libraw1394 if
    compiled with gcc 4.7 which happens to order libraw1394's stack such
    that the bug became visible as data corruption.

 2) Information leak, affecting all kernel architectures except i386:
    4 bytes of random kernel stack data were leaked to userspace.

Hence limit the respective copy_to_user() to the 32-bit aligned size of
struct fw_cdev_event_bus_reset.

Reported-by: Simon Kirby 
Signed-off-by: Stefan Richter 
Cc: stable@kernel.org

firewire: core: fix DMA mapping direction

2012-04-17T20:27:37+00:00

Seen with recent libdc1394:  If a client mmap()s the buffer of an
isochronous reception buffer with PROT_READ|PROT_WRITE instead of just
PROT_READ, firewire-core sets the wrong DMA mapping direction during
buffer initialization.

The fix is to split fw_iso_buffer_init() into allocation and DMA mapping
and to perform the latter after both buffer and DMA context were
allocated.  Buffer allocation and context allocation may happen in any
order, but we need the context type (reception or transmission) in order
to set the DMA direction of the buffer.

Signed-off-by: Stefan Richter

Remove all #inclusions of asm/system.h

2012-03-28T17:30:03+00:00

Remove all #inclusions of asm/system.h preparatory to splitting and killing
it.  Performed with the following command:

perl -p -i -e 's!^#\s*include\s*.*\n!!' `grep -Irl '^#\s*include\s*' *`

Signed-off-by: David Howells

firewire: allow explicit flushing of iso packet completions

2012-03-18T21:15:39+00:00

Extend the kernel and userspace APIs to allow reporting all currently
completed isochronous packets, even if the next interrupt packet has not
yet been reached.  This is required to determine the status of the
packets at the end of a paused or stopped stream, and useful for more
precise synchronization of audio streams.

Signed-off-by: Clemens Ladisch 
Signed-off-by: Stefan Richter

firewire: prevent dropping of completed iso packet header data

2012-03-18T21:15:39+00:00

The buffer for the header data of completed iso packets has a fixed
size, so it is possible to configure a stream with a big interval
between interrupt packets or with big headers so that this buffer would
overflow.  Previously, ohci.c would drop any data that would not fit,
but this could make unsuspecting applications believe that fewer than
the actual number of packets have completed.

Instead of dropping data, add calls to flush_iso_completion() so that
there are as many events as needed to report all of the data.

Signed-off-by: Clemens Ladisch 
Signed-off-by: Stefan Richter