linux-toradex.git/drivers/firmware/google, branch v3.18-rc5

firmware: google memconsole driver fixes

2014-02-15T19:30:28+00:00

The google memconsole driver is currently broken upstream, as it tries
to read memory that is described as reserved in /proc/iomem, by
dereferencing a pointer obtained through phys_to_virt(). This triggers
a kernel fault as such regions are unmapped after early boot.

The proper workaround is to use ioremap_cache() / iounmap() around such
accesses.

As some unrelated changes, I also converted some printks to use pr_info()
and added some missing __init annotations.

Tested: booted dbg build, verified I could read /sys/firmware/log

Signed-off-by: Michel Lespinasse 
Acked-by: Mike Waychison 
Signed-off-by: Greg Kroah-Hartman

firmware: fix google/gsmi duplicate efivars_sysfs_init()

2014-02-15T19:29:56+00:00

Starting in commit e14ab23dde12b80db4c94b684a2e485b72b16af3,
efivars_sysfs_init() is called both by itself as an init function,
and by drivers/firmware/google/gsmi.c gsmi_init().

This results in runtime warnings such as the following:
[    5.651330] WARNING: at fs/sysfs/dir.c:530 sysfs_add_one+0xbd/0xe0()
[    5.657699] sysfs: cannot create duplicate filename '/firmware/gsmi/vars'

Fixing this by removing the redundant efivars_sysfs_init() call in
gsmi_init().

Tested: booted, checked that /firmware/gsmi/vars was still present and
showed the expected contents.

Signed-off-by: Michel Lespinasse 
Acked-by: Matt Fleming 
Acked-by: Mike Waychison 
Signed-off-by: Greg Kroah-Hartman

firmware/google: drop 'select EFI' to avoid recursive dependency

2014-01-28T05:02:40+00:00

The GOOGLE_SMI Kconfig symbol depends on DMI and selects EFI.  This
causes problems on other archs when introducing DMI support that depends
on EFI, as it results in a recursive dependency:

  arch/arm/Kconfig:1845:error: recursive dependency detected!
  arch/arm/Kconfig:1845:	symbol DMI depends on EFI

Fix by changing the 'select EFI' to a 'depends on EFI'.

Signed-off-by: Ard Biesheuvel 
Cc: David Rientjes 
Acked-by: Mike Waychison 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

DMA-API: firmware/google/gsmi.c: avoid direct access to DMA masks

2013-10-31T14:49:17+00:00

This driver doesn't need to directly access DMA masks if it uses the
platform_device_register_full() API rather than
platform_device_register_simple() - the former function can initialize
the DMA mask appropriately.

Signed-off-by: Russell King

drivers/firmware/google/gsmi.c: replace strict_strtoul() with kstrtoul()

2013-09-11T22:58:16+00:00

The use of strict_strtoul() is not preferred, because strict_strtoul() is
obsolete.  Thus, kstrtoul() should be used.

Signed-off-by: Jingoo Han 
Cc: Matt Fleming 
Cc: Tom Gundersen 
Cc: Mike Waychison 
Acked-by: Mike Waychison 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Merge tag 'v3.9' into efi-for-tip2

2013-04-30T10:42:13+00:00

Resolve conflicts for Ingo.

Conflicts:
	drivers/firmware/Kconfig
	drivers/firmware/efivars.c

Signed-off-by: Matt Fleming

efivars: efivar_entry API

2013-04-17T12:23:59+00:00

There isn't really a formal interface for dealing with EFI variables
or struct efivar_entry. Historically, this has led to various bits of
code directly accessing the generic EFI variable ops, which inherently
ties it to specific EFI variable operations instead of indirectly
using whatever ops were registered with register_efivars(). This lead
to the efivarfs code only working with the generic EFI variable ops
and not CONFIG_GOOGLE_SMI.

Encapsulate everything that needs to access '__efivars' inside an
efivar_entry_* API and use the new API in the pstore, sysfs and
efivarfs code.

Much of the efivars code had to be rewritten to use this new API. For
instance, it is now up to the users of the API to build the initial
list of EFI variables in their efivar_init() callback function. The
variable list needs to be passed to efivar_init() which allows us to
keep work arounds for things like implementation bugs in
GetNextVariable() in a central location.

Allowing users of the API to use a callback function to build the list
greatly benefits the efivarfs code which needs to allocate inodes and
dentries for every variable.  It previously did this in a racy way
because the code ran without holding the variable spinlock. Both the
sysfs and efivarfs code maintain their own lists which means the two
interfaces can be running simultaneously without interference, though
it should be noted that because no synchronisation is performed it is
very easy to create inconsistencies. efibootmgr doesn't currently use
efivarfs and users are likely to also require the old sysfs interface,
so it makes sense to allow both to be built.

Reviewed-by: Tom Gundersen 
Tested-by: Tom Gundersen 
Cc: Seiji Aguchi 
Cc: Matthew Garrett 
Cc: Jeremy Kerr 
Cc: Tony Luck 
Cc: Mike Waychison 
Signed-off-by: Matt Fleming

efi: move utf16 string functions to efi.h

2013-04-17T07:28:21+00:00

There are currently two implementations of the utf16 string functions.
Somewhat confusingly, they've got different names.

Centralise the functions in efi.h.

Reviewed-by: Tom Gundersen 
Tested-by: Tom Gundersen 
Reviewed-by: Mike Waychison 
Signed-off-by: Matt Fleming

firmware: google: fix gsmi.c build warning

2011-12-10T00:23:49+00:00

Use min_t() macro instead of min() to fix a build warning:

  CC      drivers/firmware/google/gsmi.o
drivers/firmware/google/gsmi.c: In function ‘gsmi_get_variable’:
drivers/firmware/google/gsmi.c:348: warning: comparison of distinct
pointer types lacks a cast

Signed-off-by: Maxin B. John 
Acked-By: Mike Waychison 
Signed-off-by: Greg Kroah-Hartman

drivers/firmware: Add module.h to google/gsmi.c

2011-10-31T23:31:46+00:00

This file really needs the full module.h header file present, but
was just getting it implicitly before.  Fix it up in advance so we
avoid build failures once the cleanup commit is present.

Signed-off-by: Paul Gortmaker