linux-toradex.git/drivers/firmware, branch v2.6.27.50

firmware_map: fix hang with x86/32bit

2009-07-02T23:31:31+00:00

commit 3b0fde0fac19c180317eb0601b3504083f4b9bf5 upstream.

Addresses http://bugzilla.kernel.org/show_bug.cgi?id=13484

Peer reported:
| The bug is introduced from kernel 2.6.27, if E820 table reserve the memory
| above 4G in 32bit OS(BIOS-e820: 00000000fff80000 - 0000000120000000
| (reserved)), system will report Int 6 error and hang up. The bug is caused by
| the following code in drivers/firmware/memmap.c, the resource_size_t is 32bit
| variable in 32bit OS, the BUG_ON() will be invoked to result in the Int 6
| error. I try the latest 32bit Ubuntu and Fedora distributions, all hit this
| bug.
|======
|static int firmware_map_add_entry(resource_size_t start, resource_size_t end,
|                  const char *type,
|                  struct firmware_map_entry *entry)

and it only happen with CONFIG_PHYS_ADDR_T_64BIT is not set.

it turns out we need to pass u64 instead of resource_size_t for that.

[akpm@linux-foundation.org: add comment]
Reported-and-tested-by: Peer Chen 
Signed-off-by: Yinghai Lu 
Cc: Ingo Molnar 
Acked-by: H. Peter Anvin 
Cc: Thomas Gleixner 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds 
Signed-off-by: Greg Kroah-Hartman

dell_rbu: use scnprintf() instead of less secure sprintf()

2009-01-25T00:36:25+00:00

commit 81156928f8fe31621e467490b9d441c0285998c3 upstream.

Reading 0 bytes from /sys/devices/platform/dell_rbu/image_type or
/sys/devices/platform/dell_rbu/packet_size by an ordinary user causes an
oops.

Signed-off-by: Pavel Roskin 
Signed-off-by: Linus Torvalds 
Signed-off-by: Greg Kroah-Hartman

ibft: fix target info parsing in ibft module

2008-09-03T02:21:40+00:00

I got this patch through Red Hat's bugzilla from the bug submitter and
patch creator.  I have just fixed it up so it applies without fuzz to
upstream kernels.

Original patch and description from Shyam kumar Iyer:

The issue [ibft module not displaying targets with short names] is because
of an offset calculatation error in the iscsi_ibft.c code.  Due to this
error directory structure for the target in /sys/firmware/ibft does not
get created and so the initiator is unable to connect to the target.

Note that this bug surfaced only with an name that had a short section at
the end.  eg: "iqn.1984-05.com.dell:dell".  It did not surface when the
iqn's had a longer section at the end.  eg:
"iqn.2001-04.com.example:storage.disk2.sys1.xyz"

So, the eot_offset was calculated such that an extra 48 bytes i.e.  the
size of the ibft_header which has already been accounted was subtracted
twice.

This was not evident with longer iqn names because they would overshoot
the total ibft length more than 48 bytes and thus would escape the bug.

Signed-off-by: Shyam Kumar Iyer 
Signed-off-by: Mike Christie 
Cc: Konrad Rzeszutek 
Cc: Peter Jones 
Cc: James Bottomley 
Cc: Greg Kroah-Hartman 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

firmware/memmap: cleanup

2008-08-12T23:07:31+00:00

Various cleanup the drivers/firmware/memmap (after review by AKPM):

    - fix kdoc to conform to the standard
    - move kdoc from header to implementation files
    - remove superfluous WARN_ON() after kmalloc()
    - WARN_ON(x); if (!x) -> if(!WARN_ON(x))
    - improve some comments

Signed-off-by: Bernhard Walle 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

iscsi_ibft_find: fix modpost warning

2008-07-30T16:41:44+00:00

Exporting __init functions is wrong.

Signed-off-by: Jan Beulich 
Acked-by: Konrad Rzeszutek 
Cc: Ingo Molnar 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Merge branch 'linus' into cpus4096

2008-07-28T19:14:43+00:00

firmware: fix memmap printk format warnings

2008-07-27T03:16:48+00:00

Fix firmware/memmap printk format warnings:

  drivers/firmware/memmap.c:156: warning: format '%llx' expects type 'long long unsigned int', but argument 4 has type 'resource_size_t'
  drivers/firmware/memmap.c:161: warning: format '%llx' expects type 'long long unsigned int', but argument 4 has type 'resource_size_t'

Signed-off-by: Randy Dunlap 
Cc: Bernhard Walle 
Cc: Ingo Molnar 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

cpumask: change cpumask_of_cpu_ptr to use new cpumask_of_cpu

2008-07-26T14:40:33+00:00

  * Replace previous instances of the cpumask_of_cpu_ptr* macros
    with a the new (lvalue capable) generic cpumask_of_cpu().

Signed-off-by: Mike Travis 
Cc: Andrew Morton 
Cc: Jack Steiner 
Cc: Rusty Russell 
Signed-off-by: Ingo Molnar

dell_rbu: use memory_read_from_buffer()

2008-07-25T17:53:44+00:00

Signed-off-by: Akinobu Mita 
Cc: Abhay Salunke 
Cc: Zhang Rui 
Cc: Matt Domsch 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

dcdbas: use memory_read_from_buffer()

2008-07-25T17:53:44+00:00

Signed-off-by: Akinobu Mita 
Cc: Doug Warzecha 
Cc: Zhang Rui 
Cc: Matt Domsch 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds