linux-toradex.git/drivers/fsi/fsi-master-ast-cf.c, branch v5.18

fsi: master-ast-cf: Remove redundant error printing in fsi_master_acf_probe()

2021-06-04T05:32:55+00:00

When devm_ioremap_resource() fails, a clear enough error message will be
printed by its subfunction __devm_ioremap_resource(). The error
information contains the device name, failure cause, and possibly resource
information.

Therefore, remove the error printing here to simplify code and reduce the
binary size.

Reported-by: Hulk Robot 
Signed-off-by: Zhen Lei 
Link: https://patchwork.ozlabs.org/project/linux-fsi/patch/20210511085745.4340-1-thunder.leizhen@huawei.com/
Signed-off-by: Joel Stanley

fsi: Add missing MODULE_DEVICE_TABLE

2021-06-04T04:40:45+00:00

This patch adds missing MODULE_DEVICE_TABLE definition which generates
correct modalias for automatic loading of this driver when it is built
as an external module.

Reported-by: Hulk Robot 
Signed-off-by: Zou Wei 
Link: https://lore.kernel.org/r/1620896249-52769-1-git-send-email-zou_wei@huawei.com
Signed-off-by: Joel Stanley

fsi: master: Add boolean parameter to link_enable function

2020-09-10T02:52:47+00:00

Add the ability to disable a link with a boolean parameter to the
link_enable function. This is necessary so that the master can disable
links that it isn't using; for example, links to slaves that fail
initialization.

Signed-off-by: Eddie James 
Signed-off-by: Joel Stanley

fsi: master-ast-cf: fix spelling mistake "firwmare" -> "firmware"

2020-09-10T02:52:46+00:00

There is a spelling mistake in a dev_err error message. Fix it.

Signed-off-by: Colin Ian King 
Reviewed-by: Andrew Jeffery 
Signed-off-by: Joel Stanley

fsi: master-ast-cf: Rename dump_trace() to avoid name collision

2018-07-26T04:49:50+00:00

s390 defines a global dump_trace() symbol. Rename ours to
dump_ucode_trace() to avoid a collision in build tests.

Signed-off-by: Benjamin Herrenschmidt

fsi: master-ast-cf: Fix memory leak

2018-07-25T23:56:17+00:00

In case memory resources for *fw* were allocated, release them
before return.

Addresses-Coverity-ID: 1472044 ("Resource leak")
Fixes: 6a794a27daca ("fsi: master-ast-cf: Add new FSI master using Aspeed ColdFire")
Signed-off-by: Gustavo A. R. Silva 
Signed-off-by: Benjamin Herrenschmidt

fsi: master-ast-cf: Mask unused bits in RTAG/RCRC

2018-07-25T06:04:53+00:00

Then reading the RTAG/RCRC "registers" from the coprocessor after
a command is complete, mask out the top bits, only keep the relevant
bits. Microcode v5 will leave garbage in those top bits as a
result of a performance optimization.

Signed-off-by: Benjamin Herrenschmidt 
---

fsi: master-ast-cf: Fix build warnings on 64-bit platforms

2018-07-24T06:35:03+00:00

A couple of places forgot the 'z' qualifier for dev_dbg
when printing a size_t

Signed-off-by: Benjamin Herrenschmidt

fsi: master-ast-cf: Add new FSI master using Aspeed ColdFire

2018-07-23T05:22:52+00:00

The Aspeed AST2x00 can contain a ColdFire v1 coprocessor which
is currently unused on OpenPower systems.

This adds an alternative to the fsi-master-gpio driver that
uses that coprocessor instead of bit banging from the ARM
core itself. The end result is about 4 times faster.

The firmware for the coprocessor and its source code can be
found at https://github.com/ozbenh/cf-fsi and is system specific.

Signed-off-by: Benjamin Herrenschmidt