linux-toradex.git/drivers/gpio/gpio-ge.c, branch v6.7

gpio: ge: Replace GPLv2 boilerplate with SPDX

2023-07-27T07:33:07+00:00

Replace the GPLv2 boilerplate text with a nice and short
SPDX header.

Signed-off-by: Andy Shevchenko 
Acked-by: Randy Dunlap 
Tested-by: Randy Dunlap  # build-tested
Signed-off-by: Bartosz Golaszewski

gpio: ge: Utilise temporary variable for struct device

2023-07-27T07:33:04+00:00

We have a temporary variable to keep pointer to struct device.
Utilise it inside the ->probe() implementation.

Signed-off-by: Andy Shevchenko 
Acked-by: Randy Dunlap 
Tested-by: Randy Dunlap  # build-tested
Signed-off-by: Bartosz Golaszewski

gpio: ge: Make driver OF-independent

2023-07-27T07:33:01+00:00

There is nothing in the driver that requires OF APIs,
make the driver OF independent.

Signed-off-by: Andy Shevchenko 
Acked-by: Randy Dunlap 
Tested-by: Randy Dunlap  # build-tested
Signed-off-by: Bartosz Golaszewski

gpio: ge: Fix English spelling and grammar

2023-07-27T07:32:57+00:00

Fix English spelling and grammar in the comments.
While at it, fix the MODULE_AUTHOR() email address format.

Reported-by: Randy Dunlap 
Closes: https://lore.kernel.org/r/65b4ac1a-1128-6e2a-92c0-9bbcca4b760a@infradead.org
Signed-off-by: Andy Shevchenko 
Acked-by: Randy Dunlap 
Tested-by: Randy Dunlap  # build-tested
Signed-off-by: Bartosz Golaszewski

gpio: ge: Add missing header

2023-07-27T07:32:50+00:00

Add missing platform_device.h that used to be implied by of_device.h.

While at it, sort headers alphabetically for better maintenance.

Reported-by: Randy Dunlap 
Fixes: e91d0f05e66a ("gpio: Explicitly include correct DT includes")
Closes: https://lore.kernel.org/r/65b4ac1a-1128-6e2a-92c0-9bbcca4b760a@infradead.org
Signed-off-by: Andy Shevchenko 
Reviewed-by: Rob Herring 
Acked-by: Randy Dunlap 
Tested-by: Randy Dunlap  # build-tested
Signed-off-by: Bartosz Golaszewski

gpio: Explicitly include correct DT includes

2023-07-19T11:24:01+00:00

The DT of_device.h and of_platform.h date back to the separate
of_platform_bus_type before it as merged into the regular platform bus.
As part of that merge prepping Arm DT support 13 years ago, they
"temporarily" include each other. They also include platform_device.h
and of.h. As a result, there's a pretty much random mix of those include
files used throughout the tree. In order to detangle these headers and
replace the implicit includes with struct declarations, users need to
explicitly include the correct includes.

Signed-off-by: Rob Herring 
Reviewed-by: Andy Shevchenko 
Acked-by: Romain Perier 
Signed-off-by: Bartosz Golaszewski

gpio: ge: Remove duplicate assignment of of_gpio_n_cells

2023-01-30T14:55:30+00:00

The of_gpio_n_cells default is 2 when ->of_xlate() callback is
not defined. No need to assign it explicitly in the driver.

Signed-off-by: Andy Shevchenko 
Signed-off-by: Bartosz Golaszewski

gpio: Get rid of duplicate of_node assignment in the drivers

2021-12-17T16:39:35+00:00

GPIO library does copy the of_node from the parent device of
the GPIO chip, there is no need to repeat this in the individual
drivers. Remove these assignment all at once.

For the details one may look into the of_gpio_dev_init() implementation.

While at it, remove duplicate parent device assignment where it is the case.

Signed-off-by: Andy Shevchenko 
Reviewed-By: Matti Vaittinen 
Signed-off-by: Bartosz Golaszewski

gpio: ge: Fix build warning

2018-05-16T12:35:24+00:00

Casting a pointer to u16 can produce a compiler warning such as this:

    drivers/gpio/gpio-ge.c: In function 'gef_gpio_probe':
    drivers/gpio/gpio-ge.c:83:14: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
        gc->ngpio = (u16)of_device_get_match_data(&pdev->dev);
                    ^

Cast the pointer through a uintptr_t to avoid the warning.

Reported-by: kbuild test robot 
Signed-off-by: Thierry Reding 
Signed-off-by: Linus Walleij

gpio: ge: Use of_device_get_match_data()

2018-05-16T12:35:24+00:00

Use of_device_get_match_data() instead of open-coding it.

Signed-off-by: Thierry Reding 
Signed-off-by: Linus Walleij