linux-toradex.git/drivers/gpio/gpio-max7301.c, branch v7.0-rc2

spi: make remove callback a void function

2022-02-09T13:00:45+00:00

The value returned by an spi driver's remove function is mostly ignored.
(Only an error message is printed if the value is non-zero that the
error is ignored.)

So change the prototype of the remove function to return no value. This
way driver authors are not tempted to assume that passing an error to
the upper layer is a good idea. All drivers are adapted accordingly.
There is no intended change of behaviour, all callbacks were prepared to
return 0 before.

Signed-off-by: Uwe Kleine-König 
Acked-by: Marc Kleine-Budde 
Acked-by: Andy Shevchenko 
Reviewed-by: Geert Uytterhoeven 
Acked-by: Jérôme Pouiller 
Acked-by: Miquel Raynal 
Acked-by: Jonathan Cameron 
Acked-by: Claudius Heine 
Acked-by: Stefan Schmidt 
Acked-by: Alexandre Belloni 
Acked-by: Ulf Hansson  # For MMC
Acked-by: Marcus Folkesson 
Acked-by: Łukasz Stelmach 
Acked-by: Lee Jones 
Link: https://lore.kernel.org/r/20220123175201.34839-6-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown

gpio: max730x: Make __max730x_remove() return void

2021-10-13T17:52:26+00:00

An spi or i2c remove callback is only called for devices that probed
successfully. In this case this implies that __max730x_probe() set a
non-NULL driver data. So the check ts == NULL is never true. With this
check dropped, __max730x_remove() returns zero unconditionally. Make it
return void instead which makes it easier to see in the callers that
there is no error to handle.

Also the return value of i2c and spi remove callbacks is ignored anyway.

Signed-off-by: Uwe Kleine-König 
Signed-off-by: Bartosz Golaszewski

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500

2019-06-19T15:09:55+00:00

Based on 2 normalized pattern(s):

  this program is free software you can redistribute it and or modify
  it under the terms of the gnu general public license version 2 as
  published by the free software foundation

  this program is free software you can redistribute it and or modify
  it under the terms of the gnu general public license version 2 as
  published by the free software foundation #

extracted by the scancode license scanner the SPDX license identifier

  GPL-2.0-only

has been chosen to replace the boilerplate/reference in 4122 file(s).

Signed-off-by: Thomas Gleixner 
Reviewed-by: Enrico Weigelt 
Reviewed-by: Kate Stewart 
Reviewed-by: Allison Randal 
Cc: linux-spdx@vger.kernel.org
Link: https://lkml.kernel.org/r/20190604081206.933168790@linutronix.de
Signed-off-by: Greg Kroah-Hartman

gpio: max7301: fix driver for use with CONFIG_VMAP_STACK

2018-12-21T08:23:45+00:00

spi_read() and spi_write() require DMA-safe memory. When
CONFIG_VMAP_STACK is selected, those functions cannot be used
with buffers on stack.

This patch replaces calls to spi_read() and spi_write() by
spi_write_then_read() which doesn't require DMA-safe buffers.

Fixes: 0c36ec314735 ("gpio: gpio driver for max7301 SPI GPIO expander")
Cc: 
Signed-off-by: Christophe Leroy 
Signed-off-by: Linus Walleij

spi: Drop owner assignment from spi_drivers

2015-10-28T01:30:17+00:00

An spi_driver does not need to set an owner, it will be populated by the
driver core.

Signed-off-by: Andrew F. Davis 
Acked-by: Jonathan Cameron 
Signed-off-by: Mark Brown

gpio: max7301: Reverting "Do not force SPI speed when using OF Platform"

2013-08-23T17:44:28+00:00

This patch reverts commit 047b93a35961f7a6561e6f5dcb040738f822b892 which breaks
MAX7301 GPIO driver because that commit was dependant on a rejected patch that
was implementing selection of SPI speed from the Device Tree.

Signed-off-by: Christophe Leroy 
Acked-by: Roland Stigge 
Signed-off-by: Linus Walleij

MAX7301 GPIO: Do not force SPI speed when using OF Platform

2013-03-27T15:05:18+00:00

The bit_per_word can be set in the OF Device tree, so no need to force it as with
the platform_data when using OF Platform

Signed-off-by: Patrick Vasseur 
Signed-off-by: Christophe Leroy 
Signed-off-by: Linus Walleij

gpio: max7301: use devm_kzalloc()

2013-03-27T15:05:11+00:00

Use devm_kzalloc() to make cleanup paths simpler.

Signed-off-by: Jingoo Han 
Signed-off-by: Linus Walleij

gpio: remove use of __devexit

2012-11-28T19:39:59+00:00

CONFIG_HOTPLUG is going away as an option so __devexit is no
longer needed.

Signed-off-by: Bill Pemberton 
Cc: Grant Likely 
Acked-by: Linus Walleij 
Cc: Peter Tyser 
Acked-by: Mark Brown 
Signed-off-by: Greg Kroah-Hartman

gpio: remove use of __devinit

2012-11-28T19:39:33+00:00

CONFIG_HOTPLUG is going away as an option so __devinit is no longer
needed.

Signed-off-by: Bill Pemberton 
Cc: Grant Likely 
Cc: Peter Tyser 
Cc: Santosh Shilimkar 
Cc: Kevin Hilman 
Acked-by: Linus Walleij 
Acked-by: Mark Brown 
Signed-off-by: Greg Kroah-Hartman