linux-toradex.git/drivers/gpio/gpio-pch.c, branch v4.9.118

gpio: pch: Optimize pch_gpio_get()

2016-01-05T14:46:34+00:00

The double negation is costly and can be avoided by shifting the
register value before masking the requested bit.

Signed-off-by: Jean Delvare 
Cc: Linus Walleij 
Signed-off-by: Linus Walleij

gpio: pch: use gpiochip data pointer

2016-01-05T10:21:11+00:00

This makes the driver use the data pointer added to the gpio_chip
to store a pointer to the state container instead of relying on
container_of().

Cc: Thierry Reding 
Cc: Daniel Krueger 
Reviewed-by: Jean Delvare 
Signed-off-by: Linus Walleij

gpio: pch: Be sure to clamp return value

2015-12-26T21:28:20+00:00

As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.

Cc: Thierry Reding 
Cc: Daniel Krueger 
Cc: Jean Delvare 
Signed-off-by: Linus Walleij

gpio: pch: fix non-DT build

2015-12-15T13:41:44+00:00

commit 1cfadea8f395e3fb6a15ea548e3e86c8b6d64f98
"gpio: pch: allow use from device tree"
makes the driver not compile unless CONFIG_OF_GPIO is set.
Fix it.

Cc: Paul Burton 
Signed-off-by: Linus Walleij

gpio: pch: allow use from device tree

2015-12-10T16:24:40+00:00

Allow GPIOs from the gpio-pch driver to be referenced from device tree
by simply setting the struct gpio_chip of_node pointer to that of the
struct pci_dev.

Signed-off-by: Paul Burton 
Signed-off-by: Linus Walleij

gpio: change member .dev to .parent

2015-11-19T08:24:35+00:00

The name .dev in a struct is normally reserved for a struct device
that is let us say a superclass to the thing described by the struct.
struct gpio_chip stands out by confusingly using a struct device *dev
to point to the parent device (such as a platform_device) that
represents the hardware. As we want to give gpio_chip:s real devices,
this is not working. We need to rename this member to parent.

This was done by two coccinelle scripts, I guess it is possible to
combine them into one, but I don't know such stuff. They look like
this:

@@
struct gpio_chip *var;
@@
-var->dev
+var->parent

and:

@@
struct gpio_chip var;
@@
-var.dev
+var.parent

and:

@@
struct bgpio_chip *var;
@@
-var->gc.dev
+var->gc.parent

Plus a few instances of bgpio that I couldn't figure out how
to teach Coccinelle to rewrite.

This patch hits all over the place, but I *strongly* prefer this
solution to any piecemal approaches that just exercise patch
mechanics all over the place. It mainly hits drivers/gpio and
drivers/pinctrl which is my own backyard anyway.

Cc: Haavard Skinnemoen 
Cc: Rafał Miłecki 
Cc: Richard Purdie 
Cc: Mauro Carvalho Chehab 
Cc: Alek Du 
Cc: Jaroslav Kysela 
Cc: Takashi Iwai 
Acked-by: Dmitry Torokhov 
Acked-by: Greg Kroah-Hartman 
Acked-by: Lee Jones 
Acked-by: Jiri Kosina 
Acked-by: Hans-Christian Egtvedt 
Acked-by: Jacek Anaszewski 
Signed-off-by: Linus Walleij

gpio/pch: Use irq_set_handler_locked()

2015-07-14T10:12:20+00:00

Use irq_set_handler_locked() as it avoids a redundant lookup of the
irq descriptor.

Search and replacement was done with coccinelle:

Signed-off-by: Thomas Gleixner 
Cc: Jiang Liu 
Cc: Julia Lawall 
Cc: Linus Walleij 
Cc: Alexandre Courbot 
Cc: linux-gpio@vger.kernel.org

gpio: pch: Build context save/restore only for PM

2014-10-02T14:07:00+00:00

The pch_gpio_save_reg_conf() and pch_gpio_restore_reg_conf() functions
are only used in pch_gpio_suspend() and pch_gpio_resume(), respectively.
Since the latter are only built if PM is enabled, make the former build
under the same conditions.

Signed-off-by: Thierry Reding 
Signed-off-by: Linus Walleij

gpio: remove all usage of gpio_remove retval in driver/gpio

2014-07-22T14:39:26+00:00

Signed-off-by: abdoulaye berthe 
Signed-off-by: Linus Walleij

gpio: pch: add slab include

2014-05-27T13:15:21+00:00

After change 3ff35cbcfa4bc7d7dbdd0279e32ea677567ded02
"gpio-pch: Fix Kconfig dependencies"
which enabled COMPILE_TEST as an alternative for the PCH
driver, we get build failures like this:

drivers/gpio/gpio-pch.c: In function 'pch_gpio_probe':
drivers/gpio/gpio-pch.c:359:2: error: implicit declaration
of function 'kzalloc' [-Werror=implicit-function-declaration]
drivers/gpio/gpio-pch.c:359:7: warning: assignment makes
pointer from integer without a cast [enabled by default]
drivers/gpio/gpio-pch.c:442:2: error: implicit declaration
of function 'kfree' [-Werror=implicit-function-declaration]

Fix this by including  explicitly.

Cc: Jean Delvare 
Signed-off-by: Linus Walleij