linux-toradex.git/drivers/gpio/gpio-rcar.c, branch v6.11

treewide: rename pinctrl_gpio_free_new()

2023-11-04T09:23:21+00:00

Now that pinctrl_gpio_free()() is no longer used, let's drop the '_new'
suffix from its improved variant.

Signed-off-by: Bartosz Golaszewski 
Acked-by: Linus Walleij

treewide: rename pinctrl_gpio_request_new()

2023-11-04T09:23:21+00:00

Now that pinctrl_gpio_request() is no longer used, let's drop the '_new'
suffix from its improved variant.

Signed-off-by: Bartosz Golaszewski 
Acked-by: Linus Walleij

gpio: rcar: use new pinctrl GPIO helpers

2023-11-04T09:23:18+00:00

Replace the pinctrl helpers taking the global GPIO number as argument
with the improved variants that instead take a pointer to the GPIO chip
and the controller-relative offset.

Signed-off-by: Bartosz Golaszewski 
Reviewed-by: Geert Uytterhoeven 
Acked-by: Geert Uytterhoeven 
Acked-by: Linus Walleij

gpio: rcar: Convert to platform remove callback returning void

2023-10-02T06:55:18+00:00

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König 
Reviewed-by: Linus Walleij 
Signed-off-by: Bartosz Golaszewski

gpio: Explicitly include correct DT includes

2023-07-19T11:24:01+00:00

The DT of_device.h and of_platform.h date back to the separate
of_platform_bus_type before it as merged into the regular platform bus.
As part of that merge prepping Arm DT support 13 years ago, they
"temporarily" include each other. They also include platform_device.h
and of.h. As a result, there's a pretty much random mix of those include
files used throughout the tree. In order to detangle these headers and
replace the implicit includes with struct declarations, users need to
explicitly include the correct includes.

Signed-off-by: Rob Herring 
Reviewed-by: Andy Shevchenko 
Acked-by: Romain Perier 
Signed-off-by: Bartosz Golaszewski

gpio: rcar: drop of_match_ptr for ID table

2023-03-15T09:38:05+00:00

The driver can match only via the DT table so the table should be always
used and the of_match_ptr does not have any sense (this also allows ACPI
matching via PRP0001, even though it might not be relevant here).

  drivers/gpio/gpio-rcar.c:435:34: error: ‘gpio_rcar_of_table’ defined but not used [-Werror=unused-const-variable=]

Signed-off-by: Krzysztof Kozlowski 
Reviewed-by: Linus Walleij 
Signed-off-by: Bartosz Golaszewski

gpio: rcar: Make the irqchip immutable

2022-05-24T14:35:49+00:00

Commit 6c846d026d49 ("gpio: Don't fiddle with irqchips marked as
immutable") added a warning to indicate if the gpiolib is altering the
internals of irqchips.  Following this change the following warning is
now observed for the gpio-rcar driver:

    gpio gpiochip0: (e6050000.gpio): not an immutable chip, please consider fixing it!

Fix this by making the irqchip in the gpio-rcar driver immutable.

Signed-off-by: Geert Uytterhoeven 
Reviewed-by: Andy Shevchenko 
Signed-off-by: Bartosz Golaszewski

gpio: rcar: Add R-Car Gen4 support

2022-04-05T13:10:00+00:00

R-Car V3U (R8A779A0) was the first member of the R-Car Gen4 family.
Generalize the support for R-Car V3U to other SoCs in the R-Car Gen4
family by adding a family-specific compatible value.

Signed-off-by: Geert Uytterhoeven 
Reviewed-by: Wolfram Sang 
Signed-off-by: Bartosz Golaszewski

gpio: rcar: Move PM device over to irq domain

2022-02-09T13:36:53+00:00

Move the reference to the device over to the irq domain.

Signed-off-by: Marc Zyngier 
Reviewed-by: Geert Uytterhoeven 
Tested-by: Geert Uytterhoeven 
Acked-by: Bartosz Golaszewski 
Link: https://lore.kernel.org/r/20220201120310.878267-9-maz@kernel.org

gpio: rcar: Propagate errors from devm_request_irq()

2022-01-05T08:57:34+00:00

The driver overrides the error code returned by devm_request_irq() to
-ENOENT. Switch to propagating the error code upstream.

Suggested-by: Andy Shevchenko 
Signed-off-by: Lad Prabhakar 
Reviewed-by: Andy Shevchenko 
Reviewed-by: Sergey Shtylyov 
Signed-off-by: Bartosz Golaszewski