linux-toradex.git/drivers/gpio/gpio-sim.c, branch v6.13

gpio: sim: lock up configfs that an instantiated device depends on

2025-01-03T16:15:04+00:00

Once a sim device is instantiated and actively used, allowing rmdir for
its configfs serves no purpose and can be confusing. Effectively,
arbitrary users start depending on its existence.

Make the subsystem itself depend on the configfs entry for a sim device
while it is in active use.

Signed-off-by: Koichiro Den 
Link: https://lore.kernel.org/r/20250103141829.430662-5-koichiro.den@canonical.com
Signed-off-by: Bartosz Golaszewski

gpio: sim: switch to device_for_each_child_node_scoped()

2024-10-01T18:53:48+00:00

Switch to device_for_each_child_node_scoped() to simplify the code by
removing the need for a call to fwnode_handle_put() in the error path.

This also prevents possible memory leaks if new error paths are added
without the required call to fwnode_handle_put().

Signed-off-by: Javier Carrasco 
Reviewed-by: Andy Shevchenko 
Link: https://lore.kernel.org/r/20240928-gpio_device_for_each_child_node_scoped-v1-2-c20eff315f4f@gmail.com
Signed-off-by: Bartosz Golaszewski

gpio: sim: lock GPIOs as interrupts when they are requested

2024-07-04T07:25:59+00:00

Use the extended irq_sim interface to supply the simulated interrupt
domain with callbacks allowing the GPIO sim to lock/unlock GPIOs
requested as interrupts.

Reviewed-by: Linus Walleij 
Acked-by: Linus Walleij 
Link: https://lore.kernel.org/r/20240624093934.17089-3-brgl@bgdev.pl
Signed-off-by: Bartosz Golaszewski

gpio: sim: use devm_mutex_init()

2024-06-11T19:38:42+00:00

Drop the hand-coded devres action callback for destroying the mutex in
favor of devm_mutex_init().

Suggested-by: Andy Shevchenko 
Reviewed-by: Andy Shevchenko 
Link: https://lore.kernel.org/r/20240610140548.35358-4-brgl@bgdev.pl
Signed-off-by: Bartosz Golaszewski

gpio: sim: drop kernel.h include

2024-06-11T19:38:41+00:00

We included kernel.h for ARRAY_SIZE() which has since been moved into
its own header. Use it instead.

Suggested-by: Andy Shevchenko 
Reviewed-by: Andy Shevchenko 
Link: https://lore.kernel.org/r/20240610140548.35358-3-brgl@bgdev.pl
Signed-off-by: Bartosz Golaszewski

gpio: sim: use device_match_name() instead of strcmp(dev_name(...

2024-06-11T19:38:41+00:00

Use the dedicated helper for comparing device names against strings.
While at it: reshuffle the code a bit for less indentation.

Suggested-by: Andy Shevchenko 
Reviewed-by: Andy Shevchenko 
Link: https://lore.kernel.org/r/20240610140548.35358-2-brgl@bgdev.pl
Signed-off-by: Bartosz Golaszewski

gpio: sim: use for_each_hwgpio()

2024-02-26T15:43:51+00:00

Display debugfs information about all simulated GPIOs, not only the
requested ones.

Signed-off-by: Bartosz Golaszewski 
Reviewed-by: Linus Walleij

gpio: sim: delimit the fwnode name with a ":" when generating labels

2024-02-26T15:43:51+00:00

Typically, whenever a human-readable name is created for objects using
a software node, its name is delimited with ":" as dashes are often used
in other parts of the name. Make gpio-sim use the same pattern. This
results in better looking default names:

  gpio-sim.0:node0
  gpio-sim.0:node1
  gpio-sim.1:node0

Signed-off-by: Bartosz Golaszewski 
Acked-by: Linus Walleij

gpio: sim: add lockdep asserts

2024-02-26T15:43:51+00:00

We have three functions in gpio-sim that are called with the device lock
already held. We use the "_unlocked" suffix in their names to indicate
that. This has proven to be confusing though as the naming convention in
the kernel varies between using "_locked" or "_unlocked" for this
purpose. Naming convention also doesn't enforce anything. Let's remove
the suffix and add lockdep annotation at the top of these functions.

This makes it clear the function requires a lock to be held (and which
one specifically!) as well as results in a warning if it's not the case.
The only place where the information is lost is the place where the
function is called but the caller doesn't care about that information
anyway.

Signed-off-by: Bartosz Golaszewski

gpio: sim: implement the dbg_show() callback

2023-12-08T08:37:30+00:00

Provide a custom implementation of the dbg_show() callback that prints
all requested lines together with their label, direction, value and
bias. This improves the code coverage of GPIOLIB.

Signed-off-by: Bartosz Golaszewski