linux-toradex.git/drivers/gpio/gpio-stmpe.c, branch v6.11

gpio: stmpe: use gpiochip_dup_line_label()

2023-12-08T08:26:28+00:00

Use the new gpiochip_dup_line_label() helper to safely retrieve the
descriptor label.

Signed-off-by: Bartosz Golaszewski 
Acked-by: Linus Walleij

gpio: stmpe: Convert to immutable irq_chip

2023-03-23T13:31:18+00:00

Convert the driver to immutable irq-chip with a bit of
intuition.

Cc: Marc Zyngier 
Signed-off-by: Linus Walleij 
Reviewed-by: Marc Zyngier 
Signed-off-by: Bartosz Golaszewski

gpio: Get rid of duplicate of_node assignment in the drivers

2021-12-17T16:39:35+00:00

GPIO library does copy the of_node from the parent device of
the GPIO chip, there is no need to repeat this in the individual
drivers. Remove these assignment all at once.

For the details one may look into the of_gpio_dev_init() implementation.

While at it, remove duplicate parent device assignment where it is the case.

Signed-off-by: Andy Shevchenko 
Reviewed-By: Matti Vaittinen 
Signed-off-by: Bartosz Golaszewski

gpio: stmpe: fully use convert probe to device-managed

2021-05-21T12:45:21+00:00

The IRQ is registered via devm_request_threaded_irq(), making the driver
only partially device-managed. This changeset converts the entire driver
to using only devres APIs.

This change also removes platform_set_drvdata() since the information is
never retrieved to be used in the driver.

Signed-off-by: Alexandru Ardelean 
Reviewed-by: Linus Walleij 
[Bart: tweaked the commit message]
Signed-off-by: Bartosz Golaszewski

gpio: stmpe: Fix forgotten refactoring

2020-10-28T14:51:27+00:00

We actually handle the gpio_irq_chip set-up properly
now despite what the comment says. Also assign this
pointer along with the rest of the gpio_irq_chip
setup code.

Signed-off-by: Linus Walleij 
Link: https://lore.kernel.org/r/20201019134429.65563-1-linus.walleij@linaro.org

treewide: Use fallthrough pseudo-keyword

2020-08-23T22:36:59+00:00

Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
fall-through markings when it is the case.

[1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

Signed-off-by: Gustavo A. R. Silva

gpio: stmpe: Move chip registration

2020-08-03T23:07:23+00:00

Make sure to register the GPIO chip after requesting the
interrupt and setting up the IRQ members of the irqchip.

Fixes: 9745079609df ("gpio: stmpe: Use irqchip template")
Reported-by: Serge Semin 
Signed-off-by: Linus Walleij 
Cc: Patrice Chotard 
Link: https://lore.kernel.org/r/20200728072706.348725-1-linus.walleij@linaro.org

gpio: stmpe: Use irqchip template

2020-07-20T13:34:17+00:00

This makes the driver use the irqchip template to assign
properties to the gpio_irq_chip instead of using the
explicit calls to gpiochip_irqchip_add_nested() and
gpiochip_set_nested_irqchip(). The irqchip is instead
added while adding the gpiochip.

Signed-off-by: Linus Walleij 
Cc: Patrice Chotard 
Cc: Alexandre TORGUE 
Link: https://lore.kernel.org/r/20200716100638.112451-1-linus.walleij@linaro.org

gpio: Use new GPIO_LINE_DIRECTION

2019-11-07T08:27:48+00:00

It's hard for occasional GPIO code reader/writer to know if values 0/1
equal to IN or OUT. Use defined GPIO_LINE_DIRECTION_IN and
GPIO_LINE_DIRECTION_OUT to help them out.

NOTE - for gpio-amd-fch and gpio-bd9571mwv:
This commit also changes the return value for direction get to equal 1
for direction INPUT. Prior this commit these drivers might have
returned some other positive value but 1 for INPUT.

Signed-off-by: Matti Vaittinen 
Acked-by: Scott Branden 
Reviewed-by: Grygorii Strashko 
Reviewed-by: Michal Simek 
Reviewed-by: Geert Uytterhoeven 
Acked-by: Andy Shevchenko 
Acked-by: William Breathitt Gray 
Acked-by: Kuppuswamy Sathyanarayanan 
Signed-off-by: Linus Walleij

gpio: Initialize the irqchip valid_mask with a callback

2019-09-11T00:09:37+00:00

After changing the valid_mask for the struct gpio_chip
to detect the need and presence of a valid mask with the
presence of a .init_valid_mask() callback to fill it in,
we augment the gpio_irq_chip to use the same logic.

Switch all driver using the gpio_irq_chio valid_mask
over to this new method.

This makes sure the valid_mask for the gpio_irq_chip gets
filled in when we add the gpio_chip, which makes it a
little easier to switch over drivers using the old
way of setting up gpio_irq_chip over to the new method
of passing the gpio_irq_chip along with the gpio_chip.
(See drivers/gpio/TODO for details.)

Cc: Joel Stanley 
Cc: Thierry Reding 
Signed-off-by: Linus Walleij 
Reviewed-by: Andy Shevchenko 
Tested-by: Hans de Goede 
Reviewed-by: Andrew Jeffery 
Acked-by: Mika Westerberg 
Reviewed-by: Andrew Lunn 
Reviewed-by: Patrice Chotard 
Link: https://lore.kernel.org/r/20190904140104.32426-1-linus.walleij@linaro.org