linux-toradex.git/drivers/gpio/gpiolib-sysfs.c, branch v5.17-rc4

gpiolib: Never return internal error codes to user space

2022-02-08T09:34:15+00:00

Currently it's possible that character device interface may return
the error codes which are not supposed to be seen by user space.
In this case it's EPROBE_DEFER.

Wrap it to return -ENODEV instead as sysfs does.

Fixes: d7c51b47ac11 ("gpio: userspace ABI for reading/writing GPIO lines")
Fixes: 61f922db7221 ("gpio: userspace ABI for reading GPIO line events")
Fixes: 3c0d9c635ae2 ("gpiolib: cdev: support GPIO_V2_GET_LINE_IOCTL and GPIO_V2_LINE_GET_VALUES_IOCTL")
Reported-by: Suresh Balakrishnan 
Signed-off-by: Andy Shevchenko 
Signed-off-by: Bartosz Golaszewski

gpiolib: Use sysfs_emit() in "show" functions

2021-05-21T12:56:10+00:00

The sysfs_emit() function was introduced to make it less ambiguous
which function is preferred when writing to the output buffer in
a "show" callback [1].

Convert the GPIO library sysfs interface from sprintf() to sysfs_emit()
accordingly, as the latter is aware of the PAGE_SIZE buffer and correctly
returns the number of bytes written into the buffer.

No functional change intended.

[1] Documentation/filesystems/sysfs.rst

Signed-off-by: Andy Shevchenko 
Signed-off-by: Bartosz Golaszewski

gpiolib: Make use of assign_bit() API (part 2)

2021-05-21T12:53:35+00:00

We have for some time the assign_bit() API to replace open coded

	if (foo)
		set_bit(n, bar);
	else
		clear_bit(n, bar);

Use this API in GPIO library code.

Signed-off-by: Andy Shevchenko 
Reviewed-by: Linus Walleij 
Signed-off-by: Bartosz Golaszewski

gpio: sysfs: Obey valid_mask

2021-03-31T18:32:38+00:00

Do not allow exporting GPIOs which are set invalid
by the driver's valid mask.

Fixes: 726cb3ba4969 ("gpiolib: Support 'gpio-reserved-ranges' property")
Signed-off-by: Matti Vaittinen 
Reviewed-by: Andy Shevchenko 
Signed-off-by: Bartosz Golaszewski

gpiolib: Unify expectations about ->request() returned value

2020-10-26T14:43:15+00:00

Half of the code in the GPIO library is written in an expectation that
any non-zero value returned from the ->request() callback is an error code,
while some code checks only for negative values.

Unify expectations about ->request() returned value to be non-zero
for an error and 0 for the success.

Signed-off-by: Andy Shevchenko 
Signed-off-by: Bartosz Golaszewski

gpiolib: move gpiolib-sysfs function declarations into their own header

2020-07-12T08:22:00+00:00

Move gpiolib-sysfs function declarations into their own header.

These functions are in gpiolib-sysfs.c, and are only required by gpiolib.c,
and so should be in a module header, not gpiolib.h.

This brings gpiolib-sysfs into line with gpiolib-cdev, and is another step
towards removing the sysfs inferface.

Signed-off-by: Kent Gibson 
Signed-off-by: Bartosz Golaszewski

gpiolib: sysfs: use kobj_to_dev

2020-06-15T08:07:49+00:00

Use kobj_to_dev() API instead of container_of().

Signed-off-by: Wang Qing 
Signed-off-by: Bartosz Golaszewski

gpiolib: Add GPIOCHIP_NAME definition

2019-12-12T10:36:13+00:00

The string literal "gpiochip" is used in several places.
Add a definition for it, and use it everywhere, to make sure everything
stays in sync.

Signed-off-by: Geert Uytterhoeven 
Link: https://lore.kernel.org/r/20191127084253.16356-2-geert+renesas@glider.be
Reviewed-by: Ulrich Hecht 
Reviewed-by: Eugeniu Rosca 
Signed-off-by: Linus Walleij

gpio: Use SPDX header for core library

2018-09-25T07:08:48+00:00

Use the SPDX headers and cut down on boilerplate to indicate the
license in the core gpiolib implementation.

Signed-off-by: Linus Walleij

gpio: Get rid of legacy header

2018-09-17T17:55:24+00:00

A bunch of core gpiolib files still include the 
legacy API header for no good reason. After this only the
gpiolib-legacy.c file includes it, which is fine.

The sysfs ABI code has a pointless wrapper function around
gpio_to_desc() we can just loose.

Signed-off-by: Linus Walleij