linux-toradex.git/drivers/gpio/gpiolib.c, branch v3.12-rc2

gpio: return -ENOTSUPP if debounce cannot be set

2013-09-04T12:22:47+00:00

It appears some drivers are using gpio_set_debounce()
opportunistically, i.e. without knowing whether it works or
not. (Example: input/keyboard/gpio_keys.c) to account for
this use case, return -ENOTSUPP and do not print any
warnings in this case.

Took a round over the other gpio_set_debounce() consumers
to make sure that none of them are relying on the returned
error code to be something specific.

Signed-off-by: Linus Walleij

gpio: improve error path in gpiolib

2013-09-03T12:08:28+00:00

At several places the gpiolib will proceed to handle a GPIO
descriptor even if it's ->chip member is NULL and no gpiochip
is associated.

Fix this by checking that both the descriptor cookie *and*
the chip pointer are valid.

Also bail out earlier with more specific diagnostic messages
on missing operations for setting as input/output or debounce.

ChangeLog v1->v2:
- Also return -EIO on gpiod_set_debounce() with missing
  operations in the vtable
- Fix indentations.

Suggested-by: Alexandre Courbot 
Acked-by: Alexandre Courbot 
Reviewed-by: Frank Rowand 
Cc: Tim Bird 
Signed-off-by: Linus Walleij

gpiolib: replace strict_strtol() with kstrtol()

2013-07-20T22:20:34+00:00

The usage of strict_strtol() is not preferred, because
strict_strtol() is obsolete. Thus, kstrtol() should be
used.

Signed-off-by: Jingoo Han 
Signed-off-by: Linus Walleij

gpiolib: remove warnning of allocations with IRQs disabled

2013-06-20T08:37:41+00:00

Move of_gpiochip_add outof spin_lock, since kzalloc inside
of_gpiochip_add -> of_gpiochip_add_pin_range -> gpiochip_add_pin_range -> kzalloc

WARNING: at kernel/lockdep.c:2740 lockdep_trace_alloc+0xf8/0xfc()
DEBUG_LOCKS_WARN_ON(irqs_disabled_flags(flags))

Signed-off-by: Zhangfei Gao 
Signed-off-by: Linus Walleij

gpiolib: move comment to right function

2013-03-02T13:20:20+00:00

This comment applies to gpio_to_chip(), not gpiod_to_chip().

Signed-off-by: Alexandre Courbot 
Signed-off-by: Grant Likely

gpiolib: use const parameters when possible

2013-03-02T13:20:19+00:00

Constify descriptor parameter of gpiod_* functions for those that
should obviously not modify it. This includes value or direction get,
cansleep, and IRQ number query.

Signed-off-by: Alexandre Courbot 
Signed-off-by: Grant Likely

gpiolib: check descriptors validity before use

2013-03-02T13:20:19+00:00

Some functions dereferenced their GPIO descriptor argument without
checking its validity first, potentially leading to an oops when given
an invalid argument.

This patch also makes gpio_get_value() more resilient when given an
invalid GPIO, returning 0 instead of silently crashing.

Signed-off-by: Alexandre Courbot 
Cc: Ryan Mallon 
Signed-off-by: Grant Likely

gpio: convert to idr_alloc()

2013-02-28T03:10:15+00:00

Convert to the much saner new idr interface.

Signed-off-by: Tejun Heo 
Acked-by: Linus Walleij 
Cc: Grant Likely 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Merge tag 'gpio-for-linus' of git://git.secretlab.ca/git/linux

2013-02-26T17:35:29+00:00

Pull GPIO changes from Grant Likely:
 "This branch contains the usual set of individual driver improvements
  and bug fixes, as well as updates to the core code.  The more notable
  changes include:

   - Internally add new API for referencing GPIOs by gpio_desc instead
     of number.  Eventually this will become a public API

   - ACPI GPIO binding support"

* tag 'gpio-for-linus' of git://git.secretlab.ca/git/linux: (33 commits)
  arm64: select ARCH_WANT_OPTIONAL_GPIOLIB
  gpio: em: Use irq_domain_add_simple() to fix runtime error
  gpio: using common order: let 'static const' instead of 'const static'
  gpio/vt8500: memory cleanup missing
  gpiolib: Fix locking on gpio debugfs files
  gpiolib: let gpio_chip reference its descriptors
  gpiolib: use descriptors internally
  gpiolib: use gpio_chips list in gpiochip_find_base
  gpiolib: use gpio_chips list in sysfs ops
  gpiolib: use gpio_chips list in gpiochip_find
  gpiolib: use gpio_chips list in gpiolib_sysfs_init
  gpiolib: link all gpio_chips using a list
  gpio/langwell: cleanup driver
  gpio/langwell: Add Cloverview ids to pci device table
  gpio/lynxpoint: add chipset gpio driver.
  gpiolib: add missing braces in gpio_direction_show
  gpiolib-acpi: Fix error checks in interrupt requesting
  gpio: mpc8xxx: don't set IRQ_TYPE_NONE when creating irq mapping
  gpiolib: remove gpiochip_reserve()
  arm: pxa: tosa: do not use gpiochip_reserve()
  ...

gpiolib: Fix locking on gpio debugfs files

2013-02-11T22:21:28+00:00

The debugfs files really need to hold the gpiolib spinlock before
accessing the list. Otherwise chip addition/removal will cause an oops.

Cc: Alexandre Courbot 
Cc: Linus Walleij 
Signed-off-by: Grant Likely