linux-toradex.git/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c, branch v5.6

drm/amdkfd: Eliminate unnecessary kernel queue function pointers

2019-12-05T21:24:36+00:00

Up to this point, those functions are all the same for all ASICs, so
no need to call them by functions pointers. Removing the function
pointers will greatly increase the code readablity. If there is ever
need for those function pointers, we can add it back then.

Signed-off-by: Yong Zhao 
Reviewed-by: Felix Kuehling 
Signed-off-by: Alex Deucher

drm/amdkfd: Avoid using doorbell_off as offset in process doorbell pages

2019-11-13T20:29:45+00:00

dorbell_off in the queue properties is mainly used for the doorbell dw
offset in pci bar. We should not set it to the doorbell byte offset in
process doorbell pages. This makes the code much easier to read.

Signed-off-by: Yong Zhao 
Reviewed-by: Felix Kuehling 
Signed-off-by: Alex Deucher

drm/amdkfd: Eliminate get_atc_vmid_pasid_mapping_valid

2019-10-03T14:11:04+00:00

get_atc_vmid_pasid_mapping_valid() is very similar to
get_atc_vmid_pasid_mapping_pasid(), so they can be merged into a new
function get_atc_vmid_pasid_mapping_info() to reduce register access
times. More importantly, getting the PASID and the valid bit atomically
with a single read fixes some potential race conditions where the
mapping changes between the two reads.

Signed-off-by: Yong Zhao 
Reviewed-by: Felix Kuehling 
Signed-off-by: Alex Deucher

drm/amdkfd: Use hex print format for pasid

2019-10-03T14:11:03+00:00

Since KFD pasid starts from 0x8000 (32768 in decimal), it is better
perceived as a hex number. Meanwhile, change the pasid type from
unsigned int to uint16_t to be consistent throughout the code.

Signed-off-by: Yong Zhao 
Reviewed-by: Felix Kuehling 
Signed-off-by: Alex Deucher

drm/amdkfd: Clean up reference of radeon

2018-07-12T02:33:08+00:00

Signed-off-by: Yong Zhao 
Reviewed-by: Felix Kuehling 
Signed-off-by: Felix Kuehling 
Acked-by: Christian König 
Signed-off-by: Oded Gabbay

drm/amdkfd: Hardware DWORD size is 4 bytes

2017-11-06T19:52:27+00:00

Don't use sizeof(uint32_t) or similar types for hardware or firmware
DWORD size. The hardware and firmware don't care about Linux types.

Signed-off-by: Felix Kuehling 
Reviewed-by: Alex Deucher 
Signed-off-by: Oded Gabbay

drm/amdkfd: Compress unnecessary function parameters

2017-09-27T04:09:53+00:00

Signed-off-by: Yong Zhao 
Reviewed-by: Oded Gabbay 
Signed-off-by: Oded Gabbay

drm/amdkfd: Use VMID bitmap from KGD v2

2017-09-20T22:10:18+00:00

The hard-coded values related to VMID were removed in KFD, as those
values can be calculated in the KFD initialization function.

v2: remove unnecessary local variable

Signed-off-by: Yong Zhao 
Signed-off-by: Felix Kuehling 
Reviewed-by: Oded Gabbay 
Signed-off-by: Oded Gabbay

drm/amdkfd: Handle remaining BUG_ONs more gracefully v2

2017-08-16T03:00:12+00:00

In most cases, BUG_ONs can be replaced with WARN_ON with an error
return. In some void functions just turn them into a WARN_ON and
possibly an early exit.

v2:
* Cleaned up error handling in pm_send_unmap_queue
* Removed redundant WARN_ON in kfd_process_destroy_delayed

Signed-off-by: Felix Kuehling 
Signed-off-by: Oded Gabbay

drm/amdkfd: Remove BUG_ONs for NULL pointer arguments

2017-08-16T03:00:09+00:00

Remove BUG_ONs that check for NULL pointer arguments that are
dereferenced in the same function. Dereferencing the NULL pointer
will generate a BUG anyway, so the explicit check is redundant and
unnecessary overhead.

Signed-off-by: Felix Kuehling 
Reviewed-by: Oded Gabbay 
Signed-off-by: Oded Gabbay