linux-toradex.git/drivers/gpu/drm/ast/ast_cursor.c, branch v6.17-rc6

drm/ast: Remove vaddr field from struct ast_plane

2025-04-07T13:08:48+00:00

The vaddr field in struct ast_plane serves no purpose. Its value
can be calculated easily from the VRAM base plus the plane offset.
Do so and remove the field.

In ast_primary_plane_helper_get_scanout_buffer(), remove the test
for vaddr being NULL. This cannot legally happen.

Signed-off-by: Thomas Zimmermann 
Reviewed-by: Jocelyn Falempe 
Link: https://lore.kernel.org/r/20250324094520.192974-3-tzimmermann@suse.de

drm/ast: cursor: Drop page alignment

2025-03-12T07:38:13+00:00

The cursor scanout address requires alignment to a multiple of 8,
but does not require page alignment. Change the offset calculation
accordingly. Frees up a few more bytes for the primary framebuffer.

Signed-off-by: Thomas Zimmermann 
Reviewed-by: Jocelyn Falempe 
Link: https://patchwork.freedesktop.org/patch/msgid/20250305163207.267650-8-tzimmermann@suse.de

drm/ast: Remove vram_fb_available from struct ast_device

2025-03-12T07:38:12+00:00

Helpers compute the offset and size of the available framebuffer
memory. Remove the obsolete field vram_fb_available from struct
ast_device. Also define the cursor-signature size next to its only
user.

v2:
- initialize plane size

Signed-off-by: Thomas Zimmermann 
Reviewed-by: Jocelyn Falempe 
Link: https://patchwork.freedesktop.org/patch/msgid/20250305163207.267650-7-tzimmermann@suse.de

drm/ast: cursor: Add helpers for computing location in video memory

2025-03-12T07:38:11+00:00

The ast drivers stores the cursor image at the end of the video memory.
Add helpers to calculate the offset and size.

Signed-off-by: Thomas Zimmermann 
Reviewed-by: Jocelyn Falempe 
Link: https://patchwork.freedesktop.org/patch/msgid/20250305163207.267650-5-tzimmermann@suse.de

drm/ast: cursor: Move implementation to separate source file

2025-02-20T07:38:34+00:00

Move the cursor code into a separate source file for readability. No
functional changes.

v2:
- include 

Signed-off-by: Thomas Zimmermann 
Reviewed-by: Jocelyn Falempe 
Link: https://patchwork.freedesktop.org/patch/msgid/20250217122336.230067-5-tzimmermann@suse.de

drm/ast: Inline ast cursor-update functions into modesetting code

2021-02-17T11:40:05+00:00

The logic for cursor updates is now located in the cursor plane's
modesetting code. A number of helper functions remain to modify the
rsp registers and image.

Signed-off-by: Thomas Zimmermann 
Acked-by: Gerd Hoffmann 
Link: https://patchwork.freedesktop.org/patch/msgid/20210209134632.12157-6-tzimmermann@suse.de

drm/ast: Allocate HW cursor BOs during cursor-plane initialization

2021-02-17T11:40:01+00:00

The BOs are eventually released by the cursor plane's destroy callback.

Signed-off-by: Thomas Zimmermann 
Acked-by: Gerd Hoffmann 
Link: https://patchwork.freedesktop.org/patch/msgid/20210209134632.12157-5-tzimmermann@suse.de

drm/ast: Add constants for VGACRCB register bits

2021-02-17T11:39:29+00:00

Set the bits in VGACRCB with constants. Alo move the rsp code into a
helper function.

Signed-off-by: Thomas Zimmermann 
Acked-by: Gerd Hoffmann 
Link: https://patchwork.freedesktop.org/patch/msgid/20210209134632.12157-2-tzimmermann@suse.de

drm/ast: Only map cursor BOs during updates

2020-12-11T11:35:32+00:00

The HW cursor's BO used to be mapped permanently into the kernel's
address space. GEM's vmap operation will be protected by locks, and
we don't want to lock the BO's for an indefinate period of time.

Change the cursor code to map the HW BOs only during updates. The
vmap operation in VRAM helpers is cheap, as a once estabished mapping
is being reused until the BO actually moves. As the HW cursor BOs are
permanently pinned, they never move at all.

v2:
	* fix typos in commit description

Signed-off-by: Thomas Zimmermann 
Acked-by: Christian König 
Acked-by: Daniel Vetter 
Link: https://patchwork.freedesktop.org/patch/msgid/20201209142527.26415-3-tzimmermann@suse.de

drm/ast: Don't pin cursor source BO explicitly during update

2020-12-11T11:35:25+00:00

Vmapping the cursor source BO contains an implicit pin operation,
so there's no need to do this manually.

Signed-off-by: Thomas Zimmermann 
Acked-by: Daniel Vetter 
Link: https://patchwork.freedesktop.org/patch/msgid/20201209142527.26415-2-tzimmermann@suse.de