linux-toradex.git/drivers/gpu/drm/ast/ast_fb.c, branch v4.5-rc3

drm: Pass the user drm_mode_fb_cmd2 as const to .fb_create()

2015-11-24T10:47:38+00:00

Drivers shouldn't clobber the passed in addfb ioctl parameters.
i915 was doing just that. To prevent it from happening again,
pass the struct around as const, starting all the way from
internal_framebuffer_create().

Signed-off-by: Ville Syrjälä 
Signed-off-by: Daniel Vetter

drm/ast: Initialized data needed to map fbdev memory

2015-11-11T02:27:31+00:00

Due to a missing initialization there was no way to map fbdev memory.
Thus for example using the Xserver with the fbdev driver failed.
This fix adds initialization for fix.smem_start and fix.smem_len
in the fb_info structure, which fixes this problem.

Requested-by: Benjamin Herrenschmidt 
Cc: stable@vger.kernel.org
Signed-off-by: Egbert Eich 
[pulled from SuSE tree by me - airlied]
Signed-off-by: Dave Airlie

drm/ast: Use new drm_fb_helper functions

2015-08-06T12:12:57+00:00

Use the newly created wrapper drm_fb_helper functions instead of calling
core fbdev functions directly. They also simplify the fb_info creation.

Cleaned up the error handling in astfb_create a bit.

v2:
- removed unused variable 'device' in astfb_create

Cc: David Airlie 
Cc: "Y.C. Chen" 
Cc: Alex Deucher 

Signed-off-by: Archit Taneja 
Signed-off-by: Daniel Vetter

drm/fb-helper: Propagate errors from initial config failure

2015-01-21T13:57:03+00:00

Make drm_fb_helper_initial_config() return an int rather than a bool so
that the error can be properly propagated. While at it, update drivers
to propagate errors further rather than just ignore them.

v2:
- cirrus: No cleanup is required, the top-level cirrus_driver_load()
  will do it as part of cirrus_driver_unload() in its cleanup path.
  Reported-by: Fengguang Wu 

Cc: David Airlie 
Cc: Daniel Vetter 
Cc: Patrik Jakobsson 
Cc: Rob Clark 
Cc: Tomi Valkeinen 
Cc: Alex Deucher 
Cc: Christian König 
Cc: Ben Skeggs 
Signed-off-by: Thierry Reding 
Reviewed-by: Alex Deucher 
Reviewed-by: Patrik Jakobsson 
Reviewed-by: Christian König 
[danvet: Squash in simplification patch from kbuild.]
Signed-off-by: Daniel Vetter

drm/ast: use container_of to resolve ast_fbdev from drm_fb_helper

2014-09-24T10:09:27+00:00

Use container_of instead of casting first structure member.

Signed-off-by: Fabian Frederick 
Signed-off-by: Daniel Vetter

drm: Introduce drm_fb_helper_prepare()

2014-07-08T01:31:28+00:00

To implement hotplug detection in a race-free manner, drivers must call
drm_kms_helper_poll_init() before hotplug events can be triggered. Such
events can be triggered right after any of the encoders or connectors
are initialized. At the same time, if the drm_fb_helper_hotplug_event()
helper is used by a driver, then the poll helper requires some parts of
the FB helper to be initialized to prevent a crash.

At the same time, drm_fb_helper_init() requires information that is not
necessarily available at such an early stage (number of CRTCs and
connectors), so it cannot be used yet.

Add a new helper, drm_fb_helper_prepare(), that initializes the bare
minimum needed to allow drm_kms_helper_poll_init() to execute and any
subsequent hotplug events to be processed properly.

Reviewed-by: Daniel Vetter 
Signed-off-by: Thierry Reding 
Signed-off-by: Dave Airlie

drm: Constify struct drm_fb_helper_funcs

2014-07-08T01:31:15+00:00

There's no need for this to be modifiable. Make it const so that it can
be put into the .rodata section.

Reviewed-by: Daniel Vetter 
Signed-off-by: Thierry Reding 
Acked-by: Russell King 
Signed-off-by: Dave Airlie

drm/mgag200,ast,cirrus: fix regression with drm_can_sleep conversion

2014-02-06T01:39:03+00:00

I totally sign inverted my way out of this one.

Cc: stable@vger.kernel.org
Reported-by: "Sabrina Dubroca" 
Signed-off-by: Dave Airlie

drm: ast,cirrus,mgag200: use drm_can_sleep

2014-01-29T00:51:52+00:00

these 3 were checking in_interrupt but we have situations where
calling vunmap under this could cause a BUG to be hit in
smp_call_function_many. Use the drm_can_sleep macro instead,
which should stop this path from been taken in this case.

Cc: stable@vger.kernel.org
Signed-off-by: Dave Airlie

drm/ast: do not attempt to acquire a reservation while in an interrupt handler

2013-06-28T01:56:39+00:00

Mutexes should not be acquired in interrupt context. While the trylock
fastpath is arguably safe on all implementations, the slowpath
unlock path definitely isn't.

Signed-off-by: Maarten Lankhorst 
Signed-off-by: Dave Airlie