linux-toradex.git/drivers/gpu/drm/bridge/analogix, branch v4.9.87

drm/bridge: analogix dp: Fix runtime PM state on driver bind

2017-03-30T07:41:28+00:00

commit f0a8b49c03d22a511a601dc54b2a3425a41e35fa upstream.

Analogix_dp_bind() can be called from component framework, which doesn't
guarantee proper runtime PM state of the device during bind operation,
so ensure that device is runtime active before doing any register access.
This ensures that the power domain, to which DP module belongs, is turned
on. While at it, also fix the unbalanced call to phy_power_on() in
analogix_dp_bind() function.

This patch solves the following kernel oops on Samsung Exynos5250 Snow
board:

Unhandled fault: imprecise external abort (0x406) at 0x00000000
pgd = c0004000
[00000000] *pgd=00000000
Internal error: : 406 [#1] PREEMPT SMP ARM
Modules linked in:
CPU: 0 PID: 75 Comm: kworker/0:2 Not tainted 4.9.0 #1046
Hardware name: SAMSUNG EXYNOS (Flattened Device Tree)
Workqueue: events deferred_probe_work_func
task: ee272300 task.stack: ee312000
PC is at analogix_dp_enable_sw_function+0x18/0x2c
LR is at analogix_dp_init_dp+0x2c/0x50
...
[] (analogix_dp_enable_sw_function) from [] (analogix_dp_init_dp+0x2c/0x50)
[] (analogix_dp_init_dp) from [] (analogix_dp_bind+0x184/0x42c)
[] (analogix_dp_bind) from [] (component_bind_all+0xf0/0x218)
[] (component_bind_all) from [] (exynos_drm_load+0x134/0x200)
[] (exynos_drm_load) from [] (drm_dev_register+0xa0/0xd0)
[] (drm_dev_register) from [] (drm_platform_init+0x58/0xb0)
[] (drm_platform_init) from [] (try_to_bring_up_master+0x14c/0x188)
[] (try_to_bring_up_master) from [] (component_add+0x88/0x138)
[] (component_add) from [] (platform_drv_probe+0x50/0xb0)
[] (platform_drv_probe) from [] (driver_probe_device+0x1f0/0x2a8)
[] (driver_probe_device) from [] (bus_for_each_drv+0x44/0x8c)
[] (bus_for_each_drv) from [] (__device_attach+0x9c/0x100)
[] (__device_attach) from [] (bus_probe_device+0x84/0x8c)
[] (bus_probe_device) from [] (deferred_probe_work_func+0x60/0x8c)
[] (deferred_probe_work_func) from [] (process_one_work+0x120/0x318)
[] (process_one_work) from [] (process_scheduled_works+0x28/0x38)
[] (process_scheduled_works) from [] (worker_thread+0x204/0x4ac)
[] (worker_thread) from [] (kthread+0xd8/0xf4)
[] (kthread) from [] (ret_from_fork+0x14/0x3c)
Code: e59035f0 e5935018 f57ff04f e3c55001 (f57ff04e)
---[ end trace 3d1d0d87796de344 ]---

Reviewed-by: Sean Paul 
Signed-off-by: Marek Szyprowski 
Signed-off-by: Archit Taneja 
Link: http://patchwork.freedesktop.org/patch/msgid/1483091866-1088-1-git-send-email-m.szyprowski@samsung.com
Cc: Javier Martinez Canillas 
Signed-off-by: Greg Kroah-Hartman

drm/bridge: Drop drm_connector_unregister and call drm_connector_cleanup directly

2016-10-10T09:19:42+00:00

Drop unneeded drm_connector_unregister() and remove the unnecessary
wrapper functions around drm_connector_cleanup().

Signed-off-by: Marek Vasut 
Cc: Daniel Vetter 
Signed-off-by: Daniel Vetter 
Link: http://patchwork.freedesktop.org/patch/msgid/20161005143133.5549-1-marex@denx.de

drm/bridge: analogix_dp: Add analogix_dp_psr_supported

2016-10-04T06:23:16+00:00

So users know whether PSR should be enabled or not.

Cc: Yakir Yang 

Reviewed-by: Sean Paul 
Signed-off-by: Tomeu Vizoso 
Signed-off-by: Archit Taneja 
Link: http://patchwork.freedesktop.org/patch/msgid/1474639600-30090-1-git-send-email-tomeu.vizoso@collabora.com

drm: bridge: analogix/dp: mark symbols static where possible

2016-09-25T20:59:02+00:00

We get 2 warnings when building kernel with W=1:
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1053:5: warning: no previous prototype for 'analogix_dp_get_modes' [-Wmissing-prototypes]
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1097:1: warning: no previous prototype for 'analogix_dp_detect' [-Wmissing-prototypes]

In fact, both functions are only used in the file in which they are
declared and don't need a declaration, but can be made static.
So this patch marks both functions with 'static'.

Signed-off-by: Baoyou Xie 
Signed-off-by: Daniel Vetter 
Link: http://patchwork.freedesktop.org/patch/msgid/1474788764-6069-1-git-send-email-baoyou.xie@linaro.org

drm/bridge: analogix_dp: Improve panel on time

2016-09-24T06:26:35+00:00

In order to reduce the time required to turn on the panel, this patch
makes 2 assumptions:
1- In detect(): if there's a panel, we're connected.
2- In get_modes(): if there's a panel, let the panel driver decide if
   it should prepare/unprepare in order to get the modes.

The first is straightforward, and shouldn't need further explanation. The
second should eliminate the prepare/unprepare delays from get_modes() in
most cases, since panels generally hardcode their modes in the driver as
opposed to reading EDID. If a panel does need to read EDID, it should be
responsible for ensuring it's in a state in which it can.

Signed-off-by: Sean Paul

drm/bridge: analogix_dp: Don't read EDID if panel present

2016-09-24T06:26:34+00:00

If there's a panel connected to the analogix_dp bridge, rely on
the panel driver for modes, rather than reading EDID *and* calling
get_modes() on the panel.

This allows panels with a valid EDID to read it in the panel driver
(e.g. simple_panel), and panels with invalid EDID to homebrew modes
in their get_modes implementation.

Signed-off-by: Sean Paul

drm/bridge: analogix_dp: Remove duplicated code

2016-09-24T06:26:34+00:00

Remove code for reading the EDID and DPCD fields and use the helpers
instead.

Besides the obvious code reduction, other helpers are being added to the
core that could be used in this driver and will be good to be able to
use them instead of duplicating them.

Signed-off-by: Tomeu Vizoso 
Tested-by: Javier Martinez Canillas 
Tested-by: Sean Paul 
Reviewed-by: Sean Paul 
Signed-off-by: Sean Paul 
Cc: Javier Martinez Canillas 
Cc: Mika Kahola 
Cc: Yakir Yang 
Cc: Daniel Vetter 
Cc: Archit Taneja

drm/bridge: analogix_dp: squash lines for simple wrapper functions

2016-09-15T14:41:39+00:00

Remove unneeded variables and assignments.

Reviewed-by: Gustavo Padovan 
Signed-off-by: Masahiro Yamada 
[seanpaul added analogix prefix to subject]
Signed-off-by: Sean Paul 
Link: http://patchwork.freedesktop.org/patch/msgid/1473863952-7658-4-git-send-email-yamada.masahiro@socionext.com

drm/bridge: analogix_dp: add the PSR function support

2016-08-23T15:44:33+00:00

The full name of PSR is Panel Self Refresh, panel device could refresh
itself with the hardware framebuffer in panel, this would make lots of
sense to save the power consumption.

This patch have exported two symbols for platform driver to implement
the PSR function in hardware side:
- analogix_dp_active_psr()
- analogix_dp_inactive_psr()

Reviewed-by: Archit Taneja 
Signed-off-by: Yakir Yang 
Signed-off-by: Sean Paul

drm/bridge: analogix_dp: Ensure the panel is properly prepared/unprepared

2016-08-23T15:44:31+00:00

Instead of just preparing the panel on bind, actually prepare/unprepare
during modeset/disable. The panel must be prepared in order to read hpd
status and edid, so we need to keep state around the prepares in order
to ensure we don't accidentally turn the panel off at the wrong time.

Reviewed-by: Yakir Yang 
Tested-by: Yakir Yang 
Reviewed-by: Archit Taneja 
Signed-off-by: Sean Paul