linux-toradex.git/drivers/gpu/drm/drm_bridge.c, branch v5.4

drm: Add atomic variants for bridge enable/disable

2019-06-13T17:00:29+00:00

This patch adds atomic variants for all of
pre_enable/enable/disable/post_disable bridge functions. These will be
called from the appropriate atomic helper functions. If the bridge
driver doesn't implement the atomic version of the function, we will
fall back to the vanilla implementation.

Note that some drivers call drm_bridge_disable directly, and these cases
are not covered. It's up to the driver to decide whether to implement
both atomic_disable and disable, or if it's not necessary.

Changes in v3:
- Added to the patchset
Changes in v4:
- Fix up docbook references (Daniel)
Changes in v5:
- None

Link to v3: https://patchwork.freedesktop.org/patch/msgid/20190502194956.218441-4-sean@poorly.run
Link to v4: https://patchwork.freedesktop.org/patch/msgid/20190508160920.144739-4-sean@poorly.run

Cc: Daniel Vetter 
Cc: Ville Syrjälä 
Tested-by: Heiko Stuebner 
Reviewed-by: Daniel Vetter 
Reviewed-by: Andrzej Hajda 
Signed-off-by: Sean Paul 
Link: https://patchwork.freedesktop.org/patch/msgid/20190611160844.257498-4-sean@poorly.run

drm: bridge: Constify mode arguments to bridge .mode_set() operation

2019-01-14T01:51:14+00:00

The mode and ajusted_mode passed to the bridge .mode_set() operation
should never be modified by the bridge (and are not in any of the
existing bridge drivers). Make them const to make this clear.

Signed-off-by: Laurent Pinchart 
Reviewed-by: Daniel Vetter

drm: bridge: document bridge attach/detach imbalance

2018-09-13T09:28:12+00:00

Since commit 4a878c03d562 ("drm: bridge: Detach bridge from encoder at
encoder cleanup time"), it is generally no longer correct to detach bridges
from encoders manually. Document that.

Signed-off-by: Peter Rosin 
Signed-off-by: Andrzej Hajda 
Link: https://patchwork.freedesktop.org/patch/msgid/20180806061910.29914-3-peda@axentia.se

drm/bridge: change return type of drm_bridge_add function

2017-08-21T03:21:53+00:00

This patch changes return type of drm_bridge_add function.

This function never return negative value but returns only 0.
So it changes the return type of this function to void one.

Signed-off-by: Inki Dae 
Signed-off-by: Archit Taneja 
Link: https://patchwork.freedesktop.org/patch/msgid/1499071350-25168-2-git-send-email-inki.dae@samsung.com

drm: Introduce drm_bridge_mode_valid()

2017-05-30T06:37:50+00:00

Introduce a new helper function which calls mode_valid() callback
for all bridges in an encoder chain.

Signed-off-by: Jose Abreu 
Reviewed-by: Daniel Vetter 
Cc: Carlos Palminha 
Cc: Ville Syrjälä 
Cc: Dave Airlie 
Cc: Andrzej Hajda 
Cc: Archit Taneja 
Cc: Laurent Pinchart 
Reviewed-by: Archit Taneja 
Signed-off-by: Daniel Vetter 
Link: http://patchwork.freedesktop.org/patch/msgid/36bd5e054496ad3c9c71f1ffe204f28533f55f1e.1495720737.git.joabreu@synopsys.com

drm/bridge: Use recommened kerneldoc for struct member refs

2017-01-02T08:17:26+00:00

I just learned that &struct_name.member_name works and looks pretty
even. It doesn't (yet) link to the member directly though, which would
be really good for big structures or vfunc tables (where the
per-member kerneldoc tends to be long).

Also some minor drive-by polish where it makes sense, I read a lot
of docs ...

Cc: Archit Taneja 
Cc: Jani Nikula 
Cc: Chris Wilson 
Reviewed-by: Archit Taneja 
[danvet: Remove spurious hunk that Archit spotted.]
Signed-off-by: Daniel Vetter 
Link: http://patchwork.freedesktop.org/patch/msgid/1483044517-5770-13-git-send-email-daniel.vetter@ffwll.ch

drm/doc: use preferred struct reference in kernel-doc

2016-12-30T12:34:59+00:00

sed -e 's/\( \* .*\)struct &\([_a-z]*\)/\1\&struct \2/' -i

Originally I wasnt a friend of this style because I thought a
line-break between the "&struct" and "foo" part would break it. But a
quick test shows that " * &struct \n * foo\n" works pefectly well with
current kernel-doc. So time to mass-apply these changes!

Cc: Jani Nikula 
Cc: Chris Wilson 
Reviewed-by: David Herrmann 
Signed-off-by: Daniel Vetter 
Link: http://patchwork.freedesktop.org/patch/msgid/1483044517-5770-6-git-send-email-daniel.vetter@ffwll.ch

drm: bridge: Detach bridge from encoder at encoder cleanup time

2016-12-18T11:02:49+00:00

Most drivers that use bridges forgot to detach them at cleanup time.
Instead of fixing them one by one, detach the bridge in the core
drm_encoder_cleanup() function.

Signed-off-by: Laurent Pinchart 
Reviewed-by: Daniel Vetter 
Signed-off-by: Archit Taneja 
Link: http://patchwork.freedesktop.org/patch/msgid/1481709550-29226-5-git-send-email-laurent.pinchart+renesas@ideasonboard.com

drm: bridge: Link encoder and bridge in core code

2016-12-18T11:01:45+00:00

Instead of linking encoders and bridges in every driver (and getting it
wrong half of the time, as many drivers forget to set the drm_bridge
encoder pointer), do so in core code. The drm_bridge_attach() function
needs the encoder and optional previous bridge to perform that task,
update all the callers.

Signed-off-by: Laurent Pinchart 
Acked-by: Stefan Agner  # For DCU
Acked-by: Boris Brezillon  # For atmel-hlcdc
Acked-by: Vincent Abriou  # For STI
Acked-by: Maxime Ripard  # For sun4i
Acked-by: Xinliang Liu  # For hisilicon
Acked-by: Jyri Sarha  # For tilcdc
Reviewed-by: Daniel Vetter 
Signed-off-by: Archit Taneja 
Link: http://patchwork.freedesktop.org/patch/msgid/1481709550-29226-4-git-send-email-laurent.pinchart+renesas@ideasonboard.com

drm: Extract drm_bridge.h

2016-09-19T13:04:15+00:00

We don't want to burry the bridge structures kerneldoc in drm_crtc.h.

Cc: Archit Taneja 
Reviewed-by: Archit Taneja 
Signed-off-by: Daniel Vetter 
Link: http://patchwork.freedesktop.org/patch/msgid/20160831160913.12991-3-daniel.vetter@ffwll.ch