linux-toradex.git/drivers/gpu/drm/drm_connector.c, branch v6.1-rc3

drm/connector: Set DDC pointer in drmm_connector_init

2022-10-20T08:53:13+00:00

Commit 35a3b82f1bdd ("drm/connector: Introduce drmm_connector_init")
introduced the function drmm_connector_init() with a parameter for an
optional ddc pointer to the i2c controller used to access the DDC bus.

However, the underlying call to __drm_connector_init() was always
setting it to NULL instead of passing the ddc argument around.

This resulted in unexpected null pointer dereference on platforms
expecting to get a DDC controller.

Fixes: 35a3b82f1bdd ("drm/connector: Introduce drmm_connector_init")
Reviewed-by: Thomas Zimmermann 
Link: https://lore.kernel.org/r/20221019143442.1798964-1-maxime@cerno.tech
Signed-off-by: Maxime Ripard

drm/connector: Introduce drmm_connector_init

2022-07-13T08:46:06+00:00

Unlike other DRM entities, there's no helper to create a DRM-managed
initialisation of a connector.

Let's create an helper to initialise a connector that would be passed as an
argument, and handle the cleanup through a DRM-managed action.

Acked-by: Sam Ravnborg 
Acked-by: Thomas Zimmermann 
Signed-off-by: Maxime Ripard 
Link: https://lore.kernel.org/r/20220711173939.1132294-10-maxime@cerno.tech

drm/connector: Check for destroy implementation

2022-07-13T08:46:06+00:00

Connectors need to be cleaned up with a call to drm_connector_cleanup()
in their drm_connector_funcs.destroy implementation.

Let's check for this and complain if there's no such function.

Acked-by: Thomas Zimmermann 
Signed-off-by: Maxime Ripard 
Link: https://lore.kernel.org/r/20220711173939.1132294-9-maxime@cerno.tech

drm/connector: Consolidate Connector Initialization

2022-07-13T08:46:06+00:00

We're going to add a DRM-managed connector initialization function.
Since we'll need both the with and without the DDC pointer, having a
single function that takes an optional pointer is easier to maintain.

Let's create a static function that will back both existing variants,
and will be reused by the DRM-managed variant.

Acked-by: Thomas Zimmermann 
Suggested-by: Thomas Zimmermann 
Signed-off-by: Maxime Ripard 
Link: https://lore.kernel.org/r/20220711173939.1132294-8-maxime@cerno.tech

drm/connector: Clarify when drm_connector_unregister is needed

2022-07-13T08:46:05+00:00

The current documentation for drm_connector_unregister() mentions that
it's needed for connectors that have been registered through
drm_dev_register().

However, this was a typo and was meant to be drm_connector_register(),
which only applies to connectors registered after drm_dev_register() has
been called.

In addition, it was also mentioning that connectors are unregistered
automatically when drm_dev_unregister() is called. This part is a bit
misleading, since it might make it appear that
drm_connector_unregister() applies either to all connectors, or none of
them.

After discussing it with Daniel, it appears that we always need to call
drm_connector_unregister() on connectors that have been registered with
drm_connector_register(), but only those.

drm_connector_init() already mentions that it only needs
drm_connector_cleanup(), so let's clarify the drm_connector_register()
and drm_connector_unregister() documentation to point at each other, and
remove the misleading part about drm_dev_unregister().

Acked-by: Sam Ravnborg 
Acked-by: Thomas Zimmermann 
Signed-off-by: Maxime Ripard 
Link: https://lore.kernel.org/r/20220711173939.1132294-7-maxime@cerno.tech

drm/connector: Mention the cleanup after drm_connector_init

2022-07-13T08:46:05+00:00

Unlike encoders and CRTCs, the drm_connector_init() and
drm_connector_init_with_ddc() don't mention how the cleanup is supposed to
be done. Let's add it.

Acked-by: Sam Ravnborg 
Acked-by: Thomas Zimmermann 
Signed-off-by: Maxime Ripard 
Link: https://lore.kernel.org/r/20220711173939.1132294-6-maxime@cerno.tech

drm/connector: Reorder headers

2022-07-13T08:46:05+00:00

Unlike most of the other files in DRM, and Linux in general, the headers in
drm_connector.c aren't sorted alphabetically. Let's fix that.

Acked-by: Sam Ravnborg 
Acked-by: Thomas Zimmermann 
Signed-off-by: Maxime Ripard 
Link: https://lore.kernel.org/r/20220711173939.1132294-5-maxime@cerno.tech

drm: Remove linux/fb.h from drm_crtc.h

2022-07-05T18:14:02+00:00

drm_crtc.h has no need for linux/fb.h, so don't include it.
Avoids useless rebuilds of the entire universe when
touching linux/fb.h.

Quite a few placs do currently depend on linux/fb.h or other
headers pulled in by it without actually including any of it
directly. All of those need to be fixed up.

v2: Split the vmwgfx change out

Acked-by: Sam Ravnborg 
Acked-by: Jani Nikula 
Signed-off-by: Ville Syrjälä 
Link: https://patchwork.freedesktop.org/patch/msgid/20220630195114.17407-3-ville.syrjala@linux.intel.com

drm/edid: move drm_connector_update_edid_property() to drm_edid.c

2022-06-30T07:50:50+00:00

The function needs access to drm_edid.c internals more than
drm_connector.c. We can make drm_reset_display_info(),
drm_add_display_info() and drm_update_tile_info() static. There will be
more benefits with follow-up struct drm_edid refactoring.

Signed-off-by: Jani Nikula 
Reviewed-by: Ville Syrjälä 
Link: https://patchwork.freedesktop.org/patch/msgid/cbabce6ffb41fdc903533f21d946e8cae0667be5.1656494768.git.jani.nikula@intel.com

drm/connector: Remove usage of the deprecated ida_simple_xxx API

2022-06-24T22:04:19+00:00

Use ida_alloc_xxx()/ida_free() instead of
ida_simple_get()/ida_simple_remove().
The latter is deprecated and more verbose.

Signed-off-by: Bo Liu 
Signed-off-by: Daniel Vetter 
Link: https://patchwork.freedesktop.org/patch/msgid/20220617082319.7599-1-liubo03@inspur.com
Link: https://patchwork.freedesktop.org/patch/msgid/20220621190055.8323-1-jiangjian@cdjrlc.com