linux-toradex.git/drivers/gpu/drm/drm_modes.c, branch v3.19.2

gpu:drm: Fix typo in Documentation/DocBook/drm.xml

2014-10-21T08:55:33+00:00

This patch fix spelling typos found in drm.xml.
It is because the file is generated from comments in
source codes, I have to fix the typos within source files.

Signed-off-by: Masanari Iida 
Acked-by: Randy Dunlap 
Signed-off-by: Daniel Vetter

drm: Perform cmdline mode parsing during connector initialisation

2014-08-06T12:50:12+00:00

i915.ko has a custom fbdev initialisation routine that aims to preserve
the current mode set by the BIOS, unless overruled by the user. The
user's wishes are determined by what, if any, mode is specified on the
command line (via the video= parameter). However, that command line mode
is first parsed by drm_fb_helper_initial_config() which is called after
i915.ko's custom initial_config() as a fallback method. So in order for
us to honour it, we need to move the cmdline parser earlier. If we
perform the connector cmdline parsing as soon as we initialise the
connector, that cmdline mode and forced status is then available even if
the fbdev helper is not compiled in or never called.

We also then expose the cmdline user mode in the connector mode lists.

v2: Rebase after connector->name upheaval.

v3: Adapt mga200 to look for the cmdline mode in the new place. Nicely
simplifies things while at that.

v4: Fix checkpatch.

v5: Select FB_CMDLINE to adapt to the changed fbdev patch.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=73154
Signed-off-by: Chris Wilson  (v2)
Cc: Jesse Barnes 
Cc: Ville Syrjälä 
Cc: Daniel Vetter 
Reviewed-by: Jesse Barnes  (v2)
Cc: dri-devel@lists.freedesktop.org
Cc: Julia Lemire 
Cc: Dave Airlie 
Signed-off-by: Daniel Vetter

drm: try harder to avoid regression when merging mode bits

2014-04-30T23:26:53+00:00

For QXL hw we really want the bits to be replaced as we change
the preferred mode on the fly, and the same goes for virgl when
I get to it, however the original fix for this seems to have caused
a wierd regression on Intel G33 that in a stunning display of failure
at opposition to his normal self, Daniel failed to diagnose.

So we are left doing this, ugly ugly ugly ugly, Daniel you fixed
that G33 yet?, ugly, ugly.

Tested-by: Marc-André Lureau 
Signed-off-by: Dave Airlie

drm: polish function kerneldoc for drm_modes.[hc]

2014-03-13T11:48:44+00:00

- Tune down yelling RETURNS.
- OCD align all the parameters the same.
- Add missing kerneldoc, which also means that we need to include the
  kerneldoc from the drm_modes.h header now.
- Add missing Returns: sections.
- General polish and clarification - especially the kerneldoc for the
  mode creation helpers seems to have been some good specimen of
  copypasta gone wrong.

All actual code changes have all been extracted into prep patches
since there was simply too much to polish.

v2: More polish for the command line modeline functions.

Reviewed-by: Alex Deucher 
Signed-off-by: Daniel Vetter

drm/modes: drop maxPitch from drm_mode_validate_size

2014-03-13T11:48:43+00:00

Totally unused and actually redundant with maxX for display mode
validation. The fb helper otoh needs to check pitch limits,
but that is delegated into drivers instead.

Reviewed-by: Alex Deucher 
Signed-off-by: Daniel Vetter

drm/modes: drop return value from drm_display_mode_from_videomode

2014-03-13T11:48:42+00:00

It never fails and no one ever checked anyway.

Reviewed-by: Alex Deucher 
Signed-off-by: Daniel Vetter

drm/modes: remove drm_mode_height/width

2014-03-13T11:48:41+00:00

There's a neat FIXME asking whether this is really need. I'd
say really no.

Reviewed-by: Alex Deucher 
Signed-off-by: Daniel Vetter

drm: extract drm_modes.h for drm_crtc.h functions

2014-03-13T11:48:41+00:00

I want to also include kerneldoc from the header (for static inline
functions and structs), but fishing the right pieces out of a giant
header is a real pain. So split things out.

Note that it's not a really clean header with sane include orders, but
given's drm historical knack for giant headers detangling this is a
major task.

v2: Also extract struct drm_cmdline_mode.

Reviewed-by: Alex Deucher 
Signed-off-by: Daniel Vetter

drm: move drm_mode related functions into drm_modes.c

2014-03-13T11:48:40+00:00

Makes more sense and gives better grouping in the DocBook function
reference sections. To make this possible we need to expose two
functions from drm_crtc.c though. To avoid further namespace pollution
in the system wide headers create a new internal header for such drm
internal symbols.

I expect that longer-term we'll add tons more, but since my goal here
is to polish the kerneldoc that's for another day.

Reviewed-by: Alex Deucher 
Signed-off-by: Daniel Vetter

drm/doc: Repleace LOCKING kerneldoc sections in drm_modes.c

2014-03-13T11:48:39+00:00

There's not really any value in stating that no locking is needed. And
even if the comment is useful, a check for the right mutex at the
beginning of the function is better since that can't be ingored as
easily as a bit of documentation.

Note that drm_mode_probed_add in drm_crtc.c is also changed, the next
patch will move this into drm_modes.c

v2: Don't add locking WARN_ONs where it is not strictly required (i.e.
the two functions to validate/prune mode lists).

Reviewed-by: Alex Deucher 
Signed-off-by: Daniel Vetter