linux-toradex.git/drivers/gpu/drm/hisilicon/hibmc/dp, branch master

drm/hisilicon/hibmc: Adding reset colorbar cfg in dp init.

2026-01-20T08:53:14+00:00

Add colorbar disable operation before reset chontroller, to make sure
colorbar status is clear in the DP init, so if rmmod the driver and the
previous colorbar configuration will not affect the next time insmod the
driver.

Fixes: 3c7623fb5bb6 ("drm/hisilicon/hibmc: Enable this hot plug detect of irq feature")
Signed-off-by: Baihan Li 
Signed-off-by: Yongbang Shi 
Reviewed-by: Dmitry Baryshkov 
Reviewed-by: Tao Tian 
Link: https://patch.msgid.link/20251210023759.3944834-5-shiyongbang@huawei.com
Signed-off-by: Dmitry Baryshkov

drm/hisilicon/hibmc: fix no showing problem with loading hibmc manually

2026-01-20T08:53:14+00:00

When using command rmmod and insmod, there is no showing in second time
insmoding. Because DP controller won't send HPD signals, if connection
doesn't change or controller isn't reset. So add reset before unreset
in hibmc_dp_hw_init().

And also need to move the HDCP cfg after DP controller de-resets, so
that HDCP configuration takes effect.

Fixes: 3c7623fb5bb6 ("drm/hisilicon/hibmc: Enable this hot plug detect of irq feature")
Signed-off-by: Baihan Li 
Signed-off-by: Yongbang Shi 
Reviewed-by: Dmitry Baryshkov 
Reviewed-by: Tao Tian 
Link: https://patch.msgid.link/20251210023759.3944834-4-shiyongbang@huawei.com
Signed-off-by: Dmitry Baryshkov

drm/hisilicon/hibmc: add dp mode valid check

2026-01-20T08:53:14+00:00

If DP is connected, check the DP BW in mode_valid_ctx() to ensure
that DP's link rate supports high-resolution data transmission.

Fixes: 0ab6ea261c1f ("drm/hisilicon/hibmc: add dp module in hibmc")
Signed-off-by: Baihan Li 
Signed-off-by: Yongbang Shi 
Reviewed-by: Dmitry Baryshkov 
Reviewed-by: Tao Tian 
Link: https://patch.msgid.link/20251210023759.3944834-3-shiyongbang@huawei.com
Signed-off-by: Dmitry Baryshkov

drm/hisilicon/hibmc: fix dp probabilistical detect errors after HPD irq

2026-01-20T08:53:14+00:00

The issue is that drm_connector_helper_detect_from_ddc() returns wrong
status when plugging or unplugging the monitor, which may cause the link
failed err.[0] Use HPD pin status in DP's detect_ctx() for real physical
monitor in/out, and implement a complete DP detection including read DPCD,
check if it's a branch device and its sink count for different situations.

[0]:
	hibme-drm 0000:83:00.0: [drm] *ERROR* channel equalization failed 5 times
	hibme-drm 0000:83:00.0: [drm] *ERROR* channel equalization failed 5 times
	hibme-drm 0000:83:00.0: [drm] *ERROR* dp link training failed, ret: -16
	hibmc-drm 0000:83:00.0: [drm] *ERROR* hibme dp mode set failed: -16

Fixes: 3c7623fb5bb6 ("drm/hisilicon/hibmc: Enable this hot plug detect of irq feature")
Signed-off-by: Baihan Li 
Signed-off-by: Yongbang Shi 
Reviewed-by: Tao Tian 
Link: https://patch.msgid.link/20251210023759.3944834-2-shiyongbang@huawei.com
Signed-off-by: Dmitry Baryshkov

drm/hisilicon/hibmc: fix rare monitors cannot display problem

2025-08-17T15:22:05+00:00

In some case, the dp link training success at 8.1Gbps, but the sink's
maximum supported rate is less than 8.1G. So change the default 8.1Gbps
link rate to the rate that reads from devices' capabilities.

Fixes: 54063d86e036 ("drm/hisilicon/hibmc: add dp link moduel in hibmc drivers")
Signed-off-by: Baihan Li 
Signed-off-by: Yongbang Shi 
Reviewed-by: Dmitry Baryshkov 
Link: https://lore.kernel.org/r/20250813094238.3722345-6-shiyongbang@huawei.com
Signed-off-by: Dmitry Baryshkov

drm/hisilicon/hibmc: Add MSI irq getting and requesting for HPD

2025-04-11T11:42:13+00:00

To realize HPD feature, request irq for HPD , add its handler function.
We use pci_alloc_irq_vectors() to get our msi irq, because we have two
interrupts now.

Signed-off-by: Baihan Li 
Signed-off-by: Yongbang Shi 
Reviewed-by: Dmitry Baryshkov 
Link: https://lore.kernel.org/r/20250331074212.3370287-9-shiyongbang@huawei.com
Signed-off-by: Dmitry Baryshkov

drm/hisilicon/hibmc: Enable this hot plug detect of irq feature

2025-04-11T11:42:13+00:00

Add HPD interrupt enable functions in drm framework, and also add
detect_ctx functions. Because of the debouncing when HPD pulled out,
add 200 ms delay in detect. Add link reset process to reset link status
when a new connector pulgged in.

Signed-off-by: Baihan Li 
Signed-off-by: Yongbang Shi 
Reviewed-by: Dmitry Baryshkov 
Link: https://lore.kernel.org/r/20250331074212.3370287-8-shiyongbang@huawei.com
Signed-off-by: Dmitry Baryshkov

drm/hisilicon/hibmc: Add colorbar-cfg feature and its debugfs file

2025-04-11T11:42:12+00:00

DP controller can support generating a color bar signal over the
DisplayPort interface. This can be useful to check for possible DDR
or GPU problems, as the signal generator resides completely in the DP
block. Add debugfs file that controls colorbar generator.

echo: config the color bar register to display
cat: print the color bar configuration

Signed-off-by: Baihan Li 
Signed-off-by: Yongbang Shi 
Reviewed-by: Dmitry Baryshkov 
Link: https://lore.kernel.org/r/20250331074212.3370287-7-shiyongbang@huawei.com
Signed-off-by: Dmitry Baryshkov

drm/hisilicon/hibmc: Getting connector info and EDID by using AUX channel

2025-04-11T11:42:12+00:00

Add registering drm_aux and use it to get connector edid with drm
functions. Add ddc channel in connector initialization to put drm_aux
in drm_connector.

Signed-off-by: Baihan Li 
Signed-off-by: Yongbang Shi 
Reviewed-by: Dmitry Baryshkov 
Link: https://lore.kernel.org/r/20250331074212.3370287-6-shiyongbang@huawei.com
Signed-off-by: Dmitry Baryshkov

drm/hisilicon/hibmc: Refactor the member of drm_aux in struct hibmc_dp

2025-04-11T11:42:12+00:00

Because the drm_aux of struct hibmc_dp_dev's member is not easy to get in
hibmc_drm_dp.c, move the drm_aux to struct hibmc_dp. Then there are some
adaptations and modifications to make this patch compile.

Signed-off-by: Baihan Li 
Signed-off-by: Yongbang Shi 
Reviewed-by: Dmitry Baryshkov 
Link: https://lore.kernel.org/r/20250331074212.3370287-5-shiyongbang@huawei.com
Signed-off-by: Dmitry Baryshkov