linux-toradex.git/drivers/gpu/drm/imx, branch v5.12

drm/imx: imx-ldb: fix out of bounds array access warning

2021-03-25T06:48:34+00:00

When CONFIG_OF is disabled, building with 'make W=1' produces warnings
about out of bounds array access:

drivers/gpu/drm/imx/imx-ldb.c: In function 'imx_ldb_set_clock.constprop':
drivers/gpu/drm/imx/imx-ldb.c:186:8: error: array subscript -22 is below array bounds of 'struct clk *[4]' [-Werror=array-bounds]

Add an error check before the index is used, which helps with the
warning, as well as any possible other error condition that may be
triggered at runtime.

The warning could be fixed by adding a Kconfig depedency on CONFIG_OF,
but Liu Ying points out that the driver may hit the out-of-bounds
problem at runtime anyway.

Signed-off-by: Arnd Bergmann 
Reviewed-by: Liu Ying 
Signed-off-by: Philipp Zabel

drm/imx: imx-ldb: Register LDB channel1 when it is the only channel to be used

2021-03-25T06:47:14+00:00

LDB channel1 should be registered if it is the only channel to be used.
Without this patch, imx_ldb_bind() would skip registering LDB channel1
if LDB channel0 is not used, no matter LDB channel1 needs to be used or
not.

Fixes: 8767f4711b2b (drm/imx: imx-ldb: move initialization into probe)
Signed-off-by: Liu Ying 
Signed-off-by: Philipp Zabel

drm/imx: fix memory leak when fails to init

2021-03-25T06:43:42+00:00

Put DRM device on initialization failure path rather than directly
return error code.

Fixes: a67d5088ceb8 ("drm/imx: drop explicit drm_mode_config_cleanup")
Signed-off-by: Pan Bian 
Signed-off-by: Philipp Zabel

drm/imx: dw_hdmi-imx: depend on OF to fix randconfig compile tests on x86_64

2021-01-07T10:54:21+00:00

The i.MX6 HDMI driver uses of_drm_find_bridge() and thus cannot be built
with CONFIG_OF disabled:

    ld: drivers/gpu/drm/imx/dw_hdmi-imx.o: in function `dw_hdmi_imx_probe':
    dw_hdmi-imx.c:(.text+0x29f): undefined reference to `of_drm_find_bridge'

Reported-by: Randy Dunlap 
Acked-by: Randy Dunlap  # build-tested
Fixes: c805ec7eb210 ("drm/imx: dw_hdmi-imx: move initialization into probe")
Signed-off-by: Philipp Zabel

drm/imx: ipuv3-crtc: use drm managed resources

2021-01-04T11:59:34+00:00

Use use drmm_crtc_alloc_with_planes() to align crtc memory lifetime
with the drm device. drm_crtc_cleanup() is called automatically before
the memory is freed.
Also use drmm_add_action_or_reset() to make sure IPU resources are
released automatically.

Signed-off-by: Philipp Zabel 
Acked-by: Daniel Vetter

drm/imx: ipuv3-plane: use drm managed resources

2021-01-04T11:59:34+00:00

Use drmm_universal_plane_alloc() to align plane memory lifetime with
the drm device. drm_plane_cleanup() is called automatically before the
memory is freed.
Also move the call to ipu_plane_get_resources() into ipu_plane_init()
and use drm managed resources to put IPU resources automatically when
required. Handle error return values of the plane property creation
functions.

Signed-off-by: Philipp Zabel 
Acked-by: Daniel Vetter

drm/imx: parallel-display: use drm managed resources

2021-01-04T11:59:34+00:00

Use drmm_simple_encoder_alloc() to align encoder memory lifetime with
the drm device. drm_encoder_cleanup() is called automatically before
the memory is freed.

Signed-off-by: Philipp Zabel 
Acked-by: Daniel Vetter

drm/imx: imx-tve: use drm managed resources

2021-01-04T11:59:33+00:00

Use drmm_simple_encoder_alloc() to align encoder memory lifetime with
the drm device. drm_encoder_cleanup() is called automatically before
the memory is freed.
Also fold imx_tve_register() into imx_tve_bind().

Signed-off-by: Philipp Zabel 
Acked-by: Daniel Vetter

drm/imx: imx-ldb: use drm managed resources

2021-01-04T11:59:33+00:00

Use drmm_simple_encoder_alloc() to align encoder memory lifetime with
the drm device. drm_encoder_cleanup() is called automatically before
the memory is freed.

Signed-off-by: Philipp Zabel 
Acked-by: Daniel Vetter

drm/imx: dw_hdmi-imx: use drm managed resources

2021-01-04T11:59:33+00:00

Use drmm_simple_encoder_alloc() to align encoder memory lifetime with
the drm device. drm_encoder_cleanup() is called automatically.

Signed-off-by: Philipp Zabel 
Acked-by: Daniel Vetter