linux-toradex.git/drivers/gpu/drm/msm/dsi/dsi.c, branch v4.11

drm/msm: Construct only one encoder for DSI

2017-02-06T16:28:43+00:00

We currently create 2 encoders for DSI interfaces, one for command
mode and other for video mode operation. This isn't needed as we
can't really use both the encoders at the same time. It also makes
connecting bridges harder.

Switch to creating a single encoder. For now, we assume that the
encoder is configured only in video mode. Later, the same encoder
would be usable in both modes.

Signed-off-by: Archit Taneja 
Signed-off-by: Rob Clark

drm/msm/dsi: Set msm_dsi->encoders before initializing bridge

2017-02-06T16:28:43+00:00

The commit "drm: bridge: Link encoder and bridge in core code" updated
the drm_bridge_attach() API to also include the drm_encoder pointer
the bridge attaches to.

The func msm_dsi_manager_bridge_init() now relies on the drm_encoder
pointer stored in msm_dsi->encoders to pass the encoder to the bridge
API.

msm_dsi->encoders is unfortunately set after this function is called,
resulting in us passing a NULL pointer to drm_brigde_attach. This
results in an error and the DSI driver probe fails.

Move the initialization of msm_dsi->encoders[] a bit up. Also, don't
try to set the encoder's bridge. That's now managed by the bridge
API.

Cc: Laurent Pinchart 
Reviewed-by: Laurent Pinchart 
Signed-off-by: Archit Taneja 
Signed-off-by: Rob Clark

drm/msm/dsi: Use generic PHY bindings

2016-07-16T14:08:47+00:00

The DSI host links to the DSI PHY device using a custom binding. Switch to
the generic PHY bindings. The DSI PHY driver itself doesn't use the common
PHY framework for now.

Signed-off-by: Archit Taneja 
Signed-off-by: Rob Clark

drm/msm/dsi: Allow dsi to connect to an external bridge

2015-08-15T22:27:25+00:00

There are platforms where the DSI output can be connected to another
encoder bridge chip (DSI to HDMI, DSI to LVDS etc).

Add support for external bridge support to the dsi driver. We assume that
the external bridge chip would be of the type drm_bridge. The dsi driver's
internal drm_bridge (msm_dsi->bridge) is linked to the external bridge's
drm_bridge struct.

In the case we're connected to an external bridge, we don't need to create
and manage a connector within our driver, it's the bridge driver's
responsibility to create one.

v2:
- Move the external bridge attaching stuff to dsi manager to make things
  cleaner.
- Force the bridge to connect to a video mode encoder for now (the dsi
  mode flags may have not been populated by modeset_init)

Signed-off-by: Archit Taneja 
Signed-off-by: Rob Clark

drm/msm/dsi: Create a helper to check if there is a connected device

2015-08-15T22:27:25+00:00

Create a helper msm_dsi_device_connected() which checks whether we have a
device connected to the dsi host or not. This check gets messy when we
have support external bridges too. Having an inline function makes it
more legible.

For now, the check only consists of msm_dsi->panel being non-NULL. Later,
this will check if we have an external bridge or not.

This helper isn't used in dsi_connector related code as that's specific
to only when a drm_panel is connected.

Signed-off-by: Archit Taneja 
Signed-off-by: Rob Clark

drm/msm/dsi: Refer to connected device as 'device' instead of 'panel'

2015-08-15T22:27:24+00:00

We currently support only panels connected to dsi output. We're going to
also support external bridge chips now.

Change 'panel_node' to 'device_node' in the struct msm_dsi_host and
'panel_flags' to 'device_flags' in msm_dsi. This makes things sound a
bit more generic.

Signed-off-by: Archit Taneja 
Signed-off-by: Rob Clark

drm/msm/dsi: One function call less in dsi_init() after error detection

2015-08-15T22:27:17+00:00

The dsi_destroy() function was called in two cases by the dsi_init() function
during error handling even if the passed variable contained a null pointer.

* This implementation detail could be improved by adjustments for jump
  targets according to the Linux coding style convention.

* Drop an unnecessary initialisation for the variable "msm_dsi" then.

Signed-off-by: Markus Elfring 
[add couple missing ERR_PTR()'s]
Signed-off-by: Rob Clark

drm/msm/dsi: Delete an unnecessary check before the function call "dsi_destroy"

2015-08-15T22:27:17+00:00

The dsi_destroy() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring 
Signed-off-by: Rob Clark

drm/msm/dsi: Separate PHY to another platform device

2015-06-11T17:11:05+00:00

There are different types of PHY from one chipset to another, while
the DSI host controller is relatively consistent across platforms.
Also, the PLL inside PHY is providing the source of DSI byte and
pixel clocks, which are used by DSI host controller. Separated devices
for clock provider and clock consumer make DSI driver better fit into
common clock framework.

Signed-off-by: Hai Li 
Signed-off-by: Rob Clark

drm/msm/dsi: Enable PLL driver in MSM DSI

2015-06-11T17:11:04+00:00

This change activates PLL driver for DSI to work with
common clock framework.

Signed-off-by: Hai Li 
Signed-off-by: Rob Clark