linux-toradex.git/drivers/gpu/drm/mxsfb, branch v5.0

drm: replace "drm_dev_unref" function with "drm_dev_put"

2018-11-24T21:12:54+00:00

This patch unifies the naming of DRM functions for reference counting as
requested on Documentation/gpu/todo.rst

Signed-off-by: Fernando Ramos 
Acked-by: Boris Brezillon 
Acked-by: Alexey Brodkin 
Acked-by: Stefan Agner 
Reviewed-by: Linus Walleij 
Signed-off-by: Linus Walleij 
Link: https://patchwork.freedesktop.org/patch/msgid/20181115221634.22715-4-greenfoo@gluegarage.com

drm/mxsfb: Switch to drm_atomic_helper_commit_tail_rpm

2018-09-26T20:07:40+00:00

The lcdif block is only powered on when display is active so plane
updates when not enabled are not valid. Writing to an unpowered IP block
is mostly ignored but can trigger bus errors on some chips.

Prevent this situation by switching to drm_atomic_helper_commit_tail_rpm
and having the drm core ensure atomic_plane_update is only called while
the crtc is active. This avoids having to keep track of "enabled" bits
inside the mxsfb driver.

This also requires handling the vblank event for disable from
mxsfb_pipe_disable.

Signed-off-by: Leonard Crestez 
Suggested-by: Stefan Agner 
Reviewed-by: Stefan Agner 
Reviewed-by: Sean Paul 
Signed-off-by: Stefan Agner 
Link: https://patchwork.freedesktop.org/patch/msgid/c19c0c00ed42e8e8f7965aa4821ac295abc5cd05.1537191359.git.leonard.crestez@nxp.com

drm/mxsfb: Add PM_SLEEP support

2018-09-26T20:07:40+00:00

Since power to the lcdif block can be lost on suspend implement
PM_SLEEP_OPS using drm_mode_config_helper_suspend/resume to save/restore
the current mode.

Signed-off-by: Leonard Crestez 
Reviewed-by: Stefan Agner 
Reviewed-by: Sean Paul 
Signed-off-by: Stefan Agner 
Link: https://patchwork.freedesktop.org/patch/msgid/cfa1a4083eefd112362e640deeb2e120584ac3f5.1537191359.git.leonard.crestez@nxp.com

drm/mxsfb: Add pm_runtime calls to pipe_enable/disable

2018-09-26T20:07:40+00:00

Adding lcdif nodes to a power domain currently results in
black/corrupted screens or hangs because power is not correctly enabled
when required.

Ensure power is on when display is active by adding
pm_runtime_get/put_sync to mxsfb_pipe_enable/disable.

Signed-off-by: Leonard Crestez 
Reviewed-by: Stefan Agner 
Reviewed-by: Sean Paul 
Signed-off-by: Stefan Agner 
Link: https://patchwork.freedesktop.org/patch/msgid/ee88148399c63494cda4129b05444b0ac331b7a7.1537191359.git.leonard.crestez@nxp.com

drm/mxsfb: Fix initial corrupt frame when activating display

2018-09-26T20:07:40+00:00

LCDIF will repeatedly display data from CUR_BUF and set CUR_BUF to
NEXT_BUF when done. Since we are only ever writing to NEXT_BUF the
display will show an initial corrupt frame.

Fix by writing the FB paddr to both CUR_BUF and NEXT_BUF when
activating the CRTC.

Signed-off-by: Leonard Crestez 
Tested-by: Philipp Zabel 
Reviewed-by: Stefan Agner 
Reviewed-by: Sean Paul 
Signed-off-by: Stefan Agner 
Link: https://patchwork.freedesktop.org/patch/msgid/7cdac9c064cc2b8a3d237934f186da98cefe6cb3.1537191359.git.leonard.crestez@nxp.com

drm/mxsfb: Move axi clk enable/disable to crtc enable/disable

2018-09-26T20:07:40+00:00

The main axi clk is disabled at the end of mxsfb_crtc_mode_set_nofb and
immediately reenabled in mxsfb_enable_controller.

Avoid this by moving the handling of axi clk one level up to
mxsfb_crtc_enable. Do the same for mxsfb_crtc_disable for symmetry.

This shouldn't have any functional effect.

Signed-off-by: Leonard Crestez 
Reviewed-by: Stefan Agner 
Reviewed-by: Sean Paul 
Signed-off-by: Stefan Agner 
Link: https://patchwork.freedesktop.org/patch/msgid/985c1f1cad250bd9ca154b3e4b3f913c310eeabd.1537191359.git.leonard.crestez@nxp.com

drm/mxsfb: Use simple_display_pipe prepare_fb helper

2018-04-24T11:58:43+00:00

Signed-off-by: Daniel Vetter 
Cc: Marek Vasut 
Reviewed-by: Eric Anholt 
Link: https://patchwork.freedesktop.org/patch/msgid/20180405154449.23038-6-daniel.vetter@ffwll.ch

drm/simple-kms-helper: Plumb plane state to the enable hook

2018-03-28T16:19:32+00:00

tinydrm enable hook wants to play around with the new fb in
.atomic_enable(), thus we'll need access to the plane state.

Performed with coccinelle:
@r1@
identifier F =~ ".*enable$";
identifier P, CS;
@@
F(
	struct drm_simple_display_pipe *P
	,struct drm_crtc_state *CS
+	,struct drm_plane_state *plane_state
	)
{
...
}

@@
struct drm_simple_display_pipe *P;
expression E;
@@
{
+ struct drm_plane *plane;
...
+ plane = &P->plane;
P->funcs->enable(P
		,E
+		,plane->state
	);
...
}

@@
identifier P, CS;
@@
struct drm_simple_display_pipe_funcs {
...
        void (*enable)(struct drm_simple_display_pipe *P
	     		,struct drm_crtc_state *CS
+			,struct drm_plane_state *plane_state
		);
...
};

v2: Pimp the commit message (David)

Cc: Marek Vasut 
Cc: Eric Anholt 
Cc: David Lechner 
Cc: "Noralf Trønnes" 
Cc: Linus Walleij 
Signed-off-by: Ville Syrjälä 
Link: https://patchwork.freedesktop.org/patch/msgid/20180322202738.25817-1-ville.syrjala@linux.intel.com
Reviewed-by: Noralf Trønnes

drm/mxsfb: Do not use deprecated drm_driver.{enable|disable)_vblank

2018-02-22T16:58:59+00:00

Do not use deprecated drm_driver.{enable|disable)_vblank callbacks,
but use drm_simple_kms_helpe's pipe callbacks instead.

Signed-off-by: Oleksandr Andrushchenko 
Cc: Marek Vasut 
Reviewed-by: Marek Vasut 
Signed-off-by: Daniel Vetter 
Link: https://patchwork.freedesktop.org/patch/msgid/1518425574-32671-3-git-send-email-andr2000@gmail.com

drm/mxsfb: Use drm_gem_fb_create() and drm_gem_fb_prepare_fb()

2017-10-01T15:02:20+00:00

drm_fb_cma_create() and drm_fb_cma_prepare_fb() are just wrappers now,
use drm_gem_fb_create() and drm_gem_fb_prepare_fb() directly.

Cc: Marek Vasut 
Signed-off-by: Noralf Trønnes 
Reviewed-by: Eric Anholt 
Link: https://patchwork.freedesktop.org/patch/msgid/1506255985-61113-6-git-send-email-noralf@tronnes.org