linux-toradex.git/drivers/gpu/drm/pl111, branch v4.14-rc7

drm/pl111: Use drm_gem_fb_create() and drm_gem_fb_prepare_fb()

2017-08-16T19:35:38+00:00

drm_fb_cma_create() and drm_fb_cma_prepare_fb() are just wrappers now,
use drm_gem_fb_create() and drm_gem_fb_prepare_fb() directly.

Cc: Eric Anholt 
Signed-off-by: Noralf Trønnes 
Reviewed-by: Eric Anholt 
Link: https://patchwork.freedesktop.org/patch/msgid/1502631125-13557-14-git-send-email-noralf@tronnes.org

drm: make drm_mode_config_func const

2017-08-09T16:39:34+00:00

Make these structures const as they are only stored in the funcs field
of a drm_mode_config structure which is of type const.
Done using Coccinelle:

@match disable optional_qualifier@
identifier s;
@@
static struct drm_mode_config_funcs s = {...};

@ref@
position p;
identifier match.s;
@@
s@p

@good1@
identifier y;
position ref.p;
identifier match.s;
@@
struct drm_mode_config y = {...,.funcs=&s@p,...};

@good2@
struct drm_mode_config y;
identifier match.s;
position ref.p;
@@
y.funcs = &s@p

@bad depends on  !good1 && !good2@
position ref.p;
identifier match.s;
@@
s@p

@depends on forall !bad disable optional_qualifier@
identifier match.s;
@@
static
+ const
struct drm_mode_config_funcs s;

Signed-off-by: Bhumika Goyal 
Signed-off-by: Daniel Vetter 
Link: https://patchwork.freedesktop.org/patch/msgid/1502204751-16525-1-git-send-email-bhumirks@gmail.com

drm: Nuke drm_atomic_helper_connector_dpms

2017-08-08T12:48:48+00:00

It's dead code, the core handles all this directly now.

The only special case is nouveau and tda988x which used one function
for both legacy modeset code and -nv50 atomic world instead of 2
vtables. But amounts to exactly the same.

v2: Rebase over the panel/brideg refactorings in stm/ltdc.

Signed-off-by: Daniel Vetter 
Cc: Archit Taneja 
Cc: Andrzej Hajda 
Cc: Laurent Pinchart 
Cc: Peter Senna Tschudin 
Cc: Martin Donnelly 
Cc: Martyn Welch 
Cc: Daniel Vetter 
Cc: Jani Nikula 
Cc: Sean Paul 
Cc: David Airlie 
Cc: Inki Dae 
Cc: Joonyoung Shim 
Cc: Seung-Woo Kim 
Cc: Kyungmin Park 
Cc: Kukjin Kim 
Cc: Krzysztof Kozlowski 
Cc: Stefan Agner 
Cc: Alison Wang 
Cc: Russell King 
Cc: Philipp Zabel 
Cc: CK Hu 
Cc: Matthias Brugger 
Cc: Neil Armstrong 
Cc: Carlo Caione 
Cc: Kevin Hilman 
Cc: Marek Vasut 
Cc: Ben Skeggs 
Cc: Tomi Valkeinen 
Cc: Eric Anholt 
Cc: Mark Yao 
Cc: Heiko Stuebner 
Cc: Benjamin Gaignard 
Cc: Vincent Abriou 
Cc: Yannick Fertre 
Cc: Philippe Cornu 
Cc: Maxime Ripard 
Cc: Chen-Yu Tsai 
Cc: Thierry Reding 
Cc: Jonathan Hunter 
Cc: Jyri Sarha 
Cc: Gerd Hoffmann 
Cc: Shawn Guo 
Cc: John Stultz 
Cc: Lars-Peter Clausen 
Cc: Sergei Shtylyov 
Cc: Jeffy Chen 
Cc: Tomeu Vizoso 
Cc: Yakir Yang 
Cc: Marek Szyprowski 
Cc: Jose Abreu 
Cc: Romain Perier 
Cc: Kieran Bingham 
Cc: Xinliang Liu 
Cc: Alexey Brodkin 
Cc: Alex Deucher 
Cc: Rongrong Zou 
Cc: Rob Clark 
Cc: Hai Li 
Cc: "Noralf Trønnes" 
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org
Cc: intel-gfx@lists.freedesktop.org
Cc: linux-mediatek@lists.infradead.org
Cc: linux-amlogic@lists.infradead.org
Cc: nouveau@lists.freedesktop.org
Cc: linux-renesas-soc@vger.kernel.org
Cc: linux-rockchip@lists.infradead.org
Cc: linux-tegra@vger.kernel.org
Cc: virtualization@lists.linux-foundation.org
Cc: zain wang 
Cc: Baoyou Xie 
Cc: Boris Brezillon 
Reviewed-by: Maarten Lankhorst 
Link: https://patchwork.freedesktop.org/patch/msgid/20170725080122.20548-8-daniel.vetter@ffwll.ch
Acked-by: Neil Armstrong 
Reviewed-by: Neil Armstrong 
Acked-by: Philipp Zabel 
Acked-by: Archit Taneja 
Tested-by: Philippe Cornu  (on stm)
Reviewed-by: Laurent Pinchart 
Acked-by: Shawn Guo 
Acked-by: Shawn Guo 
Acked-by: Noralf Trønnes 
Acked-by: Vincent Abriou

drm: Plumb modifiers through plane init

2017-08-01T16:50:06+00:00

This is the plumbing for supporting fb modifiers on planes. Modifiers
have already been introduced to some extent, but this series will extend
this to allow querying modifiers per plane. Based on this, the client to
enable optimal modifications for framebuffers.

This patch simply allows the DRM drivers to initialize their list of
supported modifiers upon initializing the plane.

v2: A minor addition from Daniel

v3:
* Updated commit message
* s/INVALID/DRM_FORMAT_MOD_INVALID (Liviu)
* Remove some excess newlines (Liviu)
* Update comment for > 64 modifiers (Liviu)

v4: Minor comment adjustments (Liviu)

v5: Some new platforms added due to rebase

v6: Add some missed plane inits (or maybe they're new - who knows at
this point) (Daniel)

Signed-off-by: Ben Widawsky 
Reviewed-by: Daniel Stone  (v2)
Reviewed-by: Liviu Dudau 
Signed-off-by: Daniel Stone

drm/pl111: Use .dumb_map_offset and .dumb_destroy defaults

2017-07-29T11:57:02+00:00

This driver can use the drm_driver.dumb_destroy and
drm_driver.dumb_map_offset defaults, so no need to set them.

Cc: Eric Anholt 
Signed-off-by: Noralf Trønnes 
Reviewed-by: Eric Anholt 
Link: https://patchwork.freedesktop.org/patch/msgid/1500837417-40580-13-git-send-email-noralf@tronnes.org

drm/pl111: Use gem_free_object_unlocked

2017-07-18T06:40:54+00:00

CMA helpers are struct_mutex free, and so is the pl111 itself. And
that's the only valid reason for using gem_free_object.

Signed-off-by: Daniel Vetter 
Cc: Eric Anholt 
Reviewed-by: Eric Anholt 
Link: https://patchwork.freedesktop.org/patch/msgid/20170717151045.4188-2-daniel.vetter@ffwll.ch

drm/pl111: Fix offset calculation for the primary plane.

2017-06-07T18:50:00+00:00

If src_x/y were nonzero, we failed to shift them down by 16 to get the
pixel offset.  The recent CMA helper function gets it right.

Signed-off-by: Eric Anholt 
Fixes: bed41005e617 ("drm/pl111: Initial drm/kms driver for pl111")
Reported-by: Mircea Carausu 
Link: http://patchwork.freedesktop.org/patch/msgid/20170603015733.13266-1-eric@anholt.net
Reviewed-by: Sean Paul

drm/pl111: fix warnings without CONFIG_ARM_AMBA

2017-05-31T17:50:36+00:00

The driver is written in a way to enable compile-testing without CONFIG_ARM_AMBA,
but it just causes needless warnings:

drivers/gpu/drm/pl111/pl111_drv.c:149:26: error: 'pl111_drm_driver' defined but not used [-Werror=unused-variable]
drivers/gpu/drm/pl111/pl111_drv.c:81:12: error: 'pl111_modeset_init' defined but not used [-Werror=unused-function]

This unhides the probe/remove functions again and just leaves the driver
object as unused when CONFIG_ARM_AMBA is disabled, with a __maybe_unused
annotation to shut up the warning.

Fixes: bed41005e617 ("drm/pl111: Initial drm/kms driver for pl111")
Signed-off-by: Arnd Bergmann 
Reviewed-by: Eric Anholt 
Link: http://patchwork.freedesktop.org/patch/msgid/20170524155020.1777369-1-arnd@arndb.de

drm/pl111: select DRM_PANEL

2017-05-31T07:32:32+00:00

When DRM_PANEL is disabled, we get a link error for pl111:

drivers/gpu/built-in.o: In function `pl111_connector_destroy':
pl111_connector.c:(.text+0x3487e6): undefined reference to `drm_panel_detach'

For some reason this only appears in the latest linux-next
although the driver appears to have used the symbol for a few
weeks already. The solution however is simple enough, we just
need to add a 'select' statement.

Fixes: bed41005e617 ("drm/pl111: Initial drm/kms driver for pl111")
Signed-off-by: Arnd Bergmann 
Tested-by: Linus Walleij 
Signed-off-by: Daniel Vetter 
Link: http://patchwork.freedesktop.org/patch/msgid/20170530092224.1204037-1-arnd@arndb.de

drm/pl111: Fix return value check in pl111_amba_probe()

2017-05-22T20:34:14+00:00

In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().

Fixes: bed41005e617 ("drm/pl111: Initial drm/kms driver for pl111")
Signed-off-by: Wei Yongjun 
Reviewed-by: Eric Anholt 
Link: http://patchwork.freedesktop.org/patch/msgid/20170521010152.6186-1-weiyj.lk@gmail.com