linux-toradex.git/drivers/gpu/drm/r128/r128_state.c, branch v4.4.126

drm: remove unnecessary sizeof(u8)

2014-11-20T01:30:37+00:00

sizeof(u8) is always 1.

Signed-off-by: Fabian Frederick 
Signed-off-by: Dave Airlie

drm: Remove DRM_ARRAY_SIZE() for ARRAY_SIZE()

2014-06-09T23:36:17+00:00

I cannot see a need to provide a DRM_ version of ARRAY_SIZE(), only used
in a few places. I suspect its usage has been spread by copy & paste
rather than anything else.

Let's just remove it for plain ARRAY_SIZE().

Signed-off-by: Damien Lespiau 
Reviewed-by: Alex Deucher 
Signed-off-by: Dave Airlie

drm: remove drm_dev_to_irq from drivers

2014-04-22T09:41:12+00:00

Only used in some legacy pci drivers, and dereferencing the PCI irq is
actually shorter ...

Since this removes all users for drm_dev_to_irq from the tree except
in drm_irq.c, move the inline helper in there. It'll disappear soon,
too.

v2: Polish commit message (Thierry)

Reviewed-by: Thierry Reding 
Reviewed-by: Laurent Pinchart 
Signed-off-by: Daniel Vetter

drm: use memdup_user() as a cleanup

2013-12-18T01:44:01+00:00

drivers/gpu/drm/r128/r128_state.c:1014:10-17: WARNING opportunity for memdup_user
/c/kernel-tests/src/cocci/drivers/gpu/drm/r128/r128_state.c:1029:9-16: WARNING opportunity for memdup_user
/c/kernel-tests/src/cocci/drivers/gpu/drm/r128/r128_state.c:904:10-17: WARNING opportunity for memdup_user
/c/kernel-tests/src/cocci/drivers/gpu/drm/r128/r128_state.c:914:9-16: WARNING opportunity for memdup_user

 Use memdup_user rather than duplicating its implementation
 This is a little bit restricted to reduce false positives

Generated by: coccinelle/api/memdup_user.cocci

CC: Daniel Vetter 
Signed-off-by: Dan Carpenter 
Signed-off-by: Daniel Vetter 
Signed-off-by: Dave Airlie

drm: Kill DRM_COPY_(TO|FROM)_USER

2013-12-18T01:35:01+00:00

Less yelling ftw!

Signed-off-by: Daniel Vetter 
Signed-off-by: Dave Airlie

drm: const'ify ioctls table (v2)

2013-08-07T00:10:02+00:00

Because, there is no reason for it not to be const.

v1: original
v2: fix compile break in vmwgfx, and couple related cleanups suggested
    by Ville Syrjälä

Signed-off-by: Rob Clark 
Reviewed-by: Ville Syrjälä 
Reviewed-by: Alex Deucher 
Signed-off-by: Dave Airlie

UAPI: (Scripted) Convert #include "..." to #include in drivers/gpu/

2012-10-02T17:01:07+00:00

Convert #include "..." to #include  in drivers/gpu/.

Signed-off-by: David Howells 
Acked-by: Dave Airlie 
Acked-by: Arnd Bergmann 
Acked-by: Thomas Gleixner 
Acked-by: Paul E. McKenney 
Acked-by: Dave Jones

UAPI: (Scripted) Remove redundant DRM UAPI header #inclusions from drivers/gpu/.

2012-10-02T17:01:05+00:00

Remove redundant DRM UAPI header #inclusions from drivers/gpu/.

Remove redundant #inclusions of core DRM UAPI headers (drm.h, drm_mode.h and
drm_sarea.h).  They are now #included via drmP.h and drm_crtc.h via a preceding
patch.

Without this patch and the patch to make include the UAPI headers from the core
headers, after the UAPI split, the DRM C sources cannot find these UAPI headers
because the DRM code relies on specific -I flags to make #include "..."  work
on headers in include/drm/ - but that does not work after the UAPI split without
adding more -I flags.

Signed-off-by: David Howells 
Acked-by: Dave Airlie 
Acked-by: Arnd Bergmann 
Acked-by: Thomas Gleixner 
Acked-by: Paul E. McKenney 
Acked-by: Dave Jones

drm: block userspace under allocating buffer and having drivers overwrite it (v2)

2010-08-17T04:52:25+00:00

With the current screwed but its ABI, ioctls for the drm, Linus pointed out that we could allow userspace to specify the allocation size, but we pass it to the driver which then uses it blindly to store a struct. Now if userspace specifies the allocation size as smaller than the driver needs, the driver can possibly overwrite memory.

This patch restructures the driver ioctls so we store the structure size we are expecting, and make sure we allocate at least that size. The copy from/to userspace are still restricted to the size the user specifies, this allows ioctl structs to grow on both sides of the equation.

Up until now we didn't really use the DRM_IOCTL defines in the kernel, so this cleans them up and adds them for nouveau.

v2:
fix nouveau pushbuf arg (thanks to Ben for pointing it out)

Reported-by: Linus Torvalds 
Signed-off-by: Dave Airlie

drm/r128: fixed brace and spacing coding style issues

2010-08-02T00:17:48+00:00

Fixed brace and spacing coding style issues.

Signed-off-by: Nicolas Kaiser 
Signed-off-by: Dave Airlie