linux-toradex.git/drivers/gpu/drm/tegra/gem.c, branch v3.19

drm/tegra: gem: Use the proper size for GEM objects

2014-12-17T13:27:38+00:00

If the requested buffer size wasn't a multiple of the page size, the
IOMMU code would round down the size to the next multiple of the page
size, thereby causing translation errors. To fix this we no longer pass
around the requested size but reuse the computed size of the GEM object.
This is already rounded to the next page boundary, so mapping that size
works out fine.

Signed-off-by: Thierry Reding

drm/tegra: gem: Flush buffer objects upon allocation

2014-12-17T13:27:37+00:00

Buffers obtained via shmem may still have associated cachelines. If they
aren't properly flushed they may cause framebuffer corruption if the
cache gets flushed after the application has drawn to it.

Signed-off-by: Thierry Reding

drm/tegra: gem: Check before freeing CMA memory

2014-11-13T15:18:34+00:00

dma_free_writecombine() must not be called on a buffer that couldn't be
allocated. Check for a valid virtual address before attempting to free
the memory to avoid a crash.

Reported-by: Sean Paul 
Reviewed-by: Sean Paul 
Signed-off-by: Thierry Reding

drm/tegra: gem: Use more consistent data types

2014-11-13T15:18:32+00:00

Use size_t consistently for sizes and u32/u64 instead of uint32_t and
uint64_t.

Signed-off-by: Thierry Reding

drm/tegra: gem: dumb: pitch and size are outputs

2014-11-13T15:18:31+00:00

When creating a dumb buffer object using the DRM_IOCTL_MODE_CREATE_DUMB
IOCTL, only the width, height, bpp and flags parameters are inputs. The
caller is not guaranteed to zero out or set handle, pitch and size, so
the driver must not treat these values as possible inputs.

Fixes a bug where running the Weston compositor on Tegra DRM would cause
an attempt to allocate a 3 GiB framebuffer to be allocated.

Fixes: de2ba664c30f ("gpu: host1x: drm: Add memory manager and fb")
Cc: stable@vger.kernel.org
Signed-off-by: Thierry Reding

drm/tegra: Add IOMMU support

2014-11-13T15:14:48+00:00

When an IOMMU device is available on the platform bus, allocate an IOMMU
domain and attach the display controllers to it. The display controllers
can then scan out non-contiguous buffers by mapping them through the
IOMMU.

Signed-off-by: Thierry Reding

drm/tegra: gem: Use dma_mmap_writecombine()

2014-11-13T15:14:48+00:00

Use the existing API rather than open-coding equivalent functionality
in the driver.

Signed-off-by: Thierry Reding

drm/tegra: gem: Remove redundant drm_gem_free_mmap_offset()

2014-11-13T15:14:47+00:00

The drm_gem_object_release() function already performs this cleanup, so
there is no reason to do it explicitly.

Signed-off-by: Thierry Reding

drm/tegra: gem: Cleanup tegra_bo_create_with_handle()

2014-11-13T15:14:47+00:00

There is only a single location where the function needs to do cleanup.
Skip the error unwinding path and call the cleanup function directly
instead.

Signed-off-by: Thierry Reding

drm/tegra: gem: Extract tegra_bo_alloc_object()

2014-11-13T15:14:46+00:00

This function implements the common buffer object allocation used for
both allocation and import paths.

Signed-off-by: Thierry Reding