linux-toradex.git/drivers/gpu/drm/tinydrm, branch master

drm/tinydrm: Rename folder to tiny

2019-07-31T13:16:10+00:00

The drm in tinydrm is superfluous so rename to tiny.

Suggested-by: Daniel Vetter 
Signed-off-by: Noralf Trønnes 
Acked-by: Daniel Vetter 
Acked-by: Sam Ravnborg 
Reviewed-by: Hans de Goede 
Link: https://patchwork.freedesktop.org/patch/msgid/20190725105132.22545-3-noralf@tronnes.org

drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM

2019-07-31T13:15:02+00:00

This makes the tiny drivers visible by default without having to enable a
knob.

Signed-off-by: Noralf Trønnes 
Acked-by: Daniel Vetter 
Acked-by: Sam Ravnborg 
Reviewed-by: Hans de Goede  to it once
Link: https://patchwork.freedesktop.org/patch/msgid/20190725105132.22545-2-noralf@tronnes.org

drm/tinydrm: Move mipi-dbi

2019-07-25T08:45:07+00:00

This moves mipi-dbi to be a core helper with the name drm_mipi_dbi.

Fixup include's in drivers.
Move the docs entry and delete tinydrm.rst.
Delete the last tinydrm todo entry.

v2: Make DRM_MIPI_DBI tristate to enable it being built as a module.

Cc: Eric Anholt 
Cc: David Lechner 
Reviewed-by: Sam Ravnborg 
Signed-off-by: Noralf Trønnes 
Acked-by: David Lechner 
Acked-by: Eric Anholt 
Link: https://patchwork.freedesktop.org/patch/msgid/20190722104312.16184-9-noralf@tronnes.org

drm/tinydrm/mipi-dbi: Select DRM_KMS_HELPER

2019-07-25T08:44:20+00:00

mipi-dbi uses several KMS helper functions but that build dependency is
not expressed. Select DRM_KMS_HELPER to fix that.

Reported-by: kbuild test robot 
Signed-off-by: Noralf Trønnes 
Reviewed-by: David Lechner 
Link: https://patchwork.freedesktop.org/patch/msgid/20190722104312.16184-8-noralf@tronnes.org

drm/tinydrm/Kconfig: drivers: Select BACKLIGHT_CLASS_DEVICE

2019-07-25T08:44:03+00:00

The mipi_dbi helper is missing a dependency on DRM_KMS_HELPER and putting
that in revealed this problem:

drivers/video/fbdev/Kconfig:12:error: recursive dependency detected!
drivers/video/fbdev/Kconfig:12: symbol FB is selected by DRM_KMS_FB_HELPER
drivers/gpu/drm/Kconfig:75: symbol DRM_KMS_FB_HELPER depends on DRM_KMS_HELPER
drivers/gpu/drm/Kconfig:69: symbol DRM_KMS_HELPER is selected by TINYDRM_MIPI_DBI
drivers/gpu/drm/tinydrm/Kconfig:11: symbol TINYDRM_MIPI_DBI is selected by TINYDRM_HX8357D
drivers/gpu/drm/tinydrm/Kconfig:15: symbol TINYDRM_HX8357D depends on BACKLIGHT_CLASS_DEVICE
drivers/video/backlight/Kconfig:144: symbol BACKLIGHT_CLASS_DEVICE is selected by FB_BACKLIGHT
drivers/video/fbdev/Kconfig:187: symbol FB_BACKLIGHT depends on FB

A symbol that selects DRM_KMS_HELPER can not depend on
BACKLIGHT_CLASS_DEVICE. The reason for this is that DRM_KMS_FB_HELPER
selects FB instead of depending on it.

The tinydrm drivers have somehow gotten away with depending on
BACKLIGHT_CLASS_DEVICE because DRM_TINYDRM selects DRM_KMS_HELPER and the
drivers depend on that symbol.

An audit shows that all DRM drivers that select DRM_KMS_HELPER and use
BACKLIGHT_CLASS_DEVICE, selects it:
DRM_TILCDC, DRM_GMA500, DRM_SHMOBILE, DRM_NOUVEAU, DRM_FSL_DCU,
DRM_I915, DRM_RADEON, DRM_AMDGPU, DRM_PARADE_PS8622

Documentation/kbuild/kconfig-language.txt has a note regarding select:
1. 'select should be used with care since it doesn't visit dependencies.'
This is not a problem since BACKLIGHT_CLASS_DEVICE doesn't have any
dependencies.
2. 'In general use select only for non-visible symbols'
BACKLIGHT_CLASS_DEVICE is user visible.

The real solution to this would be to have DRM_KMS_FB_HELPER depend on the
user visible symbol FB. That is a can of worms I'm not willing to tackle.
I fear that such a change will result in me handling difficult fallouts
for the next weeks. So I'm following DRM suite here.

Signed-off-by: Noralf Trønnes
Reviewed-by: David Lechner
Link: https://patchwork.freedesktop.org/patch/msgid/20190722104312.16184-7-noralf@tronnes.org

drm/tinydrm/mipi-dbi: Remove CMA helper dependency

2019-07-25T08:43:38+00:00

mipi-dbi depends on the CMA helper through its use of
drm_fb_cma_get_gem_obj(). This is an unnecessary dependency to drag in for
drivers that only want to use the MIPI DBI interface part.
Avoid this by open coding the function.

Signed-off-by: Noralf Trønnes 
Reviewed-by: David Lechner 
Link: https://patchwork.freedesktop.org/patch/msgid/20190722104312.16184-6-noralf@tronnes.org

drm/tinydrm: Split struct mipi_dbi in two

2019-07-25T08:42:25+00:00

Split struct mipi_dbi into an interface part and a display pipeline part.
The interface part can be used by drivers that need to initialize the
controller, but that won't upload the framebuffer over this interface.

MIPI DBI supports 3 interface types:
- A. Motorola 6800 type parallel bus
- B. Intel 8080 type parallel bus
- C. SPI type with 3 options:

I've embedded the SPI type specifics in the mipi_dbi struct to avoid
adding unnecessary complexity. If more interface types will be supported
in the future, the type specifics might have to be split out.

Rename functions to match the new struct mipi_dbi_dev:
- drm_to_mipi_dbi() -> drm_to_mipi_dbi_dev().
- mipi_dbi_init*() -> mipi_dbi_dev_init*().

Cc: Eric Anholt 
Cc: David Lechner 
Reviewed-by: Sam Ravnborg 
Signed-off-by: Noralf Trønnes 
Acked-by: David Lechner 
Acked-by: Eric Anholt 
Link: https://patchwork.freedesktop.org/patch/msgid/20190722104312.16184-5-noralf@tronnes.org

drm/tinydrm: Rename remaining variable mipi -> dbidev

2019-07-25T08:41:10+00:00

struct mipi_dbi is going to be split into an interface part and a display
pipeline part. The interface part can be used by drivers that need to
initialize the controller, but that won't upload the framebuffer over
this interface.

tinydrm uses the variable name 'mipi' but this is not a good name since
MIPI refers to a lot of standards. This patch changes the variable name
to 'dbidev' where it refers to the pipeline part of struct mipi_dbi.

Cc: Eric Anholt 
Cc: David Lechner 
Reviewed-by: Sam Ravnborg 
Signed-off-by: Noralf Trønnes 
Acked-by: David Lechner 
Acked-by: Eric Anholt 
Link: https://patchwork.freedesktop.org/patch/msgid/20190722104312.16184-4-noralf@tronnes.org

drm/tinydrm: Rename variable mipi -> dbi

2019-07-25T08:40:01+00:00

struct mipi_dbi is going to be split into an interface part and a display
pipeline part. The interface part can be used by drivers that need to
initialize the controller, but that won't upload the framebuffer over
this interface.

tinydrm uses the variable name 'mipi' but this is not a good name since
MIPI refers to a lot of standards. This patch changes the variable name
to 'dbi' where it refers to the interface part of struct mipi_dbi.

Functions that use both future parts will have both variables temporarily
pointing to the same structure.

Cc: Eric Anholt 
Cc: David Lechner 
Reviewed-by: Sam Ravnborg 
Signed-off-by: Noralf Trønnes 
Acked-by: David Lechner 
Acked-by: Eric Anholt 
Link: https://patchwork.freedesktop.org/patch/msgid/20190722104312.16184-3-noralf@tronnes.org

drm/tinydrm/mipi-dbi: Move cmdlock mutex init

2019-07-25T08:38:50+00:00

cmdlock protects command execution so put it in mipi_dbi_spi_init()
where it conceptually belongs.
This is prep work for the splitting of struct mipi_dbi.

Reviewed-by: Sam Ravnborg 
Acked-by: Eric Anholt 
Signed-off-by: Noralf Trønnes 
Link: https://patchwork.freedesktop.org/patch/msgid/20190722104312.16184-2-noralf@tronnes.org