linux-toradex.git/drivers/gpu/vga, branch v4.4.93

vgaarb: fix signal handling in vga_get()

2015-12-11T04:04:44+00:00

There are few defects in vga_get() related to signal hadning:

  - we shouldn't check for pending signals for TASK_UNINTERRUPTIBLE
    case;

  - if we found pending signal we must remove ourself from wait queue
    and change task state back to running;

  - -ERESTARTSYS is more appropriate, I guess.

Signed-off-by: Kirill A. Shutemov 
Cc: stable@vger.kernel.org
Reviewed-by: David Herrmann 
Signed-off-by: Dave Airlie

vga_switcheroo: Drop client power state VGA_SWITCHEROO_INIT

2015-11-05T01:07:36+00:00

hda_intel.c:azx_probe() defers initialization of an audio controller
on the discrete GPU if the GPU is powered off. The power state of the
GPU is determined by calling vga_switcheroo_get_client_state().

vga_switcheroo_get_client_state() returns VGA_SWITCHEROO_INIT if
vga_switcheroo is not enabled, i.e. if no second GPU or no handler
has registered.

This can go wrong in the following scenario:
- Driver for the integrated GPU is not loaded.
- Driver for the discrete GPU registers with vga_switcheroo, uses driver
  power control to power down the GPU, handler cuts power to the GPU.
- Driver for the audio controller gets loaded after the GPU was powered
  down, calls vga_switcheroo_get_client_state() which returns
  VGA_SWITCHEROO_INIT instead of VGA_SWITCHEROO_OFF.
- Consequence: azx_probe() tries to initialize the audio controller even
  though the GPU is powered down.

The power state VGA_SWITCHEROO_INIT was introduced by c8e9cf7bb240
("vga_switcheroo: Add a helper function to get the client state").
It is not apparent what its benefit might be. The idea seems to
be to initialize the audio controller even if the power state is
VGA_SWITCHEROO_OFF (were vga_switcheroo enabled), but as shown
above this can fail.

Drop VGA_SWITCHEROO_INIT to solve this.

Acked-by: Takashi Iwai 
Signed-off-by: Lukas Wunner 
Signed-off-by: Dave Airlie

vga_switcheroo: Constify vga_switcheroo_handler

2015-10-20T18:19:29+00:00

vga_switcheroo_client_ops has always been declared const since its
introduction with 26ec685ff9d9 ("vga_switcheroo: Introduce struct
vga_switcheroo_client_ops").

Do so for vga_switcheroo_handler as well.

 drivers/gpu/drm/amd/amdgpu/amdgpu.ko:
   6 .rodata       00009888
- 19 .data         00001f00
+ 19 .data         00001ee0
 drivers/gpu/drm/nouveau/nouveau.ko:
   6 .rodata       000460b8
  17 .data         00018fe0
 drivers/gpu/drm/radeon/radeon.ko:
-  7 .rodata       00030944
+  7 .rodata       00030964
- 21 .data         0000d6a0
+ 21 .data         0000d678
 drivers/platform/x86/apple-gmux.ko:
-  7 .rodata       00000140
+  7 .rodata       00000160
- 11 .data         000000e0
+ 11 .data         000000b8

Cc: Ben Skeggs 
Cc: Darren Hart 
Cc: Alex Deucher 
Signed-off-by: Lukas Wunner 
Reviewed-by: Christian König .
Signed-off-by: Daniel Vetter

vga_switcheroo: Use enum vga_switcheroo_client_id instead of int

2015-10-16T13:50:56+00:00

Signed-off-by: Lukas Wunner 
Reviewed-by: Alex Deucher 
Signed-off-by: Daniel Vetter

vga_switcheroo: Use VGA_SWITCHEROO_UNKNOWN_ID instead of -1

2015-10-16T13:50:56+00:00

Signed-off-by: Lukas Wunner 
Reviewed-by: Alex Deucher 
Signed-off-by: Daniel Vetter

vga_switcheroo: Use enum vga_switcheroo_state instead of int

2015-10-16T13:50:55+00:00

Signed-off-by: Lukas Wunner 
Reviewed-by: Jani Nikula 
Reviewed-by: Alex Deucher 
Signed-off-by: Daniel Vetter

vga_switcheroo: Add missing locking

2015-10-02T08:21:13+00:00

The following functions iterate over the client list, invoke client
callbacks or invoke handler callbacks without locking anything at all:

- Introduced by c8e9cf7bb240 ("vga_switcheroo: Add a helper function to
  get the client state"):
  vga_switcheroo_get_client_state()

- Introduced by 0d69704ae348 ("gpu/vga_switcheroo: add driver control
  power feature. (v3)"):
  vga_switcheroo_set_dynamic_switch()
  vga_switcheroo_runtime_suspend()
  vga_switcheroo_runtime_resume()
  vga_switcheroo_runtime_resume_hdmi_audio()

Refactor vga_switcheroo_runtime_resume_hdmi_audio() a bit to be able to
release vgasr_mutex immediately after iterating over the client list.

Signed-off-by: Lukas Wunner 
Signed-off-by: Daniel Vetter

vgaarb: use kzalloc in vga_arbiter_add_pci_device()

2015-10-01T09:25:23+00:00

Signed-off-by: Rasmus Villemoes 
Reviewed-by: Jani Nikula 
Signed-off-by: Daniel Vetter

vga_switcheroo: Set active attribute to false for audio clients

2015-09-24T18:14:25+00:00

The active attribute in struct vga_switcheroo_client denotes whether
the outputs are currently switched to this client. The attribute is
only meaningful for vga clients. It is never used for audio clients.

The function vga_switcheroo_register_audio_client() misuses this
attribute to store whether the audio device is fully initialized.
Most likely there was a misunderstanding about the meaning of
"active" when this was added.

Comment from Takashi's review:

"Not really.  The full initialization of audio was meant that the audio
is active indeed.  Admittedly, though, the active flag for each audio
client doesn't play any role because the audio always follows the gfx
state changes, and the value passed there doesn't reflect the actual
state due to the later change.  So, I agree with the removal of the
flag itself -- or let the audio active flag following the
corresponding gfx flag.  The latter will make the proc output more
consistent while the former is certainly more reduction of code."

Set the active attribute to false for audio clients. Remove the
active parameter from vga_switcheroo_register_audio_client() and
its sole caller, hda_intel.c:register_vga_switcheroo().

vga_switcheroo_register_audio_client() was introduced by 3e9e63dbd374
("vga_switcheroo: Add the support for audio clients"). Its use in
hda_intel.c was introduced by a82d51ed24bb ("ALSA: hda - Support
VGA-switcheroo").

v1.1: The changes above imply that in find_active_client() the call
to client_is_vga() is now superfluous. Drop it.

Cc: Takashi Iwai 
Signed-off-by: Lukas Wunner 
[danvet: Add Takashi's clarification to the commit message.]
Reviewed-by: Takashi Iwai 
Signed-off-by: Daniel Vetter

vga_switcheroo: Sort headers alphabetically

2015-09-24T18:14:19+00:00

Signed-off-by: Lukas Wunner 
Signed-off-by: Daniel Vetter