linux-toradex.git/drivers/gpu, branch v3.2-rc5

vmwgfx: Use kcalloc instead of kzalloc to allocate array

2011-12-07T10:44:41+00:00

The advantage of kcalloc is, that will prevent integer overflows which could
result from the multiplication of number of elements and size and it is also
a bit nicer to read.

The semantic patch that makes this change is available
in https://lkml.org/lkml/2011/11/25/107

Signed-off-by: Thomas Meyer 
Reviewed-by: Jakob Bornecrantz 
Signed-off-by: Dave Airlie

drm/i915: fix infinite recursion on unbind due to ilk vt-d w/a

2011-12-07T10:44:40+00:00

The recursion loop goes retire_requests->unbind->gpu_idle->retire_reqeusts.

Every time we go through this we need a
- active object that can be retired
- and there are no other references to that object than the one from
  the active list, so that it gets unbound and freed immediately.
Otherwise the recursion stops. So the recursion is only limited by the
number of objects that fit these requirements sitting in the active list
any time retire_request is called.

Issue exercised by tests/gem_unref_active_buffers from i-g-t.

There's been a decent bikeshed discussion whether it wouldn't be
better to pass around a flag, but imo this is o.k. for such a limited
case that only supports a w/a.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=42180

Signed-Off-by: Daniel Vetter 
Reviewed-by: Chris Wilson 
[ickle- we built better bikesheds, but this keeps the rain off for now]
Tested-by: Dave Airlie 
Signed-off-by: Dave Airlie

drm/radeon/kms: fix return type for radeon_encoder_get_dp_bridge_encoder_id

2011-12-07T10:44:38+00:00

Seems like something got mis-merged here.

Noticed by kallisti5 on IRC.

Signed-off-by: Alex Deucher 
Signed-off-by: Dave Airlie

vmwgfx: integer overflow in vmw_kms_update_layout_ioctl()

2011-12-02T10:49:41+00:00

There are two issues in vmw_kms_update_layout_ioctl().  First, the
for loop forgets to index rects and only checks the first element.
Second, there is a potential integer overflow if userspace passes
in a large arg->num_outputs.  The call to kzalloc() would allocate
a small buffer, leading to out-of-bounds read.

Reported-by: Haogang Chen 
Signed-off-by: Xi Wang 
Signed-off-by: Thomas Hellstrom 
Signed-off-by: Dave Airlie

drm/radeon/kms: fix 2D tiling CS support on EG/CM

2011-12-02T10:48:35+00:00

Fixes:
https://bugs.freedesktop.org/show_bug.cgi?id=43191

Signed-off-by: Alex Deucher 
Signed-off-by: Dave Airlie

drm/radeon/kms: fix scanout of 2D tiled buffers on EG/CM

2011-12-02T10:48:19+00:00

Fixes:
https://bugs.freedesktop.org/show_bug.cgi?id=43191

Signed-off-by: Alex Deucher 
Signed-off-by: Dave Airlie

drm: Fix lack of CRTC disable for drm_crtc_helper_set_config(.fb=NULL)

2011-12-02T10:47:15+00:00

Disabling the CRTC by setting its framebuffer to NULL, as used by
drm_framebuffer_cleanup(), was failing to pass the current framebuffer
to the crtc_func->disable callback. This is because of the dance within
drm_crtc_helper_set_config to pass the new_fb (NULL in this case) to the
drm_crtc_helper_set_mode with the currently attached fb as a parameter.
drm_crtc_helper_set_mode treats this as a no-op and the encoder is still
enabled. And so the current fb is forgotten before the call to
drm_helper_disable_unused_functions.

This patch treats disabling the CRTC as a simple special case rather
than adding further complexity into the configuration logic.

This fixes a pin-leak of the fb bo on Xserver close.

Signed-off-by: Chris Wilson 
Signed-off-by: Dave Airlie

drm/radeon/kms: Skip ACPI call to ATIF when possible

2011-12-01T09:57:34+00:00

I am under the impression that it only makes sense to call the ATIF
method if the graphics device has an ACPI handle attached. So we could
skip the call altogether if there is no such handle.

Signed-off-by: Jean Delvare 
Reviewed-by: Alex Deucher 
Signed-off-by: Dave Airlie

drm/radeon/kms: Hide debugging message

2011-12-01T09:57:03+00:00

Use the proper macro to issue the debugging message in
radeon_atif_call(). Otherwise we spam the log of many systems with a
message which looks like an error message of unknown origin, and could
thus confuse the user. Commit dc77de12dde95c8da39e4c417eb70c7d445cf84b
was a first step in this direction, but was not sufficient IMHO.

Signed-off-by: Jean Delvare 
Reviewed-by: Alex Deucher 
Signed-off-by: Dave Airlie

drm/radeon/kms: add some loop timeouts in pageflip code

2011-12-01T09:56:31+00:00

Avoid infinite loops waiting for surface updates if a GPU
reset happens while waiting for a page flip.

See:
https://bugs.freedesktop.org/show_bug.cgi?id=43191

Signed-off-by: Alex Deucher 
Cc: stable@kernel.org
Reviewed-by: Mario Kleiner 
Tested-by: Simon Farnsworth 
Signed-off-by: Dave Airlie