linux-toradex.git/drivers/hid/hid-lenovo.c, branch v5.14-rc7

HID: lenovo: Add support for Thinkpad X1 Tablet Thin keyboard

2021-04-07T10:48:20+00:00

The Thinkpad X1 Tablet Thin keyboard's HID interface for the media-keys
and other special functions, is quite similar to the Thinkpad 10 ultrabook
keyboard's mouse/media-keys HID interface.

The only difference is that it needs a bit different key mappings.

Add support for the mute-LED and the non-standard media-keys on this
keyboard by re-using the tp10_ultrabook_kbd code combined with a new
lenovo_input_mapping_x1_tab_kbd() function.

Co-authored-by: Alexander Kobel 
Tested-by: Alexander Kobel 
Signed-off-by: Alexander Kobel 
Signed-off-by: Hans de Goede 
Signed-off-by: Jiri Kosina

HID: lenovo: Rework how the tp10ubkbd code decides which USB interface to use

2021-04-07T10:48:19+00:00

Instead of looking for a hdev with a type of HID_TYPE_USBMOUSE find
the interface for the mute/mic-mute/fn-lock LEDs by checking for the
output-report which is used to set them.

This is a preparation patch for adding support for the LEDs on the
X1 tablet thin keyboard which uses the same output-report, but has
a separate (third) USB interface for the touchpad/mouse functionality.

Signed-off-by: Hans de Goede 
Signed-off-by: Jiri Kosina

HID: lenovo: Set default_triggers for the mute and micmute LEDs

2021-04-07T10:48:19+00:00

The mute and mic-mute LEDs should be automatically turned on/off based
on the audio-card's mixer settings.

Add the standardized default-trigger names for this, so that the alsa
code can turn the LEDs on/off as appropriate (on supported audio cards).

This brings the mute/mic-mute LED support inline with the thinkpad_acpi
support for the same LEDs in keyboards directly connected to the
laptop's embedded-controller.

Reviewed-by: Marek Behún 
Acked-by: Pavel Machek 
Signed-off-by: Hans de Goede 
Signed-off-by: Jiri Kosina

HID: lenovo: Map mic-mute button to KEY_F20 instead of KEY_MICMUTE

2021-04-07T10:48:19+00:00

Mapping the mic-mute button to KEY_MICMUTE is technically correct but
KEY_MICMUTE translates to a scancode of 256 (248 + 8) under X,
which does not fit in 8 bits, so it does not work.

Because of this userspace is expecting KEY_F20 instead,
theoretically KEY_MICMUTE should work under Wayland but even
there it does not work, because the desktop-environment is
listening only for KEY_F20 and not for KEY_MICMUTE.

Fixes: bc04b37ea0ec ("HID: lenovo: Add ThinkPad 10 Ultrabook Keyboard support")
Reviewed-by: Marek Behún 
Signed-off-by: Hans de Goede 
Signed-off-by: Jiri Kosina

HID: lenovo: Set LEDs max_brightness value

2021-04-07T10:48:19+00:00

The LEDs can only by turned on/off, so max_brightness should be set to 1.
Without this the max_brightness sysfs-attribute will report 255 which is
wrong.

Reviewed-by: Marek Behún 
Acked-by: Pavel Machek 
Signed-off-by: Hans de Goede 
Signed-off-by: Jiri Kosina

HID: lenovo: Remove lenovo_led_brightness_get()

2021-04-07T10:48:19+00:00

The led_classdev already contains a cached value of the last set
brightness, the brightness_get callback is only meant for LED drivers
which can read back the actual / current brightness from the hardware.

Since lenovo_led_brightness_get() just returns the last set value
it does not add any functionality, so we can just remove it.

Reviewed-by: Marek Behún 
Acked-by: Pavel Machek 
Signed-off-by: Hans de Goede 
Signed-off-by: Jiri Kosina

HID: lenovo: Check hid_get_drvdata() returns non NULL in lenovo_event()

2021-04-07T10:48:19+00:00

The HID lenovo probe function only attaches drvdata to one of the
USB interfaces, but lenovo_event() will get called for all USB interfaces
to which hid-lenovo is bound.

This allows a malicious device to fake being a device handled by
hid-lenovo, which generates events for which lenovo_event() has
special handling (and thus dereferences hid_get_drvdata()) on another
interface triggering a NULL pointer exception.

Add a check for hid_get_drvdata() returning NULL, avoiding this
possible NULL pointer exception.

Fixes: bc04b37ea0ec ("HID: lenovo: Add ThinkPad 10 Ultrabook Keyboard support")
Reviewed-by: Marek Behún 
Signed-off-by: Hans de Goede 
Signed-off-by: Jiri Kosina

HID: lenovo: Fix lenovo_led_set_tp10ubkbd() error handling

2021-04-07T10:48:19+00:00

Fix the following issues with lenovo_led_set_tp10ubkbd() error handling:

1. On success hid_hw_raw_request() returns the number of bytes sent.
   So we should check for (ret != 3) rather then for (ret != 0).

2. Actually propagate errors to the caller.

3. Since the LEDs are part of an USB keyboard-dock the mute LEDs can go
   away at any time. Don't log an error when ret == -ENODEV and set the
   LED_HW_PLUGGABLE flag to avoid errors getting logged when the USB gets
   disconnected.

Fixes: bc04b37ea0ec ("HID: lenovo: Add ThinkPad 10 Ultrabook Keyboard support")
Reviewed-by: Marek Behún 
Signed-off-by: Hans de Goede 
Signed-off-by: Jiri Kosina

HID: lenovo: Use brightness_set_blocking callback for setting LEDs brightness

2021-04-07T10:48:19+00:00

The lenovo_led_brightness_set function may sleep, so we should have the
the led_class_dev's brightness_set_blocking callback point to it, rather
then the regular brightness_set callback.

When toggled through sysfs this is not a problem, but the brightness_set
callback may be called from atomic context when using LED-triggers.

Fixes: bc04b37ea0ec ("HID: lenovo: Add ThinkPad 10 Ultrabook Keyboard support")
Reviewed-by: Marek Behún 
Acked-by: Pavel Machek 
Signed-off-by: Hans de Goede 
Signed-off-by: Jiri Kosina

HID: lenovo: Fix spurious F23 key press report during resume from suspend

2020-07-07T10:42:27+00:00

The Ultrabook Keyboard sends a spurious F23 key-press when resuming
from suspend. GNOME uses F23 to toggle the touchpad on/off so this causes
the OSD graphics for the touchpad toggle to show on resume.

The keyboard does not actually have a F23 key, se we can simple fix it
by marking the 0x00070072 HID usage, which normally is F23, to be ignored.

Signed-off-by: Hans de Goede 
Signed-off-by: Jiri Kosina