linux-toradex.git/drivers/hid/hid-magicmouse.c, branch v3.9.2

HID: magicmouse: fix race between input_register() and probe()

2013-04-04T07:49:56+00:00

Since kernel 3.7, it appears that the input registration occured before
the end of magicmouse_setup_input(). This is shown by receiving a lot of
"EV_SYN SYN_REPORT 1" instead of normal "EV_SYN SYN_REPORT 0".
This value means that the output buffer is full, and the user space
is loosing events.

Using .input_configured guarantees that the race is not occuring, and that
the call of "input_set_events_per_packet(input, 60)" is taken into account
by input_register().

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=908604

Cc: stable@vger.kernel.org
Reported-and-Tested-By: Clarke Wixon 
Signed-off-by: Benjamin Tissoires 
Signed-off-by: Jiri Kosina

HID: Use module_hid_driver macro

2013-01-03T09:27:31+00:00

Use the new module_hid_driver macro in all HID drivers that have
a simple register/unregister init/exit.

This also converts the hid drivers that test for a failure of
hid_register_driver() and report the failure. Using module_hid_driver
in those drivers removes the failure message.

Signed-off-by: H Hartley Sweeten 
Signed-off-by: Jiri Kosina

Input: MT - Add flags to input_mt_init_slots()

2012-09-19T17:50:18+00:00

Preparing to move more repeated code into the mt core, add a flags
argument to the input_mt_slots_init() function.

Reviewed-and-tested-by: Benjamin Tissoires 
Tested-by: Ping Cheng 
Acked-by: Dmitry Torokhov 
Signed-off-by: Henrik Rydberg

HID: magicmouse: Implement Multi-touch Protocol B (MT-B)

2012-07-04T18:58:48+00:00

The driver for Apple Magic Trackpad/Mouse currently uses
Multi-touch Protocol A (MT-A) to report touch events and uses
ABS_MT_TRACKING_ID to do finger tracking. The fact of the device
being able to track individual finger makes it possible to
report touch events using MT-B. This patch converts the driver
to use MT-B as it is preferred to MT-A.

V4: Removed BTN_TOUCH evnet.
V3: Removed the single touch related logic.
V2: Converting entirely to MT-B as Henrik Rydberg suggested.

Signed-off-by: Yufeng Shen 
Reviewed-and-tested-by: Henrik Rydberg 
Signed-off-by: Jiri Kosina

HID: magicmouse: Removing report_touches switch

2012-07-04T18:58:48+00:00

Remove the report_touches switch as it is not so useful to turn
off reporting touch events for a touch device. Let the userspace
to do the filtering if the turning off is needed.

V2: Remove report_touches as suggeted by Chase Douglas

Signed-off-by: Yufeng Shen 
Reviewed-and-tested-by: Henrik Rydberg 
Signed-off-by: Jiri Kosina

HID: magicmouse: Correct report range of major / minor axes

2012-06-25T13:30:15+00:00

In patch "HID: magicmouse: Adjust major / minor axes to scale",
touch_major and touch_minor axes are scaled by a factor of
four when reported but the max touch_major/minor is not scaled
accordingly. This patch scales the max touch_major/minor to
be consistent with the reported value.

Signed-off-by: Yufeng Shen 
Acked-by: Henrik Rydberg 
Signed-off-by: Jiri Kosina

HID: hid-magicmouse: Add pointer and buttonpad properties for Magic Trackpad

2012-02-21T10:52:20+00:00

Signed-off-by: Chase Douglas 
Signed-off-by: Jiri Kosina

HID: hid-magicmouse: Magic Trackpad has 1 button, not 2

2011-10-21T08:13:55+00:00

hid-magicmouse was advertising the Apple Magic Trackpad as having 2
buttons (left and right) when it actually only has 1 button.

Advertising multiple buttons makes Xorg disable all button 2 and 3
emulation (using multi-finger clicks). So Xorg users don't get working
right/middle-click emulation out of the box.

This patch makes hid-magicmouse correctly only report one real button
for Magic Trackpad, which in turn makes Xorg enable multi-finger click
support to emulate right/middle buttons.

[http://launchpad.net/bugs/862094]

Signed-off-by: Daniel van Vugt 
Reviewed-by: Chase Douglas 
Signed-off-by: Jiri Kosina

HID: magicmouse: ignore 'ivalid report id' while switching modes, v2

2011-08-25T12:21:37+00:00

This is basically a more generic respin of 23746a6 ("HID: magicmouse: ignore
'ivalid report id' while switching modes") which got reverted later by
c3a492.

It turns out that on some configurations, this is actually still the case
and we are not able to detect in runtime.

The device reponds with 'invalid report id' when feature report switching it
into multitouch mode is sent to it.

This has been silently ignored before 0825411ade ("HID: bt: Wait for ACK
on Sent Reports"), but since this commit, it propagates -EIO from the _raw
callback .

So let the driver ignore -EIO as response to 0xd7,0x01 report, as that's
how the device reacts in normal mode.

Sad, but following reality.

This fixes https://bugzilla.kernel.org/show_bug.cgi?id=35022

Reported-by: Chase Douglas 
Reported-by: Jaikumar Ganesh 
Tested-by: Chase Douglas 
Tested-by: Jaikumar Ganesh 
Signed-off-by: Jiri Kosina

HID: magicmouse: Set resolution of touch surfaces

2011-08-10T12:08:46+00:00

Add touch surface resolution information. The size of the touch surfaces
has been determined to the hundredth of a mm.

Cc: Jiri Kosina 
Cc: Michael Poole 
Cc: linux-input@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Chase Douglas 
[jkosina@suse.cz: update comments and commit message]
Signed-off-by: Jiri Kosina