linux-toradex.git/drivers/hid/hid-magicmouse.c, branch v4.20

HID: magicmouse: add support for Apple Magic Trackpad 2

2018-10-03T08:57:58+00:00

USB device
        Vendor 05ac (Apple)
        Device 0265 (Magic Trackpad 2)
Bluetooth device
        Vendor 004c (Apple)
        Device 0265 (Magic Trackpad 2)

Add support for Apple Magic Trackpad 2 over USB and bluetooth, putting
the device in multi-touch mode.

Signed-off-by: Claudio Mettler 
Signed-off-by: Marek Wyborski 
Signed-off-by: Sean O'Brien 
Reviewed-by: Benjamin Tissoires 
Signed-off-by: Jiri Kosina

HID: generic: create one input report per application type

2018-04-26T12:17:31+00:00

It is not a good idea to try to fit all types of applications in the
same input report. There are a lot of devices that are needing
the quirk HID_MULTI_INPUT but this quirk doesn't match the actual HID
description as it is based on the report ID.

Given that most devices with MULTI_INPUT I can think of split nicely
the devices inputs into application, it is a good thing to split the
devices by default based on this assumption.

Also make hid-multitouch following this rule, to not have to deal
with too many input created.

While we are at it, fix some checkpatch complaints about converting
'unsigned' to 'unsigned int'.

Signed-off-by: Benjamin Tissoires 
Signed-off-by: Jiri Kosina

treewide: Fix function prototypes for module_param_call()

2017-10-31T14:30:37+00:00

Several function prototypes for the set/get functions defined by
module_param_call() have a slightly wrong argument types. This fixes
those in an effort to clean up the calls when running under type-enforced
compiler instrumentation for CFI. This is the result of running the
following semantic patch:

@match_module_param_call_function@
declarer name module_param_call;
identifier _name, _set_func, _get_func;
expression _arg, _mode;
@@

 module_param_call(_name, _set_func, _get_func, _arg, _mode);

@fix_set_prototype
 depends on match_module_param_call_function@
identifier match_module_param_call_function._set_func;
identifier _val, _param;
type _val_type, _param_type;
@@

 int _set_func(
-_val_type _val
+const char * _val
 ,
-_param_type _param
+const struct kernel_param * _param
 ) { ... }

@fix_get_prototype
 depends on match_module_param_call_function@
identifier match_module_param_call_function._get_func;
identifier _val, _param;
type _val_type, _param_type;
@@

 int _get_func(
-_val_type _val
+char * _val
 ,
-_param_type _param
+const struct kernel_param * _param
 ) { ... }

Two additional by-hand changes are included for places where the above
Coccinelle script didn't notice them:

	drivers/platform/x86/thinkpad_acpi.c
	fs/lockd/svc.c

Signed-off-by: Kees Cook 
Signed-off-by: Jessica Yu

Revert "HID: magicmouse: Set multi-touch keybits for Magic Mouse"

2017-06-20T08:38:17+00:00

Setting these bits causes libinput to fail to initialize the device;
setting BTN_TOUCH and BTN_TOOL_FINGER causes it to treat the mouse as a
touchpad, and it then refuses to continue when it discovers ABS_X is not
set.

This breaks all known Wayland compositors, as well as Xorg when the
libinput driver is being used.

This reverts commit f4b65b9563216b3e01a5cc844c3ba68901d9b195.

Signed-off-by: Daniel Stone 
Cc: Che-Liang Chiou 
Cc: Thierry Escande 
Cc: Jiri Kosina 
Cc: Benjamin Tissoires 
Acked-by: Benjamin Tissoires 
Signed-off-by: Jiri Kosina

HID: magicmouse: Set multi-touch keybits for Magic Mouse

2017-05-05T13:31:35+00:00

The driver emits multi-touch events for Magic Trackpad as well as Magic
Mouse, but it does not set keybits that are related to multi-touch event
for Magic Mouse; so set these keybits.

The keybits that are not set cause trouble because user programs often
probe these keybits for self-configuration and thus they cannot operate
properly if the keybits are not set.

One of such troubles is that libevdev will not be able to emit correct
touch count, causing gestures library failed to do fling stop.

Signed-off-by: Che-Liang Chiou 
Signed-off-by: Thierry Escande 
Signed-off-by: Jiri Kosina

HID: magicmouse: make transfer buffers DMA capable

2016-11-23T16:43:25+00:00

Kernel v4.9 strictly enforces DMA capable buffers, so we need to remove
buffers allocated on the stack.

Signed-off-by: Benjamin Tissoires 
Signed-off-by: Jiri Kosina

HID: hid-input: allow input_configured callback return errors

2015-11-05T17:51:50+00:00

When configuring input device via input_configured callback we may
encounter errors (for example input_mt_init_slots() may fail). Instead
of continuing with half-initialized input device let's allow driver
indicate failures.

Signed-off-by: Jaikumar Ganesh 
Signed-off-by: Arve Hjønnevåg 
Reviewed-by: Benjamin Tissoires 
Reviewed-by: David Herrmann 
Acked-by: Nikolai Kondrashov 
Acked-by: Andrew Duggan 
Signed-off-by: Dmitry Torokhov 
Signed-off-by: Jiri Kosina

HID: magicmouse: sanity check report size in raw_event() callback

2014-08-27T07:14:39+00:00

The report passed to us from transport driver could potentially be
arbitrarily large, therefore we better sanity-check it so that
magicmouse_emit_touch() gets only valid values of raw_id.

Cc: stable@vger.kernel.org
Reported-by: Steven Vittitoe 
Signed-off-by: Jiri Kosina

HID: replace hid_output_raw_report with hid_hw_raw_request for feature requests

2014-02-17T13:56:50+00:00

  ret = hid_output_raw_report(A, B, C, HID_FEATURE_REPORT);
is equivalent to
  ret = hid_hw_raw_request(A, B[0], B, C, HID_FEATURE_REPORT, HID_REQ_SET_REPORT);
whatever the transport layer is.

So use the new API where available

Signed-off-by: Benjamin Tissoires 
Signed-off-by: Jiri Kosina

HID: introduce helper to access hid_output_raw_report()

2014-02-17T13:05:59+00:00

Add a helper to access hdev->hid_output_raw_report().

To convert the drivers, use the following snippets:

for i in drivers/hid/*.c
do
  sed -i.bak "s/[^ \t]*->hid_output_raw_report(/hid_output_raw_report(/g" $i
done

Then manually fix for checkpatch.pl

Reviewed-by: David Herrmann 
Signed-off-by: Benjamin Tissoires 
Signed-off-by: Jiri Kosina